diff --git a/data_platform/assets/ml/sql/.sqlfluff b/data_platform/assets/ml/sql/.sqlfluff new file mode 100644 index 0000000..30f96c1 --- /dev/null +++ b/data_platform/assets/ml/sql/.sqlfluff @@ -0,0 +1,4 @@ +[sqlfluff] +# SQLAlchemy :named_param bind parameters are misinterpreted by sqlfluff +# as cast operators, causing false LT01 spacing violations. Disable here. +exclude_rules = LT01 diff --git a/data_platform/assets/ml/sql/insert_notified.sql b/data_platform/assets/ml/sql/insert_notified.sql index 82f067e..118872d 100644 --- a/data_platform/assets/ml/sql/insert_notified.sql +++ b/data_platform/assets/ml/sql/insert_notified.sql @@ -1,3 +1,3 @@ insert into elo.notified (global_id) -values (: global_id) +values (:global_id) on conflict (global_id) do nothing diff --git a/data_platform/assets/ml/sql/select_top_predictions.sql b/data_platform/assets/ml/sql/select_top_predictions.sql index 8f82474..e4a90c2 100644 --- a/data_platform/assets/ml/sql/select_top_predictions.sql +++ b/data_platform/assets/ml/sql/select_top_predictions.sql @@ -15,6 +15,6 @@ from elo.predictions as ep inner join marts.funda_listings as fl on ep.global_id = fl.global_id left join elo.notified as en on ep.global_id = en.global_id where - ep.predicted_elo >=: min_elo + ep.predicted_elo >= :min_elo and en.global_id is null order by ep.predicted_elo desc diff --git a/data_platform/assets/ml/sql/select_training_data.sql b/data_platform/assets/ml/sql/select_training_data.sql index 9696242..aaf9126 100644 --- a/data_platform/assets/ml/sql/select_training_data.sql +++ b/data_platform/assets/ml/sql/select_training_data.sql @@ -23,4 +23,4 @@ select er.elo_rating from marts.funda_listings as fl inner join elo.ratings as er on fl.global_id = er.global_id -where er.comparison_count >=: min_comparisons +where er.comparison_count >= :min_comparisons diff --git a/data_platform/assets/ml/sql/upsert_prediction.sql b/data_platform/assets/ml/sql/upsert_prediction.sql index a947475..20e80ed 100644 --- a/data_platform/assets/ml/sql/upsert_prediction.sql +++ b/data_platform/assets/ml/sql/upsert_prediction.sql @@ -1,5 +1,5 @@ insert into elo.predictions (global_id, predicted_elo, mlflow_run_id) -values (: global_id,: predicted_elo,: mlflow_run_id) +values (:global_id, :predicted_elo, :mlflow_run_id) on conflict (global_id) do update set predicted_elo = excluded.predicted_elo,