From f6158d561ad17537eb9420fe5f273a07c1649839 Mon Sep 17 00:00:00 2001 From: Stijnvandenbroek Date: Wed, 4 Mar 2026 10:27:39 +0000 Subject: [PATCH] fix: ruff formatting --- data_platform/assets/funda.py | 21 ++++++++++++++++----- tests/test_assets_funda.py | 11 +++++++++-- tests/test_helpers.py | 4 +++- 3 files changed, 28 insertions(+), 8 deletions(-) diff --git a/data_platform/assets/funda.py b/data_platform/assets/funda.py index f6b8352..0af42e3 100644 --- a/data_platform/assets/funda.py +++ b/data_platform/assets/funda.py @@ -272,7 +272,9 @@ def funda_search_results( """ postgres.execute_many(insert_sql, rows) - context.log.info(f"Inserted {len(rows)} search results into {_SCHEMA}.search_results") + context.log.info( + f"Inserted {len(rows)} search results into {_SCHEMA}.search_results" + ) return MaterializeResult( metadata={ @@ -307,7 +309,9 @@ def funda_listing_details( # Read listing IDs from search results with engine.connect() as conn: - result = conn.execute(text(f"SELECT DISTINCT global_id FROM {_SCHEMA}.search_results")) + result = conn.execute( + text(f"SELECT DISTINCT global_id FROM {_SCHEMA}.search_results") + ) ids = [row[0] for row in result if row[0]] if not ids: @@ -436,11 +440,15 @@ def funda_price_history( # Read listings from details table with engine.connect() as conn: - result = conn.execute(text(f"SELECT DISTINCT global_id FROM {_SCHEMA}.listing_details")) + result = conn.execute( + text(f"SELECT DISTINCT global_id FROM {_SCHEMA}.listing_details") + ) ids = [row[0] for row in result if row[0]] if not ids: - context.log.warning("No listing details found – run funda_listing_details first.") + context.log.warning( + "No listing details found – run funda_listing_details first." + ) return MaterializeResult(metadata={"count": 0}) context.log.info(f"Fetching price history for {len(ids)} listings …") @@ -505,7 +513,10 @@ def funda_price_history( def _search_preview_table(rows: list[dict]) -> str: """Build a markdown table for search result metadata preview.""" - lines = ["| Title | City | Price | Area | Bedrooms |", "| --- | --- | --- | --- | --- |"] + lines = [ + "| Title | City | Price | Area | Bedrooms |", + "| --- | --- | --- | --- | --- |", + ] for r in rows: price = f"€{r['price']:,}" if r.get("price") else "–" area = f"{r['living_area']} m²" if r.get("living_area") else "–" diff --git a/tests/test_assets_funda.py b/tests/test_assets_funda.py index 4c2b861..2aceae9 100644 --- a/tests/test_assets_funda.py +++ b/tests/test_assets_funda.py @@ -111,7 +111,11 @@ class TestFundaSearchResults: "postgres": MockPostgresResource(engine, rows), }, run_config={ - "ops": {"funda_search_results": {"config": {"max_pages": 1, **(config or {})}}} + "ops": { + "funda_search_results": { + "config": {"max_pages": 1, **(config or {})} + } + } }, ) return result @@ -188,7 +192,10 @@ class TestFundaSearchResults: client = MagicMock() client.search_listing.return_value = [] self._run(client, config={"object_type": "house, apartment"}) - assert client.search_listing.call_args[1]["object_type"] == ["house", "apartment"] + assert client.search_listing.call_args[1]["object_type"] == [ + "house", + "apartment", + ] def test_energy_label_split_by_comma(self): client = MagicMock() diff --git a/tests/test_helpers.py b/tests/test_helpers.py index 6e67cbd..f831875 100644 --- a/tests/test_helpers.py +++ b/tests/test_helpers.py @@ -114,7 +114,9 @@ class TestSearchPreviewTable: assert "–" in result def test_multiple_rows_correct_count(self): - rows = [{"title": f"St {i}", "city": "City", "price": i * 1000} for i in range(5)] + rows = [ + {"title": f"St {i}", "city": "City", "price": i * 1000} for i in range(5) + ] result = _search_preview_table(rows) lines = result.split("\n") # header + separator + 5 data rows