From 76998a137aff4b5e549edfe7cccf0edecfd7461b Mon Sep 17 00:00:00 2001 From: mmancini-skao Date: Mon, 20 Oct 2025 17:09:35 +0200 Subject: [PATCH] Fix error in Taylor expansion (#36) Replaced term3 with term4 in calculations for t4. --- src/lookup_xsimd.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lookup_xsimd.cpp b/src/lookup_xsimd.cpp index 4f9d894..5fb499d 100644 --- a/src/lookup_xsimd.cpp +++ b/src/lookup_xsimd.cpp @@ -120,7 +120,7 @@ template struct sinf_dispatcher { const b_type dx4 = xsimd::mul(dx2, dx); const b_type t2 = xsimd::mul(dx2, term2); const b_type t3 = xsimd::mul(dx3, term3); - const b_type t4 = xsimd::mul(dx4, term3); + const b_type t4 = xsimd::mul(dx4, term4); const b_type cosdx = xsimd::add(xsimd::sub(term1, t2), t4); const b_type sindx = xsimd::sub(dx, t3); @@ -183,7 +183,7 @@ template struct sin_cosf_dispatcher { const b_type dx4 = xsimd::mul(dx2, dx); const b_type t2 = xsimd::mul(dx2, term2); const b_type t3 = xsimd::mul(dx3, term3); - const b_type t4 = xsimd::mul(dx4, term3); + const b_type t4 = xsimd::mul(dx4, term4); idx = xsimd::bitwise_and(idx, mask); b_type sinv = b_type::gather(lookup_table_.sin_values.data(), idx);