From 97692cface1911070a0a8ee94fcedf5d433b7f98 Mon Sep 17 00:00:00 2001
From: Bram Veenboer <bram.veenboer@gmail.com>
Date: Thu, 14 Aug 2025 11:02:30 +0200
Subject: [PATCH] Use Type template for helper functions

---
 python/bindings.cpp | 43 +++++++++++++++++++++++--------------------
 1 file changed, 23 insertions(+), 20 deletions(-)

diff --git a/python/bindings.cpp b/python/bindings.cpp
index 5c57756..1988e98 100644
--- a/python/bindings.cpp
+++ b/python/bindings.cpp
@@ -6,42 +6,45 @@
 
 namespace py = pybind11;
 
-py::array_t<float> compute_sinf_py(
-    const Backend &backend,
-    py::array_t<float, py::array::c_style | py::array::forcecast> x) {
+template <typename T>
+py::array_t<T>
+compute_sin(const Backend &backend,
+            py::array_t<T, py::array::c_style | py::array::forcecast> x) {
   ssize_t n = x.shape(0);
-  auto x_ptr = x.data();
+  const T *x_ptr = x.data();
 
   py::array_t<float> s(n);
-  auto s_ptr = s.mutable_data();
+  T *s_ptr = s.mutable_data();
 
   backend.compute_sinf(static_cast<size_t>(n), x_ptr, s_ptr);
 
   return s;
 }
 
-py::array_t<float> compute_cosf_py(
-    const Backend &backend,
-    py::array_t<float, py::array::c_style | py::array::forcecast> x) {
+template <typename T>
+py::array_t<T>
+compute_cos(const Backend &backend,
+            py::array_t<T, py::array::c_style | py::array::forcecast> x) {
   ssize_t n = x.shape(0);
-  auto x_ptr = x.data();
+  const T *x_ptr = x.data();
 
-  py::array_t<float> c(n);
-  auto c_ptr = c.mutable_data();
+  py::array_t<T> c(n);
+  T *c_ptr = c.mutable_data();
 
   backend.compute_cosf(static_cast<size_t>(n), x_ptr, c_ptr);
 
   return c;
 }
 
-std::tuple<py::array_t<float>, py::array_t<float>> compute_sincosf_py(
-    const Backend &backend,
-    py::array_t<float, py::array::c_style | py::array::forcecast> x) {
+template <typename T>
+std::tuple<py::array_t<T>, py::array_t<T>>
+compute_sincos(const Backend &backend,
+               py::array_t<T, py::array::c_style | py::array::forcecast> x) {
   ssize_t n = x.shape(0);
-  auto x_ptr = x.data();
+  const T *x_ptr = x.data();
 
-  py::array_t<float> s(n);
-  py::array_t<float> c(n);
+  py::array_t<T> s(n);
+  py::array_t<T> c(n);
 
   backend.compute_sincosf(static_cast<size_t>(n), x_ptr, s.mutable_data(),
                           c.mutable_data());
@@ -53,9 +56,9 @@ template <typename BackendType>
 void bind_backend(py::module &m, const char *name) {
   py::class_<BackendType, Backend, std::shared_ptr<BackendType>>(m, name)
       .def(py::init<>())
-      .def("compute_sinf", &compute_sinf_py)
-      .def("compute_cosf", &compute_cosf_py)
-      .def("compute_sincosf", &compute_sincosf_py);
+      .def("compute_sinf", &compute_sin<float>)
+      .def("compute_cosf", &compute_cos<float>)
+      .def("compute_sincosf", &compute_sincos<float>);
 }
 
 PYBIND11_MODULE(pytrigdx, m) {