dynamic partition names

apps/vinyl/src/assets.py

@@ -179,7 +179,7 @@ def new_deals(
 
     ic(partitions.keys())
     partition_keys = get_partition_keys(context)
-    ic(partition_keys)
+    ic(partition_keys.keys())
 
     parsed_partition_keys = parse_partition_keys(context, "partitions")
     ic(parsed_partition_keys)

apps/vinyl/src/jobs.py

@@ -10,7 +10,7 @@ kwargs = dict(tags={"app": APP})
 job = partial(dg.job, **kwargs)
 define_asset_job = partial(dg.define_asset_job, **kwargs)
 
-deals_job = define_asset_job(
+deals_job = dg.define_asset_job(
     "deals_job",
     selection=[assets.deals.key],
     partitions_def=assets.deals.partitions_def,
@@ -32,12 +32,15 @@ def check_partitions(context: dg.OpExecutionContext) -> None:
         asset_path = "/".join(asset_key.path)
         ic(storage_dir, asset_key, asset_path)
 
+        dimension_names = asset.partitions_def.partition_dimension_names
+        ic(dimension_names)
+
         partitions = []
         for row in (
             pl.scan_parquet(
                 f"{storage_dir}/{asset_path}/*/*.parquet", extra_columns="ignore"
             )
-            .select(["date", "source"])  # asset.partitions_def.names ?
+            .select(dimension_names)
             .unique()
             .with_columns(pl.exclude(pl.String).cast(str))
             .collect()

shared/src/shared/utils.py

@@ -21,7 +21,7 @@ def get_dimension_names(
     """
     partition_definition = context.asset_partitions_def_for_input(input_name)
     if isinstance(partition_definition, dg.MultiPartitionsDefinition):
-        return [x.name for x in partition_definition.partitions_defs]
+        return partition_definition.partition_dimension_names
     raise NotImplementedError("Only MultiPartitionsDefinition is supported.")