From d1b66be6364b906559a787fb0d53f4ee5407eef4 Mon Sep 17 00:00:00 2001
From: Rik Veenboer <rik.veenboer@gmail.com>
Date: Sun, 27 Jul 2025 15:22:01 +0200
Subject: [PATCH] attempt to overwrite run launch container kwargs

---
 apps/vinyl/src/definitions.py | 48 +++++++++++++++++++++++++++++++++++
 compose.code.yaml             |  1 +
 dagster.yaml                  |  1 +
 3 files changed, 50 insertions(+)

diff --git a/apps/vinyl/src/definitions.py b/apps/vinyl/src/definitions.py
index 2e79eaf..7ff14dd 100644
--- a/apps/vinyl/src/definitions.py
+++ b/apps/vinyl/src/definitions.py
@@ -1,6 +1,9 @@
 import os
+from pathlib import Path
 
 import assets
+import yaml
+from dagster_docker import docker_executor
 from dagster_polars import PolarsParquetIOManager
 from icecream import install
 from jobs import check_partitions_job, deals_job
@@ -12,6 +15,50 @@ import dagster as dg
 APP = os.environ["APP"]
 
 install()
+
+
+def deep_merge_dicts(base: dict, override: dict) -> dict:
+    """
+    Recursively merge two dictionaries.
+    Values from `override` will overwrite or be merged into `base`.
+    """
+    result = base.copy()
+    for key, override_value in override.items():
+        base_value = result.get(key)
+        if isinstance(base_value, dict) and isinstance(override_value, dict):
+            result[key] = deep_merge_dicts(base_value, override_value)
+        else:
+            result[key] = override_value
+    return result
+
+
+path = Path("dagster.yaml")
+if path.exists():
+    with path.open() as fp:
+        tmp = yaml.safe_load(fp)
+        print(tmp)
+else:
+    tmp = {}
+
+tmp = tmp.get("run_launcher", {}).get("config", {})
+res = deep_merge_dicts(
+    tmp,
+    {
+        "container_kwargs": {
+            "volumes": [
+                "/opt/dagster/shared/:/shared/:ro",
+                "/opt/dagster/apps/:/apps:ro",
+                "/opt/dagster/storage/:/storage/:rw",
+                "/opt/dagster/logs/:/logs:rw",
+                "/opt/dagster/cache/:/cache:rw",
+                "/tmp/something:/something:rw",
+            ]
+        }
+    },
+)
+
+print(res)
+
 definitions = dg.Definitions(
     assets=[
         asset.with_attributes(
@@ -35,4 +82,5 @@ definitions = dg.Definitions(
     },
     jobs=[deals_job, check_partitions_job],
     schedules=[deals_schedule],
+    executor=docker_executor.configured(res),
 )
diff --git a/compose.code.yaml b/compose.code.yaml
index 3bbf892..8d84e38 100644
--- a/compose.code.yaml
+++ b/compose.code.yaml
@@ -32,6 +32,7 @@ services:
       <<: [ *dagster_env, *email_env ]
       DAGSTER_CURRENT_IMAGE: dagster-code-vinyl
     volumes:
+      - /opt/dagster/dagster.yaml:/opt/dagster/home/dagster.yaml:ro
       - /opt/dagster/apps/:/apps/:ro
       - /opt/dagster/shared/:/shared/:ro
       - /opt/dagster/logs/:/logs:rw
diff --git a/dagster.yaml b/dagster.yaml
index c750ab3..5bc6e84 100644
--- a/dagster.yaml
+++ b/dagster.yaml
@@ -31,6 +31,7 @@ run_launcher:
         - /opt/dagster/apps/:/apps:ro
         - /opt/dagster/storage/:/storage/:rw
         - /opt/dagster/logs/:/logs:rw
+        - /opt/dagster/cache/:/cache:rw
 
 run_storage:
   module: dagster_postgres.run_storage