rik/jlibcom
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SF2935662 excepInfo not initialized so NULL check says not null and manipulates uninitialized data.

Browse Source
This commit is contained in:
clay_shooter
2010-11-08 02:01:16 +00:00
parent 5b88936d48
commit 657e5980d9
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
docs/ReleaseNotes.html
View File

@@ -32,6 +32,11 @@
checked on every object creation for users who run in the standard checked on every object creation for users who run in the standard
<i>all classes in ROT</i> mode. (M2)</td> <i>all classes in ROT</i> mode. (M2)</td>
</tr> </tr>
<tr>
<td width="13%" valign="top">2935662</td>
<td width="87%" valign="top">Error handling code crashes because of uninitialized data in Dispatch.cpp
Check for NULL fails. pfnDeferredFillIn pointer is not initialized, but it's not NULL.</td>
</tr>
<tr> <tr>
<td width="13%" valign="top">&nbsp;</td> <td width="13%" valign="top">&nbsp;</td>
<td width="87%" valign="top">&nbsp;</td> <td width="87%" valign="top">&nbsp;</td>

2
jni/Dispatch.cpp
View File

@@ -418,6 +418,8 @@ JNIEXPORT jobject JNICALL Java_com_jacob_com_Dispatch_invokev
{ {
DISPPARAMS dispparams; DISPPARAMS dispparams;
EXCEPINFO excepInfo; EXCEPINFO excepInfo;
// Sourceforge Bug Tracker 2935662 uninitialized data can be not NULL with bad results
excepInfo.pfnDeferredFillIn = NULL;
IDispatch *pIDispatch = extractDispatch(env, disp); IDispatch *pIDispatch = extractDispatch(env, disp);
if (!pIDispatch) return NULL; if (!pIDispatch) return NULL;