fixed some FindBugs errors

This commit is contained in:
KARASZI István
2011-09-26 17:05:39 +02:00
parent b7ee1fe29a
commit 04f603820f
4 changed files with 29 additions and 19 deletions

View File

@@ -82,8 +82,8 @@ public class PipeliningTest extends Assert {
assertEquals("foo", zset.get().iterator().next()); assertEquals("foo", zset.get().iterator().next());
assertEquals("foo", set.get()); assertEquals("foo", set.get());
assertEquals(false, blist.get()); assertEquals(false, blist.get());
assertEquals(new Double(2), zincrby.get()); assertEquals(Double.valueOf(2), zincrby.get());
assertEquals(new Long(1), zcard.get()); assertEquals(Long.valueOf(1), zcard.get());
assertEquals(1, lrange.get().size()); assertEquals(1, lrange.get().size());
assertNotNull(hgetAll.get().get("foo")); assertNotNull(hgetAll.get().get("foo"));
assertEquals(1, smembers.get().size()); assertEquals(1, smembers.get().size());

View File

@@ -152,8 +152,8 @@ public class ShardedJedisPoolTest extends Assert {
shards.set(1, new JedisShardInfo("nohost", 1234)); shards.set(1, new JedisShardInfo("nohost", 1234));
pool = new ShardedJedisPool(redisConfig, shards); pool = new ShardedJedisPool(redisConfig, shards);
jedis = pool.getResource(); jedis = pool.getResource();
Long actual = new Long(0); Long actual = Long.valueOf(0);
Long fails = new Long(0); Long fails = Long.valueOf(0);
for (int i = 0; i < 1000; i++) { for (int i = 0; i < 1000; i++) {
try { try {
jedis.get("a-test-" + i); jedis.get("a-test-" + i);

View File

@@ -1,18 +1,28 @@
package redis.clients.jedis.tests; package redis.clients.jedis.tests;
import org.junit.Before;
import org.junit.Test;
import redis.clients.jedis.*;
import redis.clients.jedis.exceptions.JedisDataException;
import java.io.UnsupportedEncodingException;
import java.util.*;
import static junit.framework.Assert.assertEquals; import static junit.framework.Assert.assertEquals;
import static junit.framework.Assert.assertNull; import static junit.framework.Assert.assertNull;
import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull; import static org.junit.Assert.assertNotNull;
import java.io.UnsupportedEncodingException;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.UUID;
import org.junit.Before;
import org.junit.Test;
import redis.clients.jedis.Jedis;
import redis.clients.jedis.JedisShardInfo;
import redis.clients.jedis.Response;
import redis.clients.jedis.ShardedJedis;
import redis.clients.jedis.ShardedJedisPipeline;
import redis.clients.jedis.Tuple;
import redis.clients.jedis.exceptions.JedisDataException;
public class SharedJedisPipelineTest { public class SharedJedisPipelineTest {
private static HostAndPortUtil.HostAndPort redis1 = HostAndPortUtil.getRedisServers() private static HostAndPortUtil.HostAndPort redis1 = HostAndPortUtil.getRedisServers()
.get(0); .get(0);
@@ -81,8 +91,8 @@ public class SharedJedisPipelineTest {
assertEquals("foo", zset.get().iterator().next()); assertEquals("foo", zset.get().iterator().next());
assertEquals("foo", set.get()); assertEquals("foo", set.get());
assertFalse(blist.get()); assertFalse(blist.get());
assertEquals(new Double(2), zincrby.get()); assertEquals(Double.valueOf(2), zincrby.get());
assertEquals(new Long(1), zcard.get()); assertEquals(Long.valueOf(1), zcard.get());
assertEquals(1, lrange.get().size()); assertEquals(1, lrange.get().size());
assertNotNull(hgetAll.get().get("foo")); assertNotNull(hgetAll.get().get("foo"));
assertEquals(1, smembers.get().size()); assertEquals(1, smembers.get().size());

View File

@@ -64,8 +64,8 @@ public abstract class JedisCommandTestBase extends JedisTestBase {
} }
} }
if (!contained) { if (!contained) {
throw new ComparisonFailure("element is missing", next throw new ComparisonFailure("element is missing",
.toString(), actual.toString()); Arrays.toString(next), actual.toString());
} }
} }
} }