rik/jlibredis
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use Arrays.equals(...) instead of hand written method for arrays comparison

Browse Source
This commit is contained in:
Yaourt
2010-11-05 10:56:54 +01:00
parent a2b3417fce
commit 9ff9ab3505
1 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/test/java/redis/clients/jedis/tests/JedisTest.java
View File

@@ -1,5 +1,6 @@
package redis.clients.jedis.tests; package redis.clients.jedis.tests;
import java.util.Arrays;
import java.util.HashMap; import java.util.HashMap;
import java.util.Iterator; import java.util.Iterator;
import java.util.List; import java.util.List;
@@ -62,10 +63,9 @@ public class JedisTest extends JedisCommandTestBase {
if(exp instanceof byte[] && resp instanceof byte[]) { if(exp instanceof byte[] && resp instanceof byte[]) {
final byte[] bexp = (byte[]) exp; final byte[] bexp = (byte[]) exp;
final byte[] bresp = (byte[]) resp; final byte[] bresp = (byte[]) resp;
if(isArraysAreEquals(bexp, bresp)) { if(Arrays.equals(bexp, bresp)) {
found = true; found = true;
} }
// Assert.assertArrayEquals(bexp, bresp);
} else if (exp instanceof List && resp instanceof List) { } else if (exp instanceof List && resp instanceof List) {
final List subexp = (List) exp; final List subexp = (List) exp;
final List subresp = (List) resp; final List subresp = (List) resp;
@@ -86,17 +86,17 @@ public class JedisTest extends JedisCommandTestBase {
return true; return true;
} }
public static boolean isArraysAreEquals(final byte[] expected, final byte[] result) { // public static boolean isArraysAreEqualsPlop(final byte[] expected, final byte[] result) {
if(expected.length != result.length) { // if(expected.length != result.length) {
return false; // return false;
} // }
//
for(int i=0; i < expected.length; i++) { // for(int i=0; i < expected.length; i++) {
if(expected[i] != result[i]) { // if(expected[i] != result[i]) {
return false; // return false;
} // }
} // }
//
return true; // return true;
} // }
} }