Apply "Java Convention" to met Jedis's preferred source code Convention

This commit is contained in:
Jungtaek Lim
2014-02-05 00:45:48 +09:00
parent 13f0c32f7c
commit dd62e360fa

View File

@@ -22,13 +22,15 @@ public class JedisSentinelTest extends JedisTestBase {
protected static HostAndPort master = HostAndPortUtil.getRedisServers() protected static HostAndPort master = HostAndPortUtil.getRedisServers()
.get(0); .get(0);
protected static HostAndPort slave = HostAndPortUtil.getRedisServers().get(5); protected static HostAndPort slave = HostAndPortUtil.getRedisServers().get(
5);
protected static HostAndPort sentinel = HostAndPortUtil protected static HostAndPort sentinel = HostAndPortUtil
.getSentinelServers().get(0); .getSentinelServers().get(0);
protected static HostAndPort sentinelForFailover = HostAndPortUtil.getSentinelServers() protected static HostAndPort sentinelForFailover = HostAndPortUtil
.get(3); .getSentinelServers().get(3);
protected static HostAndPort masterForFailover = HostAndPortUtil.getRedisServers().get(6); protected static HostAndPort masterForFailover = HostAndPortUtil
.getRedisServers().get(6);
@Before @Before
public void setup() throws InterruptedException { public void setup() throws InterruptedException {
@@ -41,23 +43,24 @@ public class JedisSentinelTest extends JedisTestBase {
// to restore it (demote) // to restore it (demote)
// so, promote(slaveof) slave to master has no effect, not same to old // so, promote(slaveof) slave to master has no effect, not same to old
// Sentinel's behavior // Sentinel's behavior
ensureRemoved(MONITOR_MASTER_NAME); ensureRemoved(MONITOR_MASTER_NAME);
ensureRemoved(REMOVE_MASTER_NAME); ensureRemoved(REMOVE_MASTER_NAME);
} }
@Test @Test
public void sentinel() { public void sentinel() {
Jedis j = new Jedis(sentinel.getHost(), sentinel.getPort()); Jedis j = new Jedis(sentinel.getHost(), sentinel.getPort());
List<Map<String, String>> masters = j.sentinelMasters(); List<Map<String, String>> masters = j.sentinelMasters();
boolean inMasters = false; boolean inMasters = false;
for (Map<String, String> master : masters) for (Map<String, String> master : masters)
if (MASTER_NAME.equals(master.get("name"))) if (MASTER_NAME.equals(master.get("name")))
inMasters = true; inMasters = true;
assertTrue(inMasters); assertTrue(inMasters);
List<String> masterHostAndPort = j.sentinelGetMasterAddrByName(MASTER_NAME); List<String> masterHostAndPort = j
.sentinelGetMasterAddrByName(MASTER_NAME);
HostAndPort masterFromSentinel = new HostAndPort( HostAndPort masterFromSentinel = new HostAndPort(
masterHostAndPort.get(0), Integer.parseInt(masterHostAndPort masterHostAndPort.get(0), Integer.parseInt(masterHostAndPort
.get(1))); .get(1)));
@@ -65,7 +68,8 @@ public class JedisSentinelTest extends JedisTestBase {
List<Map<String, String>> slaves = j.sentinelSlaves(MASTER_NAME); List<Map<String, String>> slaves = j.sentinelSlaves(MASTER_NAME);
assertTrue(slaves.size() > 0); assertTrue(slaves.size() > 0);
assertEquals(master.getPort(), Integer.parseInt(slaves.get(0).get("master-port"))); assertEquals(master.getPort(),
Integer.parseInt(slaves.get(0).get("master-port")));
// DO NOT RE-RUN TEST TOO FAST, RESET TAKES SOME TIME TO... RESET // DO NOT RE-RUN TEST TOO FAST, RESET TAKES SOME TIME TO... RESET
assertEquals(Long.valueOf(1), j.sentinelReset(MASTER_NAME)); assertEquals(Long.valueOf(1), j.sentinelReset(MASTER_NAME));
@@ -73,96 +77,105 @@ public class JedisSentinelTest extends JedisTestBase {
} }
@Test @Test
public void sentinelFailover() throws InterruptedException { public void sentinelFailover() throws InterruptedException {
Jedis j = new Jedis(sentinelForFailover.getHost(), sentinelForFailover.getPort()); Jedis j = new Jedis(sentinelForFailover.getHost(),
sentinelForFailover.getPort());
HostAndPort currentMaster = new HostAndPort(masterForFailover.getHost(), masterForFailover.getPort()); HostAndPort currentMaster = new HostAndPort(
masterForFailover.getHost(), masterForFailover.getPort());
List<String> masterHostAndPort = j.sentinelGetMasterAddrByName(FAILOVER_MASTER_NAME); List<String> masterHostAndPort = j
String result = j.sentinelFailover(FAILOVER_MASTER_NAME); .sentinelGetMasterAddrByName(FAILOVER_MASTER_NAME);
assertEquals("OK", result); String result = j.sentinelFailover(FAILOVER_MASTER_NAME);
assertEquals("OK", result);
JedisSentinelTestUtil.waitForNewPromotedMaster(sentinelForFailover, FAILOVER_MASTER_NAME, currentMaster); JedisSentinelTestUtil.waitForNewPromotedMaster(sentinelForFailover,
FAILOVER_MASTER_NAME, currentMaster);
masterHostAndPort = j.sentinelGetMasterAddrByName(FAILOVER_MASTER_NAME); masterHostAndPort = j.sentinelGetMasterAddrByName(FAILOVER_MASTER_NAME);
HostAndPort newMaster = new HostAndPort(masterHostAndPort.get(0), HostAndPort newMaster = new HostAndPort(masterHostAndPort.get(0),
Integer.parseInt(masterHostAndPort.get(1))); Integer.parseInt(masterHostAndPort.get(1)));
assertNotEquals(newMaster, currentMaster); assertNotEquals(newMaster, currentMaster);
} }
@Test @Test
public void sentinelMonitor() { public void sentinelMonitor() {
Jedis j = new Jedis(sentinel.getHost(), sentinel.getPort()); Jedis j = new Jedis(sentinel.getHost(), sentinel.getPort());
// monitor new master // monitor new master
String result = j.sentinelMonitor(MONITOR_MASTER_NAME, MASTER_IP, master.getPort(), 1); String result = j.sentinelMonitor(MONITOR_MASTER_NAME, MASTER_IP,
assertEquals("OK", result); master.getPort(), 1);
assertEquals("OK", result);
// already monitored // already monitored
try { try {
j.sentinelMonitor(MONITOR_MASTER_NAME, MASTER_IP, master.getPort(), 1); j.sentinelMonitor(MONITOR_MASTER_NAME, MASTER_IP, master.getPort(),
fail(); 1);
} catch (JedisDataException e) { fail();
// pass } catch (JedisDataException e) {
} // pass
}
}
@Test
public void sentinelRemove() {
Jedis j = new Jedis(sentinel.getHost(), sentinel.getPort());
ensureMonitored(sentinel, REMOVE_MASTER_NAME, MASTER_IP,
master.getPort(), 1);
String result = j.sentinelRemove(REMOVE_MASTER_NAME);
assertEquals("OK", result);
// not exist
try {
result = j.sentinelRemove(REMOVE_MASTER_NAME);
assertNotEquals("OK", result);
fail();
} catch (JedisDataException e) {
// pass
}
}
@Test
public void sentinelSet() {
Jedis j = new Jedis(sentinel.getHost(), sentinel.getPort());
Map<String, String> parameterMap = new HashMap<String, String>();
parameterMap.put("down-after-milliseconds", String.valueOf(1234));
parameterMap.put("parallel-syncs", String.valueOf(3));
parameterMap.put("quorum", String.valueOf(2));
j.sentinelSet(MASTER_NAME, parameterMap);
List<Map<String, String>> masters = j.sentinelMasters();
for (Map<String, String> master : masters) {
if (master.get("name").equals(MASTER_NAME)) {
assertEquals(1234,
Integer.parseInt(master.get("down-after-milliseconds")));
assertEquals(3, Integer.parseInt(master.get("parallel-syncs")));
assertEquals(2, Integer.parseInt(master.get("quorum")));
}
} }
@Test parameterMap.put("quorum", String.valueOf(1));
public void sentinelRemove() { j.sentinelSet(MASTER_NAME, parameterMap);
Jedis j = new Jedis(sentinel.getHost(), sentinel.getPort()); }
ensureMonitored(sentinel, REMOVE_MASTER_NAME, MASTER_IP, master.getPort(), 1); private void ensureMonitored(HostAndPort sentinel, String masterName,
String ip, int port, int quorum) {
String result = j.sentinelRemove(REMOVE_MASTER_NAME); Jedis j = new Jedis(sentinel.getHost(), sentinel.getPort());
assertEquals("OK", result); try {
j.sentinelMonitor(masterName, ip, port, quorum);
// not exist } catch (JedisDataException e) {
try {
result = j.sentinelRemove(REMOVE_MASTER_NAME);
assertNotEquals("OK", result);
fail();
} catch (JedisDataException e) {
// pass
}
} }
}
@Test private void ensureRemoved(String masterName) {
public void sentinelSet() { Jedis j = new Jedis(sentinel.getHost(), sentinel.getPort());
Jedis j = new Jedis(sentinel.getHost(), sentinel.getPort()); try {
j.sentinelRemove(masterName);
Map<String, String> parameterMap = new HashMap<String, String>(); } catch (JedisDataException e) {
parameterMap.put("down-after-milliseconds", String.valueOf(1234));
parameterMap.put("parallel-syncs", String.valueOf(3));
parameterMap.put("quorum", String.valueOf(2));
j.sentinelSet(MASTER_NAME, parameterMap);
List<Map<String,String>> masters = j.sentinelMasters();
for (Map<String, String> master : masters) {
if (master.get("name").equals(MASTER_NAME)) {
assertEquals(1234, Integer.parseInt(master.get("down-after-milliseconds")));
assertEquals(3, Integer.parseInt(master.get("parallel-syncs")));
assertEquals(2, Integer.parseInt(master.get("quorum")));
}
}
parameterMap.put("quorum", String.valueOf(1));
j.sentinelSet(MASTER_NAME, parameterMap);
}
private void ensureMonitored(HostAndPort sentinel, String masterName, String ip, int port, int quorum) {
Jedis j = new Jedis(sentinel.getHost(), sentinel.getPort());
try {
j.sentinelMonitor(masterName, ip, port, quorum);
} catch (JedisDataException e) {
}
}
private void ensureRemoved(String masterName) {
Jedis j = new Jedis(sentinel.getHost(), sentinel.getPort());
try {
j.sentinelRemove(masterName);
} catch (JedisDataException e) {
}
} }
}
} }