rik/jlibredis
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Hashes hkeys and hvals refactored to return a set instead of a list.

Browse Source 
It looks like the order is not guaranted, so a set seems much adapted than a list.
This commit is contained in:
Yaourt
2010-11-08 15:57:43 +01:00
parent e8704296fd
commit dd6874aa7a
7 changed files with 32 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/test/java/redis/clients/jedis/tests/commands/HashesCommandsTest.java
View File

@@ -222,11 +222,11 @@ public class HashesCommandsTest extends JedisCommandTestBase {
hash.put("car", "bar");
jedis.hmset("foo", hash);
List<String> keys = jedis.hkeys("foo");
List<String> expected = new ArrayList<String>();
Set<String> keys = jedis.hkeys("foo");
Set<String> expected = new HashSet<String>();
expected.add("bar");
expected.add("car");
assertTrue(JedisTest.isListAreEquals(expected, keys));
assertTrue(JedisTest.isSetAreEquals(expected, keys));
//Binary
Map<byte[], byte[]> bhash = new LinkedHashMap<byte[], byte[]>();
@@ -234,11 +234,11 @@ public class HashesCommandsTest extends JedisCommandTestBase {
bhash.put(bcar, bbar);
jedis.hmset(bfoo, bhash);
List<byte[]> bkeys = jedis.hkeys(bfoo);
List<byte[]> bexpected = new ArrayList<byte[]>();
Set<byte[]> bkeys = jedis.hkeys(bfoo);
Set<byte[]> bexpected = new HashSet<byte[]>();
bexpected.add(bbar);
bexpected.add(bcar);
assertTrue(JedisTest.isListAreEquals(bexpected, bkeys));
assertTrue(JedisTest.isSetAreEquals(bexpected, bkeys));
}
@@ -249,11 +249,11 @@ public class HashesCommandsTest extends JedisCommandTestBase {
hash.put("car", "bar");
jedis.hmset("foo", hash);
List<String> vals = jedis.hvals("foo");
List<String> expected = new ArrayList<String>();
Set<String> vals = jedis.hvals("foo");
Set<String> expected = new HashSet<String>();
expected.add("car");
expected.add("bar");
assertTrue(JedisTest.isListAreEquals(expected, vals));
assertTrue(JedisTest.isSetAreEquals(expected, vals));
//Binary
Map<byte[], byte[]> bhash = new LinkedHashMap<byte[], byte[]>();
@@ -261,11 +261,11 @@ public class HashesCommandsTest extends JedisCommandTestBase {
bhash.put(bcar, bbar);
jedis.hmset(bfoo, bhash);
List<byte[]> bvals = jedis.hvals(bfoo);
List<byte[]> bexpected = new ArrayList<byte[]>();
Set<byte[]> bvals = jedis.hvals(bfoo);
Set<byte[]> bexpected = new HashSet<byte[]>();
bexpected.add(bcar);
bexpected.add(bbar);
assertTrue(JedisTest.isListAreEquals(bexpected, bvals));
assertTrue(JedisTest.isSetAreEquals(bexpected, bvals));
}