mirror/trigdx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Wiebe van Breukelen <breukelen@astron.nl>
This commit is contained in:
Bram Veenboer
2025-09-02 16:26:27 +02:00
committed by GitHub
parent 3dcca92b79
commit a1f2dd6c4d
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
benchmarks/benchmark_utils.hpp
View File

@@ -57,6 +57,10 @@ static void benchmark_cosf(benchmark::State &state) {
reinterpret_cast<float *>(backend.allocate_memory(N * sizeof(float)));
float *c =
reinterpret_cast<float *>(backend.allocate_memory(N * sizeof(float)));
if (!x || !c) {
throw std::runtime_error("Buffer allocation failed");
}
auto end = std::chrono::high_resolution_clock::now();
state.counters["init_ms"] =
std::chrono::duration_cast<std::chrono::microseconds>(end - start)
@@ -91,6 +95,9 @@ static void benchmark_sincosf(benchmark::State &state) {
reinterpret_cast<float *>(backend.allocate_memory(N * sizeof(float)));
float *c =
reinterpret_cast<float *>(backend.allocate_memory(N * sizeof(float)));
if (!x || !s || !c) {
throw std::runtime_error("Buffer allocation failed");
}
auto end = std::chrono::high_resolution_clock::now();
state.counters["init_ms"] =
std::chrono::duration_cast<std::chrono::microseconds>(end - start)

4
include/trigdx/interface.hpp
View File

@@ -12,10 +12,10 @@ public:
virtual void init(size_t n = 0) {}
virtual void *allocate_memory(size_t bytes) const {
return std::malloc(bytes);
return static_cast<void*>(new uint8_t[bytes]);
};
virtual void free_memory(void *ptr) const { std::free(ptr); };
virtual void free_memory(void *ptr) const { delete[] ptr; };
// Compute sine for n elements
virtual void compute_sinf(size_t n, const float *x, float *s) const = 0;