Fixed pb_get_message_size

CHANGELOG

@@ -1,70 +0,0 @@
-nanopb-0.1.9.1
- Fix security issue due to size_t overflows. (issue 132)
-
- NOTE: nanopb-0.1.x is and will remain affected by issue 97.
-       A fix would be too intrusive for a support release.
-
-nanopb-0.1.9
- Fixed error message bugs (issues 52, 56)
- Sanitize #ifndef filename (issue 50)
- Performance improvements
- Add compile-time option PB_BUFFER_ONLY
- Add Java package name to nanopb.proto
- Check for sizeof(double) == 8 (issue 54)
- Added generator option to ignore some fields. (issue 51)
- Added generator option to make message structs packed. (issue 49)
- Add more test cases.
-
-nanopb-0.1.8
- Fix bugs in the enum short names introduced in 0.1.7 (issues 42, 43)
- Fix STATIC_ASSERT macro when using multiple .proto files. (issue 41)
- Fix missing initialization of istream.errmsg
- Make tests/Makefile work for non-gcc compilers (issue 40)
-
-nanopb-0.1.7
- Remove "skip" mode from pb_istream_t callbacks. Example implementation had a bug. (issue 37)
- Add option to use shorter names for enum values (issue 38)
- Improve options support in generator (issues 12, 30)
- Add nanopb version number to generated files (issue 36)
- Add extern "C" to generated headers (issue 35)
- Add names for structs to allow forward declaration (issue 39)
- Add buffer size check in example (issue 34)
- Fix build warnings on MS compilers (issue 33)
-
-nanopb-0.1.6
- Reorganize the field decoder interface (issue 2)
- Improve performance in submessage decoding (issue 28)
- Implement error messages in the decoder side (issue 7)
- Extended testcases (alltypes test is now complete).
- Fix some compiler warnings (issues 25, 26, 27, 32).
-
-nanopb-0.1.5
- Fix bug in decoder with packed arrays (issue 23).
- Extended testcases.
- Fix some compiler warnings.
-
-nanopb-0.1.4
- Add compile-time options for easy-to-use >255 field support.
- Improve the detection of missing required fields.
- Added example on how to handle union messages.
- Fix generator error with .proto without messages.
- Fix problems that stopped the code from compiling with some compilers.
- Fix some compiler warnings.
-
-nanopb-0.1.3
- Refactor the field encoder interface.
- Improve generator error messages (issue 5)
- Add descriptor.proto into the #include exclusion list
- Fix some compiler warnings.
-
-nanopb-0.1.2
- Make the generator to generate include for other .proto files (issue 4).
- Fixed generator not working on Windows (issue 3)
-
-nanopb-0.1.1
- Fixed bug in encoder with 'bytes' fields (issue 1).
- Fixed a bug in the generator that caused a compiler error on sfixed32 and sfixed64 fields.
- Extended testcases.
-
-nanopb-0.1.0
- First stable release.

README

@@ -5,7 +5,14 @@ Homepage: http://kapsi.fi/~jpa/nanopb/
 To compile the library, you'll need these libraries:
 protobuf-compiler python-protobuf libprotobuf-dev
 
-The only runtime dependencies are memset() and memcpy().
-
 To run the tests, run make under the tests folder.
-If it completes without error, everything is fine.
+If it completes without error, everything is fine. 
+
+Code size optimization is currently only supported for 32-bit 
+architecture. If you want to run on 64-bit architecture,
+you must disable code size optimization by providing -n option to
+code generator nanopb_generator.py.  
+
+For testing purpose, you may need to pass -m32 compiler to gcc if 
+you're running on a 64-bit machine unless -n option is used for code 
+generation. 

docs/concepts.rst

@@ -38,20 +38,6 @@ This file, in turn, requires the file *google/protobuf/descriptor.proto*. This i
 
     protoc -I/usr/include -Inanopb/generator -I. -omessage.pb message.proto
 
-The options can be defined in file, message and field scopes::
-
-    option (nanopb_fileopt).max_size = 20; // File scope
-    message Message
-    {
-        option (nanopb_msgopt).max_size = 30; // Message scope
-        required string fieldsize = 1 [(nanopb).max_size = 40]; // Field scope
-    }
-
-It is also possible to give the options on command line, but then they will affect the whole file. For example::
-
-    user@host:~$ python ../generator/nanopb_generator.py -s 'max_size: 20' message.pb
-
-
 Streams
 =======
 
@@ -64,7 +50,6 @@ There are a few generic rules for callback functions:
 #) Use state to store your own data, such as a file descriptor.
 #) *bytes_written* and *bytes_left* are updated by pb_write and pb_read.
 #) Your callback may be used with substreams. In this case *bytes_left*, *bytes_written* and *max_size* have smaller values than the original stream. Don't use these values to calculate pointers.
-#) Always read or write the full requested length of data. For example, POSIX *recv()* needs the *MSG_WAITALL* parameter to accomplish this.
 
 Output streams
 --------------
@@ -106,8 +91,9 @@ Writing to stdout::
 
 Input streams
 -------------
-For input streams, there is one extra rule:
+For input streams, there are a few extra rules:
 
+#) If buf is NULL, read from stream but don't store the data. This is used to skip unknown input.
 #) You don't need to know the length of the message in advance. After getting EOF error when reading, set bytes_left to 0 and return false. Pb_decode will detect this and if the EOF was in a proper position, it will return true.
 
 Here is the structure::
@@ -272,14 +258,18 @@ generates this field description array for the structure *Person_PhoneNumber*::
 Return values and error handling
 ================================
 
-Most functions in nanopb return bool: *true* means success, *false* means failure. There is also some support for error messages for debugging purposes: the error messages go in *stream->errmsg*.
+Most functions in nanopb return bool: *true* means success, *false* means failure. If this is enough for you, skip this section.
 
-The error messages help in guessing what is the underlying cause of the error. The most common error conditions are:
+For simplicity, nanopb doesn't define it's own error codes. This might be added if there is a compelling need for it. You can however deduce something about the error causes:
 
 1) Running out of memory. Because everything is allocated from the stack, nanopb can't detect this itself. Encoding or decoding the same type of a message always takes the same amount of stack space. Therefore, if it works once, it works always.
 2) Invalid field description. These are usually stored as constants, so if it works under the debugger, it always does.
-3) IO errors in your own stream callbacks.
+3) IO errors in your own stream callbacks. Because encoding/decoding stops at the first error, you can overwrite the *state* field in the struct and store your own error code there.
-4) Errors that happen in your callback functions.
+4) Errors that happen in your callback functions. You can use the state field in the callback structure.
 5) Exceeding the max_size or bytes_left of a stream.
 6) Exceeding the max_size of a string or array field
-7) Invalid protocol buffers binary message.
+7) Invalid protocol buffers binary message. It's not like you could recover from it anyway, so a simple failure should be enough.
+
+In my opinion, it is enough that 1. and 2. can be resolved using a debugger.
+
+However, you may be interested which of the remaining conditions caused the error. For 3. and 4., you can set and check the state. If you have to detect 5. and 6., you should convert the fields to callback type. Any remaining problem is of type 7.

docs/reference.rst

@@ -6,30 +6,6 @@ Nanopb: API reference
 
 .. contents ::
 
-Compilation options
-===================
-The following options can be specified using -D switch given to the C compiler:
-
-============================  ================================================================================================
-__BIG_ENDIAN__                 Set this if your platform stores integers and floats in big-endian format.
-                               Mixed-endian systems (different layout for ints and floats) are currently not supported.
-NANOPB_INTERNALS               Set this to expose the field encoder functions that are hidden since nanopb-0.1.3.
-PB_MAX_REQUIRED_FIELDS         Maximum number of required fields to check for presence. Default value is 64. Increases stack
-                               usage 1 byte per every 8 fields. Compiler warning will tell if you need this.
-PB_FIELD_16BIT                 Add support for tag numbers > 255 and fields larger than 255 bytes or 255 array entries.
-                               Increases code size 3 bytes per each field. Compiler error will tell if you need this.
-PB_FIELD_32BIT                 Add support for tag numbers > 65535 and fields larger than 65535 bytes or 65535 array entries.
-                               Increases code size 9 bytes per each field. Compiler error will tell if you need this.
-PB_NO_ERRMSG                   Disables the support for error messages; only error information is the true/false return value.
-                               Decreases the code size by a few hundred bytes.
-PB_BUFFER_ONLY                 Disables the support for custom streams. Only supports encoding to memory buffers.
-                               Speeds up execution and decreases code size slightly.
-============================  ================================================================================================
-
-The PB_MAX_REQUIRED_FIELDS, PB_FIELD_16BIT and PB_FIELD_32BIT settings allow raising some datatype limits to suit larger messages.
-Their need is recognized automatically by C-preprocessor #if-directives in the generated .pb.h files. The default setting is to use
-the smallest datatypes (least resources used).
-
 pb.h
 ====
 
@@ -90,7 +66,7 @@ Describes a single structure field with memory position in relation to others. T
 :array_size:    Maximum number of entries in an array, if it is an array type.
 :ptr:           Pointer to default value for optional fields, or to submessage description for PB_LTYPE_SUBMESSAGE.
 
-The *uint8_t* datatypes limit the maximum size of a single item to 255 bytes and arrays to 255 items. Compiler will give error if the values are too large. The types can be changed to larger ones by defining *PB_FIELD_16BIT*.
+The *uint8_t* datatypes limit the maximum size of a single item to 255 bytes and arrays to 255 items. Compiler will warn "Initializer too large for type" if the limits are exceeded. The types can be changed to larger ones if necessary.
 
 pb_bytes_array_t
 ----------------
@@ -173,13 +149,17 @@ Encodes the contents of a structure as a protocol buffers message and writes it
 
 Normally pb_encode simply walks through the fields description array and serializes each field in turn. However, submessages must be serialized twice: first to calculate their size and then to actually write them to output. This causes some constraints for callback fields, which must return the same data on every call.
 
-.. sidebar:: Encoding fields manually
+pb_encode_varint
+----------------
+Encodes an unsigned integer in the varint_ format. ::
 
-    The functions with names *pb_encode_\** are used when dealing with callback fields. The typical reason for using callbacks is to have an array of unlimited size. In that case, `pb_encode`_ will call your callback function, which in turn will call *pb_encode_\** functions repeatedly to write out values.
+    bool pb_encode_varint(pb_ostream_t *stream, uint64_t value);
 
-    The tag of a field must be encoded separately with `pb_encode_tag_for_field`_. After that, you can call exactly one of the content-writing functions to encode the payload of the field. For repeated fields, you can repeat this process multiple times.
+:stream:        Output stream to write to. 1-10 bytes will be written.
+:value:         Value to encode.
+:returns:       True on success, false on IO error.
 
-    Writing packed arrays is a little bit more involved: you need to use `pb_encode_tag` and specify `PB_WT_STRING` as the wire type. Then you need to know exactly how much data you are going to write, and use `pb_encode_varint`_ to write out the number of bytes before writing the actual data. Substreams can be used to determine the number of bytes beforehand; see `pb_encode_submessage`_ source code for an example.
+.. _varint: http://code.google.com/apis/protocolbuffers/docs/encoding.html#varints
 
 pb_encode_tag
 -------------
@@ -189,7 +169,7 @@ Starts a field in the Protocol Buffers binary format: encodes the field number a
 
 :stream:        Output stream to write to. 1-5 bytes will be written.
 :wiretype:      PB_WT_VARINT, PB_WT_64BIT, PB_WT_STRING or PB_WT_32BIT
-:field_number:  Identifier for the field, defined in the .proto file. You can get it from field->tag.
+:field_number:  Identifier for the field, defined in the .proto file.
 :returns:       True on success, false on IO error.
 
 pb_encode_tag_for_field
@@ -215,71 +195,107 @@ STRING, BYTES, SUBMESSAGE PB_WT_STRING
 FIXED32                   PB_WT_32BIT
 ========================= ============
 
-pb_encode_varint
-----------------
-Encodes a signed or unsigned integer in the varint_ format. Works for fields of type `bool`, `enum`, `int32`, `int64`, `uint32` and `uint64`::
-
-    bool pb_encode_varint(pb_ostream_t *stream, uint64_t value);
-
-:stream:        Output stream to write to. 1-10 bytes will be written.
-:value:         Value to encode. Just cast e.g. int32_t directly to uint64_t.
-:returns:       True on success, false on IO error.
-
-.. _varint: http://code.google.com/apis/protocolbuffers/docs/encoding.html#varints
-
-pb_encode_svarint
------------------
-Encodes a signed integer in the 'zig-zagged' format. Works for fields of type `sint32` and `sint64`::
-
-    bool pb_encode_svarint(pb_ostream_t *stream, int64_t value);
-
-(parameters are the same as for `pb_encode_varint`_
-
 pb_encode_string
 ----------------
-Writes the length of a string as varint and then contents of the string. Works for fields of type `bytes` and `string`::
+Writes the length of a string as varint and then contents of the string. Used for writing fields with wire type PB_WT_STRING. ::
 
     bool pb_encode_string(pb_ostream_t *stream, const uint8_t *buffer, size_t size);
 
 :stream:        Output stream to write to.
 :buffer:        Pointer to string data.
-:size:          Number of bytes in the string. Pass `strlen(s)` for strings.
+:size:          Number of bytes in the string.
 :returns:       True on success, false on IO error.
 
-pb_encode_fixed32
+.. sidebar:: Field encoders
------------------
-Writes 4 bytes to stream and swaps bytes on big-endian architectures. Works for fields of type `fixed32`, `sfixed32` and `float`::
 
-    bool pb_encode_fixed32(pb_ostream_t *stream, const void *value);
+    The functions with names beginning with *pb_enc_* are called field encoders. Each PB_LTYPE has an own field encoder, which handles translating from C data into Protocol Buffers data.
 
-:stream:    Output stream to write to.
+    By using the *data_size* in the field description and by taking advantage of C casting rules, it has been possible to combine many data types to a single LTYPE. For example, *int32*, *uint32*, *int64*, *uint64*, *bool* and *enum* are all handled by *pb_enc_varint*.
-:value:     Pointer to a 4-bytes large C variable, for example `uint32_t foo;`.
-:returns:   True on success, false on IO error.
 
-pb_encode_fixed64
+    Each field encoder only encodes the contents of the field. The tag must be encoded separately with `pb_encode_tag_for_field`_.
------------------
-Writes 8 bytes to stream and swaps bytes on big-endian architecture. Works for fields of type `fixed64`, `sfixed64` and `double`::
 
-    bool pb_encode_fixed64(pb_ostream_t *stream, const void *value);
+    You can use the field encoders from your callbacks. Just be aware that the pb_field_t passed to the callback is not directly compatible with most of the encoders. Instead, you must create a new pb_field_t structure and set the data_size according to the data type you pass to *src*.
 
-:stream:    Output stream to write to.
+pb_enc_varint
-:value:     Pointer to a 8-bytes large C variable, for example `uint64_t foo;`.
+-------------
-:returns:   True on success, false on IO error.
+Field encoder for PB_LTYPE_VARINT. Takes the first *field->data_size* bytes from src, casts them as *uint64_t* and calls `pb_encode_varint`_. ::
 
-pb_encode_submessage
+    bool pb_enc_varint(pb_ostream_t *stream, const pb_field_t *field, const void *src);
---------------------
-Encodes a submessage field, including the size header for it. Works for fields of any message type::
-
-    bool pb_encode_submessage(pb_ostream_t *stream, const pb_field_t fields[], const void *src_struct);
 
 :stream:        Output stream to write to.
-:fields:        Pointer to the autogenerated field description array for the submessage type, e.g. `MyMessage_fields`.
+:field:         Field description structure. Only *data_size* matters.
+:src:           Pointer to start of the field data.
+:returns:       True on success, false on IO error.
+
+pb_enc_svarint
+--------------
+Field encoder for PB_LTYPE_SVARINT. Similar to `pb_enc_varint`_, except first zig-zag encodes the value for more efficient negative number encoding. ::
+
+    bool pb_enc_svarint(pb_ostream_t *stream, const pb_field_t *field, const void *src);
+
+(parameters are the same as for `pb_enc_varint`_)
+
+The number is considered negative if the high-order bit of the value is set. On big endian computers, it is the highest bit of *\*src*. On little endian computers, it is the highest bit of *\*(src + field->data_size - 1)*.
+
+pb_enc_fixed32
+--------------
+Field encoder for PB_LTYPE_FIXED32. Writes the data in little endian order. On big endian computers, reverses the order of bytes. ::
+
+    bool pb_enc_fixed32(pb_ostream_t *stream, const pb_field_t *field, const void *src);
+
+:stream:        Output stream to write to.
+:field:         Not used.
+:src:           Pointer to start of the field data.
+:returns:       True on success, false on IO error.
+
+pb_enc_fixed64
+--------------
+Field encoder for PB_LTYPE_FIXED64. Writes the data in little endian order. On big endian computers, reverses the order of bytes. ::
+
+    bool pb_enc_fixed64(pb_ostream_t *stream, const pb_field_t *field, const void *src);
+
+(parameters are the same as for `pb_enc_fixed32`_)
+
+The same function is used for both integers and doubles. This breaks encoding of double values on architectures where they are mixed endian (primarily some arm processors with hardware FPU).
+
+pb_enc_bytes
+------------
+Field encoder for PB_LTYPE_BYTES. Just calls `pb_encode_string`_. ::
+
+    bool pb_enc_bytes(pb_ostream_t *stream, const pb_field_t *field, const void *src);
+
+:stream:        Output stream to write to.
+:field:         Not used.
+:src:           Pointer to a structure similar to pb_bytes_array_t.
+:returns:       True on success, false on IO error.
+
+This function expects a pointer to a structure with a *size_t* field at start, and a variable sized byte array after it. The platform-specific field offset is inferred from *pb_bytes_array_t*, which has a byte array of size 1.
+
+pb_enc_string
+-------------
+Field encoder for PB_LTYPE_STRING. Determines size of string with strlen() and then calls `pb_encode_string`_. ::
+
+    bool pb_enc_string(pb_ostream_t *stream, const pb_field_t *field, const void *src);
+
+:stream:        Output stream to write to.
+:field:         Not used.
+:src:           Pointer to a null-terminated string.
+:returns:       True on success, false on IO error.
+
+pb_enc_submessage
+-----------------
+Field encoder for PB_LTYPE_SUBMESSAGE. Calls `pb_encode`_ to perform the actual encoding. ::
+
+    bool pb_enc_submessage(pb_ostream_t *stream, const pb_field_t *field, const void *src);
+
+:stream:        Output stream to write to.
+:field:         Field description structure. The *ptr* field must be a pointer to a field description array for the submessage.
 :src:           Pointer to the structure where submessage data is.
 :returns:       True on success, false on IO errors, pb_encode errors or if submessage size changes between calls.
 
 In Protocol Buffers format, the submessage size must be written before the submessage contents. Therefore, this function has to encode the submessage twice in order to know the size beforehand.
 
-If the submessage contains callback fields, the callback function might misbehave and write out a different amount of data on the second call. This situation is recognized and *false* is returned, but garbage will be written to the output before the problem is detected.
+If the submessage contains callback fields, the callback function might misbehave and write out a different amount of data on the second call. This situation is recognized and *false* is returned, but it is up to the caller to ensure that the receiver of the message does not interpret it as valid data.
 
 pb_decode.h
 ===========
@@ -307,32 +323,15 @@ Read data from input stream. Always use this function, don't try to call the str
 
 End of file is signalled by *stream->bytes_left* being zero after pb_read returns false.
 
-pb_decode
+pb_decode_varint
----------
-Read and decode all fields of a structure. Reads until EOF on input stream. ::
-
-    bool pb_decode(pb_istream_t *stream, const pb_field_t fields[], void *dest_struct);
-
-:stream:        Input stream to read from.
-:fields:        A field description array. Usually autogenerated.
-:dest_struct:   Pointer to structure where data will be stored.
-:returns:       True on success, false on IO error, on detectable errors in field description, if a field encoder returns false or if a required field is missing.
-
-In Protocol Buffers binary format, EOF is only allowed between fields. If it happens anywhere else, pb_decode will return *false*. If pb_decode returns false, you cannot trust any of the data in the structure.
-
-In addition to EOF, the pb_decode implementation supports terminating a message with a 0 byte. This is compatible with the official Protocol Buffers because 0 is never a valid field tag.
-
-For optional fields, this function applies the default value and sets *has_<field>* to false if the field is not present.
-
-pb_decode_noinit
 ----------------
-Same as `pb_decode`_, except does not apply the default values to fields. ::
+Read and decode a varint_ encoded integer. ::
 
-    bool pb_decode_noinit(pb_istream_t *stream, const pb_field_t fields[], void *dest_struct);
+    bool pb_decode_varint(pb_istream_t *stream, uint64_t *dest);
 
-(parameters are the same as for `pb_decode`_.)
+:stream:        Input stream to read from. 1-10 bytes will be read.
-
+:dest:          Storage for the decoded integer. Value is undefined on error.
-The destination structure should be filled with zeros before calling this function. Doing a *memset* manually can be slightly faster than using `pb_decode`_ if you don't need any default values.
+:returns:       True on success, false if value exceeds uint64_t range or an IO error happens.
 
 pb_skip_varint
 --------------
@@ -352,66 +351,67 @@ Skip a varint-length-prefixed string. This means skipping a value with wire type
 :stream:        Input stream to read from.
 :returns:       True on success, false on IO error or length exceeding uint32_t.
 
-pb_decode_tag
+pb_decode
--------------
+---------
-Decode the tag that comes before field in the protobuf encoding::
+Read and decode all fields of a structure. Reads until EOF on input stream. ::
 
-    bool pb_decode_tag(pb_istream_t *stream, pb_wire_type_t *wire_type, int *tag, bool *eof);
+    bool pb_decode(pb_istream_t *stream, const pb_field_t fields[], void *dest_struct);
 
 :stream:        Input stream to read from.
-:wire_type:     Pointer to variable where to store the wire type of the field.
+:fields:        A field description array. Usually autogenerated.
-:tag:           Pointer to variable where to store the tag of the field.
+:dest_struct:   Pointer to structure where data will be stored.
-:eof:           Pointer to variable where to store end-of-file status.
+:returns:       True on success, false on IO error, on detectable errors in field description, if a field encoder returns false or if a required field is missing.
-:returns:       True on success, false on error or EOF.
 
-When the message (stream) ends, this function will return false and set *eof* to true. On other
+In Protocol Buffers binary format, EOF is only allowed between fields. If it happens anywhere else, pb_decode will return *false*. If pb_decode returns false, you cannot trust any of the data in the structure.
-errors, *eof* will be set to false.
 
-pb_skip_field
+In addition to EOF, the pb_decode implementation supports terminating a message with a 0 byte. This is compatible with the official Protocol Buffers because 0 is never a valid field tag.
--------------
-Remove the data for a field from the stream, without actually decoding it::
 
-    bool pb_skip_field(pb_istream_t *stream, pb_wire_type_t wire_type);
+For optional fields, this function applies the default value and sets *has_<field>* to false if the field is not present.
 
-:stream:        Input stream to read from.
+Because of memory concerns, the detection of missing required fields is not perfect if the structure contains more than 32 fields.
-:wire_type:     Type of field to skip.
-:returns:       True on success, false on IO error.
 
-.. sidebar:: Decoding fields manually
+.. sidebar:: Field decoders
     
-    The functions with names beginning with *pb_decode_* are used when dealing with callback fields. The typical reason for using callbacks is to have an array of unlimited size. In that case, `pb_decode`_ will call your callback function repeatedly, which can then store the values into e.g. filesystem in the order received in.
+    The functions with names beginning with *pb_dec_* are called field decoders. Each PB_LTYPE has an own field decoder, which handles translating from Protocol Buffers data to C data.
 
-    For decoding numeric (including enumerated and boolean) values, use `pb_decode_varint`_, `pb_decode_svarint`_, `pb_decode_fixed32`_ and `pb_decode_fixed64`_. They take a pointer to a 32- or 64-bit C variable, which you may then cast to smaller datatype for storage.
+    Each field decoder reads and decodes a single value. For arrays, the decoder is called repeatedly.
 
-    For decoding strings and bytes fields, the length has already been decoded. You can therefore check the total length in *stream->bytes_left* and read the data using `pb_read`_.
+    You can use the decoders from your callbacks. Just be aware that the pb_field_t passed to the callback is not directly compatible 
+    with the *varint* field decoders. Instead, you must create a new pb_field_t structure and set the data_size according to the data type 
+    you pass to *dest*, e.g. *field.data_size = sizeof(int);*. Other fields in the *pb_field_t* don't matter.
 
-    Finally, for decoding submessages in a callback, simply use `pb_decode`_ and pass it the *SubMessage_fields* descriptor array.
+    The field decoder interface is a bit messy as a result of the interface required inside the nanopb library.
+    Eventually they may be replaced by separate wrapper functions with a more friendly interface.
 
-pb_decode_varint
+pb_dec_varint
-----------------
+-------------
-Read and decode a varint_ encoded integer. ::
+Field decoder for PB_LTYPE_VARINT. ::
 
-    bool pb_decode_varint(pb_istream_t *stream, uint64_t *dest);
+    bool pb_dec_varint(pb_istream_t *stream, const pb_field_t *field, void *dest)
 
 :stream:        Input stream to read from. 1-10 bytes will be read.
-:dest:          Storage for the decoded integer. Value is undefined on error.
+:field:         Field description structure. Only *field->data_size* matters.
-:returns:       True on success, false if value exceeds uint64_t range or an IO error happens.
+:dest:          Pointer to destination integer. Must have size of *field->data_size* bytes.
+:returns:       True on success, false on IO errors or if `pb_decode_varint`_ fails.
 
-pb_decode_svarint
+This function first calls `pb_decode_varint`_. It then copies the first bytes of the 64-bit result value to *dest*, or on big endian architectures, the last bytes.
------------------
-Similar to `pb_decode_varint`_, except that it performs zigzag-decoding on the value. This corresponds to the Protocol Buffers *sint32* and *sint64* datatypes. ::
 
-    bool pb_decode_svarint(pb_istream_t *stream, int64_t *dest);
+pb_dec_svarint
+--------------
+Field decoder for PB_LTYPE_SVARINT. Similar to `pb_dec_varint`_, except that it performs zigzag-decoding on the value. ::
 
-(parameters are the same as `pb_decode_varint`_)
+    bool pb_dec_svarint(pb_istream_t *stream, const pb_field_t *field, void *dest);
 
-pb_decode_fixed32
+(parameters are the same as `pb_dec_varint`_)
------------------
-Decode a *fixed32*, *sfixed32* or *float* value. ::
 
-    bool pb_decode_fixed32(pb_istream_t *stream, void *dest);
+pb_dec_fixed32
+--------------
+Field decoder for PB_LTYPE_FIXED32. ::
+
+    bool pb_dec_fixed32(pb_istream_t *stream, const pb_field_t *field, void *dest);
 
 :stream:        Input stream to read from. 4 bytes will be read.
+:field:         Not used.
 :dest:          Pointer to destination *int32_t*, *uint32_t* or *float*.
 :returns:       True on success, false on IO errors.
 
@@ -419,9 +419,9 @@ This function reads 4 bytes from the input stream.
 On big endian architectures, it then reverses the order of the bytes.
 Finally, it writes the bytes to *dest*.
 
-pb_decode_fixed64
+pb_dec_fixed64
------------------
+--------------
-Decode a *fixed64*, *sfixed64* or *double* value. ::
+Field decoder for PB_LTYPE_FIXED64. ::
 
     bool pb_dec_fixed(pb_istream_t *stream, const pb_field_t *field, void *dest);
 
@@ -430,28 +430,53 @@ Decode a *fixed64*, *sfixed64* or *double* value. ::
 :dest:          Pointer to destination *int64_t*, *uint64_t* or *double*.
 :returns:       True on success, false on IO errors.
 
-Same as `pb_decode_fixed32`_, except this reads 8 bytes.
+Same as `pb_dec_fixed32`_, except this reads 8 bytes.
 
-pb_make_string_substream
+pb_dec_bytes
-------------------------
+------------
-Decode the length for a field with wire type *PB_WT_STRING* and create a substream for reading the data. ::
+Field decoder for PB_LTYPE_BYTES. Reads a length-prefixed block of bytes. ::
 
-    bool pb_make_string_substream(pb_istream_t *stream, pb_istream_t *substream);
+    bool pb_dec_bytes(pb_istream_t *stream, const pb_field_t *field, void *dest);
 
-:stream:        Original input stream to read the length and data from.
+**Note:** This is an internal function that is not useful in decoder callbacks. To read bytes fields in callbacks, use 
-:substream:     New substream that has limited length. Filled in by the function.
+*stream->bytes_left* and `pb_read`_.
-:returns:       True on success, false if reading the length fails.
 
-This function uses `pb_decode_varint`_ to read an integer from the stream. This is interpreted as a number of bytes, and the substream is set up so that its `bytes_left` is initially the same as the length, and its callback function and state the same as the parent stream.
+:stream:        Input stream to read from.
+:field:         Field description structure. Only *field->data_size* matters.
+:dest:          Pointer to a structure similar to pb_bytes_array_t.
+:returns:       True on success, false on IO error or if length exceeds the array size.
 
-pb_close_string_substream
+This function expects a pointer to a structure with a *size_t* field at start, and a variable sized byte array after it. It will deduce the maximum size of the array from *field->data_size*.
--------------------------
-Close the substream created with `pb_make_string_substream`_. ::
 
-    void pb_close_string_substream(pb_istream_t *stream, pb_istream_t *substream);
+pb_dec_string
+-------------
+Field decoder for PB_LTYPE_STRING. Reads a length-prefixed string. ::
 
-:stream:        Original input stream to read the length and data from.
+    bool pb_dec_string(pb_istream_t *stream, const pb_field_t *field, void *dest);
-:substream:     Substream to close
+
+**Note:** This is an internal function that is not useful in decoder callbacks. To read string fields in callbacks, use 
+*stream->bytes_left* and `pb_read`_.
+
+:stream:        Input stream to read from.
+:field:         Field description structure. Only *field->data_size* matters.
+:dest:          Pointer to a character array of size *field->data_size*.
+:returns:       True on success, false on IO error or if length exceeds the array size.
+
+This function null-terminates the string when successful. On error, the contents of the destination array is undefined.
+
+pb_dec_submessage
+-----------------
+Field decoder for PB_LTYPE_SUBMESSAGE. Calls `pb_decode`_ to perform the actual decoding. ::
+
+    bool pb_dec_submessage(pb_istream_t *stream, const pb_field_t *field, void *dest)
+
+**Note:** This is an internal function that is not useful in decoder callbacks. To read submessage fields in callbacks, use 
+`pb_decode`_ directly.
+
+:stream:        Input stream to read from.
+:field:         Field description structure. Only *field->ptr* matters.
+:dest:          Pointer to the destination structure.
+:returns:       True on success, false on IO error or if `pb_decode`_ fails.
+
+The *field->ptr* should be a pointer to *pb_field_t* array describing the submessage.
 
-This function copies back the state from the substream to the parent stream.
-It must be called after done with the substream.

example/Makefile

@@ -1,14 +1,24 @@
 CFLAGS=-ansi -Wall -Werror -I .. -g -O0
-DEPS=../pb_decode.c ../pb_decode.h ../pb_encode.c ../pb_encode.h ../pb.h
+DEPS=../pb_decode.c ../pb_decode.h ../pb_encode.c ../pb_field.c ../pb_encode.h ../pb.h ../pb_field.h
+
+CC_VER := $(shell gcc --version | grep gcc)
+ifneq "$(CC_VER)" ""
+CFLAGS += -m32
+endif
+ifndef PB_PATH
+PBPATHOPT=-I/usr/include -I/usr/local/include
+else
+PBPATHOPT=-I$(PB_PATH)
+endif
 
 all: server client
 
 clean:
-	rm -f server client fileproto.pb.c fileproto.pb.h
+	rm -f server client fileproto.pb.c fileproto.pb.h fileproto.pb
 
 %: %.c $(DEPS) fileproto.pb.h fileproto.pb.c
-	$(CC) $(CFLAGS) -o $@ $< ../pb_decode.c ../pb_encode.c fileproto.pb.c common.c
+	$(CC) $(CFLAGS) -o $@ $< ../pb_decode.c ../pb_encode.c ../pb_field.c fileproto.pb.c common.c
 
 fileproto.pb.c fileproto.pb.h: fileproto.proto ../generator/nanopb_generator.py
-	protoc -I. -I../generator -I/usr/include -ofileproto.pb $<
+	protoc -I. -I../generator $(PBPATHOPT) -ofileproto.pb $<
 	python ../generator/nanopb_generator.py fileproto.pb

example/client.c

@@ -30,7 +30,7 @@ bool printfile_callback(pb_istream_t *stream, const pb_field_t *field, void *arg
     if (!pb_decode(stream, FileInfo_fields, &fileinfo))
         return false;
     
-    printf("%-10lld %s\n", (long long)fileinfo.inode, fileinfo.name);
+    printf("%-10lld %s\n", fileinfo.inode, fileinfo.name);
     
     return true;
 }
@@ -72,7 +72,7 @@ bool listdir(int fd, char *path)
     
     if (!pb_decode(&input, ListFilesResponse_fields, &response))
     {
-        fprintf(stderr, "Decode failed: %s\n", PB_GET_ERROR(&input));
+        fprintf(stderr, "Decoding failed.\n");
         return false;
     }
     

example/common.c

@@ -10,15 +10,24 @@
 
 static bool write_callback(pb_ostream_t *stream, const uint8_t *buf, size_t count)
 {
-    int fd = (intptr_t)stream->state;
+    int fd = (int)stream->state;
     return send(fd, buf, count, 0) == count;
 }
 
 static bool read_callback(pb_istream_t *stream, uint8_t *buf, size_t count)
 {
-    int fd = (intptr_t)stream->state;
+    int fd = (int)stream->state;
     int result;
     
+    if (buf == NULL)
+    {
+        /* Well, this is a really inefficient way to skip input. */
+        /* It is only used when there are unknown fields. */
+        char dummy;
+        while (count-- && recv(fd, &dummy, 1, 0) == 1);
+        return count == 0;
+    }
+    
     result = recv(fd, buf, count, MSG_WAITALL);
     
     if (result == 0)
@@ -29,12 +38,12 @@ static bool read_callback(pb_istream_t *stream, uint8_t *buf, size_t count)
 
 pb_ostream_t pb_ostream_from_socket(int fd)
 {
-    pb_ostream_t stream = {&write_callback, (void*)(intptr_t)fd, SIZE_MAX, 0};
+    pb_ostream_t stream = {&write_callback, (void*)fd, SIZE_MAX, 0};
     return stream;
 }
 
 pb_istream_t pb_istream_from_socket(int fd)
 {
-    pb_istream_t stream = {&read_callback, (void*)(intptr_t)fd, SIZE_MAX};
+    pb_istream_t stream = {&read_callback, (void*)fd, SIZE_MAX};
     return stream;
 }

example/common.h

@@ -6,4 +6,5 @@
 pb_ostream_t pb_ostream_from_socket(int fd);
 pb_istream_t pb_istream_from_socket(int fd);
 
-#endif
+#endif
+

example/server.c

@@ -38,7 +38,7 @@ bool listdir_callback(pb_ostream_t *stream, const pb_field_t *field, const void
         if (!pb_encode_tag_for_field(stream, field))
             return false;
         
-        if (!pb_encode_submessage(stream, FileInfo_fields, &fileinfo))
+        if (!pb_enc_submessage(stream, field, &fileinfo))
             return false;
     }
     
@@ -55,7 +55,7 @@ void handle_connection(int connfd)
     
     if (!pb_decode(&input, ListFilesRequest_fields, &request))
     {
-        printf("Decode failed: %s\n", PB_GET_ERROR(&input));
+        printf("Decoding failed.\n");
         return;
     }
     

example_avr_double/Makefile

@@ -1,22 +0,0 @@
-CFLAGS=-Wall -Werror -I .. -g -O0
-DEPS=double_conversion.c ../pb_decode.c ../pb_decode.h ../pb_encode.c ../pb_encode.h ../pb.h
-
-all: run_tests
-
-clean:
-	rm -f test_conversions encode_double decode_double doubleproto.pb.c doubleproto.pb.h
-
-test_conversions: test_conversions.c double_conversion.c
-	$(CC) $(CFLAGS) -o $@ $^
-
-%: %.c $(DEPS) doubleproto.pb.h doubleproto.pb.c
-	$(CC) $(CFLAGS) -o $@ $< double_conversion.c ../pb_decode.c ../pb_encode.c doubleproto.pb.c
-
-doubleproto.pb.c doubleproto.pb.h: doubleproto.proto ../generator/nanopb_generator.py
-	protoc -I. -I../generator -I/usr/include -odoubleproto.pb $<
-	python ../generator/nanopb_generator.py doubleproto.pb
-
-run_tests: test_conversions encode_double decode_double
-	./test_conversions
-	./encode_double | ./decode_double
-    

example_avr_double/README.txt

@@ -1,22 +0,0 @@
-Some processors/compilers, such as AVR-GCC, do not support the double
-datatype. Instead, they have sizeof(double) == 4. Because protocol
-binary format uses the double encoding directly, this causes trouble
-if the protocol in .proto requires double fields.
-
-This directory contains a solution to this problem. It uses uint64_t
-to store the raw wire values, because its size is correct on all
-platforms. The file double_conversion.c provides functions that
-convert these values to/from floats, without relying on compiler
-support.
-
-To use this method, you need to make two modifications to your code:
-
-1) Change all 'double' fields into 'fixed64' in the .proto.
-
-2) Whenever writing to a 'double' field, use float_to_double().
-
-3) Whenever reading a 'double' field, use double_to_float().
-
-The conversion routines should be as accurate as the float datatype can
-be. Furthermore, they should handle all special values (NaN, inf, denormalized
-numbers) correctly. There are testcases in test_conversions.c.

example_avr_double/decode_double.c

@@ -1,33 +0,0 @@
-/* Decodes a double value into a float variable.
- * Used to read double values with AVR code, which doesn't support double directly.
- */
-
-#include <stdio.h>
-#include <pb_decode.h>
-#include "double_conversion.h"
-#include "doubleproto.pb.h"
-
-int main()
-{
-    uint8_t buffer[32];
-    size_t count = fread(buffer, 1, sizeof(buffer), stdin);
-    pb_istream_t stream = pb_istream_from_buffer(buffer, count);
-    
-    AVRDoubleMessage message;
-    pb_decode(&stream, AVRDoubleMessage_fields, &message);
-    
-    float v1 = double_to_float(message.field1);
-    float v2 = double_to_float(message.field2);
-
-    printf("Values: %f %f\n", v1, v2);
-    
-    if (v1 == 1234.5678f &&
-        v2 == 0.00001f)
-    {
-        return 0;
-    }
-    else
-    {
-        return 1;
-    }
-}

example_avr_double/double_conversion.c

@@ -1,123 +0,0 @@
-/* Conversion routines for platforms that do not support 'double' directly. */
-
-#include "double_conversion.h"
-#include <math.h>
-
-typedef union {
-    float f;
-    uint32_t i;
-} conversion_t;
-
-/* Note: IEE 754 standard specifies float formats as follows:
- * Single precision: sign,  8-bit exp, 23-bit frac.
- * Double precision: sign, 11-bit exp, 52-bit frac.
- */
-
-uint64_t float_to_double(float value)
-{
-    conversion_t in;
-    in.f = value;
-    uint8_t sign;
-    int16_t exponent;
-    uint64_t mantissa;
-    
-    /* Decompose input value */
-    sign = (in.i >> 31) & 1;
-    exponent = ((in.i >> 23) & 0xFF) - 127;
-    mantissa = in.i & 0x7FFFFF;
-    
-    if (exponent == 128)
-    {
-        /* Special value (NaN etc.) */
-        exponent = 1024;
-    }
-    else if (exponent == -127)
-    {
-        if (!mantissa)
-        {
-            /* Zero */
-            exponent = -1023;
-        }
-        else
-        {
-            /* Denormalized */
-            mantissa <<= 1;
-            while (!(mantissa & 0x800000))
-            {
-                mantissa <<= 1;
-                exponent--;
-            }
-            mantissa &= 0x7FFFFF;
-        }
-    }
-    
-    /* Combine fields */
-    mantissa <<= 29;
-    mantissa |= (uint64_t)(exponent + 1023) << 52;
-    mantissa |= (uint64_t)sign << 63;
-    
-    return mantissa;
-}
-
-float double_to_float(uint64_t value)
-{
-    uint8_t sign;
-    int16_t exponent;
-    uint32_t mantissa;
-    conversion_t out;
-
-    /* Decompose input value */
-    sign = (value >> 63) & 1;
-    exponent = ((value >> 52) & 0x7FF) - 1023;
-    mantissa = (value >> 28) & 0xFFFFFF; /* Highest 24 bits */
- 
-    /* Figure if value is in range representable by floats. */
-    if (exponent == 1024)
-    {
-        /* Special value */
-        exponent = 128;
-    }
-    else if (exponent > 127)
-    {
-        /* Too large */        
-        if (sign)
-            return -INFINITY;
-        else
-            return INFINITY;
-    }
-    else if (exponent < -150)
-    {
-        /* Too small */
-        if (sign)
-            return -0.0f;
-        else
-            return 0.0f;
-    }
-    else if (exponent < -126)
-    {
-        /* Denormalized */
-        mantissa |= 0x1000000;
-        mantissa >>= (-126 - exponent);
-        exponent = -127;
-    }
- 
-    /* Round off mantissa */
-    mantissa = (mantissa + 1) >> 1;
-    
-    /* Check if mantissa went over 2.0 */
-    if (mantissa & 0x800000)
-    {
-        exponent += 1;
-        mantissa &= 0x7FFFFF;
-        mantissa >>= 1;
-    }
-    
-    /* Combine fields */
-    out.i = mantissa;
-    out.i |= (uint32_t)(exponent + 127) << 23;
-    out.i |= (uint32_t)sign << 31;
-    
-    return out.f;
-}
-
-

example_avr_double/double_conversion.h

@@ -1,26 +0,0 @@
-/* AVR-GCC does not have real double datatype. Instead its double
- * is equal to float, i.e. 32 bit value. If you need to communicate
- * with other systems that use double in their .proto files, you
- * need to do some conversion.
- *
- * These functions use bitwise operations to mangle floats into doubles
- * and then store them in uint64_t datatype.
- */
-
-#ifndef DOUBLE_CONVERSION
-#define DOUBLE_CONVERSION
-
-#include <stdint.h>
-
-/* Convert native 4-byte float into a 8-byte double. */
-extern uint64_t float_to_double(float value);
-
-/* Convert 8-byte double into native 4-byte float.
- * Values are rounded to nearest, 0.5 away from zero.
- * Overflowing values are converted to Inf or -Inf.
- */
-extern float double_to_float(uint64_t value);
-
-
-#endif
-

example_avr_double/doubleproto.proto

@@ -1,13 +0,0 @@
-// A message containing doubles, as used by other applications.
-message DoubleMessage {
-    required double field1 = 1;
-    required double field2 = 2;
-}
-
-// A message containing doubles, but redefined using uint64_t.
-// For use in AVR code.
-message AVRDoubleMessage {
-    required fixed64 field1 = 1;
-    required fixed64 field2 = 2;
-}
-

example_avr_double/encode_double.c

@@ -1,25 +0,0 @@
-/* Encodes a float value into a double on the wire.
- * Used to emit doubles from AVR code, which doesn't support double directly.
- */
-
-#include <stdio.h>
-#include <pb_encode.h>
-#include "double_conversion.h"
-#include "doubleproto.pb.h"
-
-int main()
-{
-    AVRDoubleMessage message = {
-        float_to_double(1234.5678f),
-        float_to_double(0.00001f)
-    };
-    
-    uint8_t buffer[32];
-    pb_ostream_t stream = pb_ostream_from_buffer(buffer, sizeof(buffer));
-    
-    pb_encode(&stream, AVRDoubleMessage_fields, &message);
-    fwrite(buffer, 1, stream.bytes_written, stdout);
-
-    return 0;
-}
-

example_avr_double/test_conversions.c

@@ -1,56 +0,0 @@
-#include "double_conversion.h"
-#include <math.h>
-#include <stdio.h>
-
-static const double testvalues[] = {
-           0.0,        -0.0,         0.1,         -0.1,
-          M_PI,       -M_PI,  123456.789,  -123456.789,
-      INFINITY,   -INFINITY,         NAN, INFINITY - INFINITY,
-          1e38,       -1e38,        1e39,        -1e39,
-         1e-38,      -1e-38,       1e-39,       -1e-39,
-   3.14159e-37,-3.14159e-37, 3.14159e-43, -3.14159e-43,
-         1e-60,      -1e-60,       1e-45,       -1e-45,
-    0.99999999999999, -0.99999999999999, 127.999999999999, -127.999999999999
-};
-
-#define TESTVALUES_COUNT (sizeof(testvalues)/sizeof(testvalues[0]))
-
-int main()
-{
-    int status = 0;
-    int i;
-    for (i = 0; i < TESTVALUES_COUNT; i++)
-    {
-        double orig = testvalues[i];
-        float expected_float = (float)orig;
-        double expected_double = (double)expected_float;
-        
-        float got_float = double_to_float(*(uint64_t*)&orig);
-        uint64_t got_double = float_to_double(got_float);
-        
-        uint32_t e1 = *(uint32_t*)&expected_float;
-        uint32_t g1 = *(uint32_t*)&got_float;
-        uint64_t e2 = *(uint64_t*)&expected_double;
-        uint64_t g2 = got_double;
-        
-        if (g1 != e1)
-        {
-            printf("%3d double_to_float fail: %08x != %08x\n", i, g1, e1);
-            status = 1;
-        }
-        
-        if (g2 != e2)
-        {
-            printf("%3d float_to_double fail: %016llx != %016llx\n", i,
-                (unsigned long long)g2,
-                (unsigned long long)e2);
-            status = 1;
-        }
-    }
-
-    return status;
-}
-
-    
-    
-

example_unions/Makefile

@@ -1,17 +0,0 @@
-CFLAGS=-ansi -Wall -Werror -I .. -g -O0
-DEPS=../pb_decode.c ../pb_decode.h ../pb_encode.c ../pb_encode.h ../pb.h
-
-all: encode decode
-	./encode 1 | ./decode
-	./encode 2 | ./decode
-	./encode 3 | ./decode
-
-clean:
-	rm -f encode unionproto.pb.h unionproto.pb.c
-
-%: %.c $(DEPS) unionproto.pb.h unionproto.pb.c
-	$(CC) $(CFLAGS) -o $@ $< ../pb_decode.c ../pb_encode.c unionproto.pb.c
-
-unionproto.pb.h unionproto.pb.c: unionproto.proto ../generator/nanopb_generator.py
-	protoc -I. -I../generator -I/usr/include -ounionproto.pb $<
-	python ../generator/nanopb_generator.py unionproto.pb

example_unions/decode.c

@@ -1,96 +0,0 @@
-/* This program reads a message from stdin, detects its type and decodes it.
- */
- 
-#include <stdio.h>
-#include <string.h>
-#include <stdlib.h>
-
-#include <pb_decode.h>
-#include "unionproto.pb.h"
-
-/* This function reads manually the first tag from the stream and finds the
- * corresponding message type. It doesn't yet decode the actual message.
- *
- * Returns a pointer to the MsgType_fields array, as an identifier for the
- * message type. Returns null if the tag is of unknown type or an error occurs.
- */
-const pb_field_t* decode_unionmessage_type(pb_istream_t *stream)
-{
-    pb_wire_type_t wire_type;
-    uint32_t tag;
-    bool eof;
-
-    while (pb_decode_tag(stream, &wire_type, &tag, &eof))
-    {
-        if (wire_type == PB_WT_STRING)
-        {
-            const pb_field_t *field;
-            for (field = UnionMessage_fields; field->tag != 0; field++)
-            {
-                if (field->tag == tag && (field->type & PB_LTYPE_SUBMESSAGE))
-                {
-                    /* Found our field. */
-                    return field->ptr;
-                }
-            }
-        }
-        
-        /* Wasn't our field.. */
-        pb_skip_field(stream, wire_type);
-    }
-    
-    return NULL;
-}
-
-bool decode_unionmessage_contents(pb_istream_t *stream, const pb_field_t fields[], void *dest_struct)
-{
-    pb_istream_t substream;
-    bool status;
-    if (!pb_make_string_substream(stream, &substream))
-        return false;
-    
-    status = pb_decode(&substream, fields, dest_struct);
-    pb_close_string_substream(stream, &substream);
-    return status;
-}
-
-int main()
-{
-    /* Read the data into buffer */
-    uint8_t buffer[512];
-    size_t count = fread(buffer, 1, sizeof(buffer), stdin);
-    pb_istream_t stream = pb_istream_from_buffer(buffer, count);
-    
-    const pb_field_t *type = decode_unionmessage_type(&stream);
-    bool status = false;
-    
-    if (type == MsgType1_fields)
-    {
-        MsgType1 msg = {};
-        status = decode_unionmessage_contents(&stream, MsgType1_fields, &msg);
-        printf("Got MsgType1: %d\n", msg.value);
-    }
-    else if (type == MsgType2_fields)
-    {
-        MsgType2 msg = {};
-        status = decode_unionmessage_contents(&stream, MsgType2_fields, &msg);
-        printf("Got MsgType2: %s\n", msg.value ? "true" : "false");
-    }
-    else if (type == MsgType3_fields)
-    {
-        MsgType3 msg = {};
-        status = decode_unionmessage_contents(&stream, MsgType3_fields, &msg);
-        printf("Got MsgType3: %d %d\n", msg.value1, msg.value2);    
-    }
-    
-    if (!status)
-    {
-        printf("Decode failed: %s\n", PB_GET_ERROR(&stream));
-        return 1;
-    }
-    
-    return 0;
-}
-
-
-

example_unions/encode.c

@@ -1,85 +0,0 @@
-/* This program takes a command line argument and encodes a message in
- * one of MsgType1, MsgType2 or MsgType3.
- */
- 
-#include <stdio.h>
-#include <string.h>
-#include <stdlib.h>
-
-#include <pb_encode.h>
-#include "unionproto.pb.h"
-
-/* This function is the core of the union encoding process. It handles
- * the top-level pb_field_t array manually, in order to encode a correct
- * field tag before the message. The pointer to MsgType_fields array is
- * used as an unique identifier for the message type.
- */
-bool encode_unionmessage(pb_ostream_t *stream, const pb_field_t messagetype[], const void *message)
-{
-    const pb_field_t *field;
-    for (field = UnionMessage_fields; field->tag != 0; field++)
-    {
-        if (field->ptr == messagetype)
-        {
-            /* This is our field, encode the message using it. */
-            if (!pb_encode_tag_for_field(stream, field))
-                return false;
-            
-            return pb_encode_submessage(stream, messagetype, message);
-        }
-    }
-    
-    /* Didn't find the field for messagetype */
-    return false;
-}
-
-int main(int argc, char **argv)
-{
-    if (argc != 2)
-    {
-        fprintf(stderr, "Usage: %s (1|2|3)\n", argv[0]);
-        return 1;
-    }
-    
-    uint8_t buffer[512];
-    pb_ostream_t stream = pb_ostream_from_buffer(buffer, sizeof(buffer));
-    
-    bool status = false;
-    int msgtype = atoi(argv[1]);
-    if (msgtype == 1)
-    {
-        /* Send message of type 1 */
-        MsgType1 msg = {42};
-        status = encode_unionmessage(&stream, MsgType1_fields, &msg);
-    }
-    else if (msgtype == 2)
-    {
-        /* Send message of type 2 */
-        MsgType2 msg = {true};
-        status = encode_unionmessage(&stream, MsgType2_fields, &msg);
-    }
-    else if (msgtype == 3)
-    {
-        /* Send message of type 3 */
-        MsgType3 msg = {3, 1415};
-        status = encode_unionmessage(&stream, MsgType3_fields, &msg);
-    }
-    else
-    {
-        fprintf(stderr, "Unknown message type: %d\n", msgtype);
-        return 2;
-    }
-    
-    if (!status)
-    {
-        fprintf(stderr, "Encoding failed!\n");
-        return 3;
-    }
-    else
-    {
-        fwrite(buffer, 1, stream.bytes_written, stdout);
-        return 0; /* Success */
-    }
-}
-
-

example_unions/unionproto.proto

@@ -1,30 +0,0 @@
-// This is an example of how to handle 'union' style messages
-// with nanopb, without allocating memory for all the message types.
-//
-// There is no official type in Protocol Buffers for describing unions,
-// but they are commonly implemented by filling out exactly one of
-// several optional fields.
-
-message MsgType1
-{
-    required int32 value = 1;
-}
-
-message MsgType2
-{
-    required bool value = 1;
-}
-
-message MsgType3
-{
-    required int32 value1 = 1;
-    required int32 value2 = 2;
-}
-
-message UnionMessage
-{
-    optional MsgType1 msg1 = 1;
-    optional MsgType2 msg2 = 2;
-    optional MsgType3 msg3 = 3;
-}
-

generator/Makefile

@@ -1,2 +1,8 @@
+ifndef PB_PATH
+PBPATHOPT=-I/usr/include -I/usr/local/include
+else
+PBPATHOPT=-I$(PB_PATH)
+endif
+
 nanopb_pb2.py: nanopb.proto
-	protoc --python_out=. -I /usr/include -I . nanopb.proto
+	protoc --python_out=. $(PBPATHOPT) -I . nanopb.proto

generator/nanopb.proto

@@ -7,54 +7,20 @@
 
 import "google/protobuf/descriptor.proto";
 
-option java_package = "fi.kapsi.koti.jpa.nanopb";
-
-enum FieldType {
-    FT_DEFAULT = 0; // Automatically decide field type, generate static field if possible.
-    FT_CALLBACK = 1; // Always generate a callback field.
-    FT_STATIC = 2; // Generate a static field or raise an exception if not possible.
-    FT_IGNORE = 3; // Ignore the field completely.
-}
-
 message NanoPBOptions {
-  // Allocated size for 'bytes' and 'string' fields.
   optional int32 max_size = 1;
-  
-  // Allocated number of entries in arrays ('repeated' fields)
   optional int32 max_count = 2;
-  
-  // Force type of field (callback or static allocation)
-  optional FieldType type = 3 [default = FT_DEFAULT];
-  
-  // Use long names for enums, i.e. EnumName_EnumValue.
-  optional bool long_names = 4 [default = true];
-  
-  // Add 'packed' attribute to generated structs.
-  optional bool packed_struct = 5 [default = false];
 }
 
 // Protocol Buffers extension number registry
-// --------------------------------
+// --------------------------------                                                                                                            
-// Project:  Nanopb
+// Project:  Nanopb                                                                                                                            
-// Contact:  Petteri Aimonen <jpa@kapsi.fi>
+// Contact:  Petteri Aimonen <jpa@kapsi.fi>                                                                                                    
-// Web site: http://kapsi.fi/~jpa/nanopb
+// Web site: http://kapsi.fi/~jpa/nanopb                                                                                                       
-// Extensions: 1010 (all types)
+// Extensions: 1010 (all types)                                                                                                                
-// --------------------------------
+// --------------------------------   
-
-extend google.protobuf.FileOptions {
-    optional NanoPBOptions nanopb_fileopt = 1010;
-}
-
-extend google.protobuf.MessageOptions {
-    optional NanoPBOptions nanopb_msgopt = 1010;
-}
-
-extend google.protobuf.EnumOptions {
-    optional NanoPBOptions nanopb_enumopt = 1010;
-}
 
 extend google.protobuf.FieldOptions {
     optional NanoPBOptions nanopb = 1010;
 }
 
-

generator/nanopb_generator.py

@@ -1,56 +1,25 @@
 '''Generate header file for nanopb from a ProtoBuf FileDescriptorSet.'''
-nanopb_version = "nanopb-0.1.9.1"
 
-try:
+import google.protobuf.descriptor_pb2 as descriptor
-    import google.protobuf.descriptor_pb2 as descriptor
+import nanopb_pb2
-except:
-    print
-    print "*************************************************************"
-    print "*** Could not import the Google protobuf Python libraries ***"
-    print "*** Try installing package 'python-protobuf' or similar.  ***"
-    print "*************************************************************"
-    print
-    raise
-
-try:
-    import nanopb_pb2
-except:
-    print
-    print "***************************************************************"
-    print "*** Could not import the precompiled nanopb_pb2.py.         ***"
-    print "*** Run 'make' in the 'generator' folder to update the file.***"
-    print "***************************************************************"
-    print
-    raise
-
-
-
-
-
-
-# ---------------------------------------------------------------------------
-#                     Generation of single fields
-# ---------------------------------------------------------------------------
-
-import time
 import os.path
 
-# Values are tuple (c type, pb ltype)
+# Values are tuple (c type, pb ltype, memory aligned flag, common field info type)
 FieldD = descriptor.FieldDescriptorProto
 datatypes = {
-    FieldD.TYPE_BOOL: ('bool', 'PB_LTYPE_VARINT'),
+    FieldD.TYPE_BOOL: ('bool', 'PB_LTYPE_VARINT', False, 'BOOL'),
-    FieldD.TYPE_DOUBLE: ('double', 'PB_LTYPE_FIXED64'),
+    FieldD.TYPE_DOUBLE: ('double', 'PB_LTYPE_FIXED64', True, 'FIXED64'),
-    FieldD.TYPE_FIXED32: ('uint32_t', 'PB_LTYPE_FIXED32'),
+    FieldD.TYPE_FIXED32: ('uint32_t', 'PB_LTYPE_FIXED32', True, 'FIXED32'),
-    FieldD.TYPE_FIXED64: ('uint64_t', 'PB_LTYPE_FIXED64'),
+    FieldD.TYPE_FIXED64: ('uint64_t', 'PB_LTYPE_FIXED64', True, 'FIXED64'),
-    FieldD.TYPE_FLOAT: ('float', 'PB_LTYPE_FIXED32'),
+    FieldD.TYPE_FLOAT: ('float', 'PB_LTYPE_FIXED32', True, 'FIXED32'),
-    FieldD.TYPE_INT32: ('int32_t', 'PB_LTYPE_VARINT'),
+    FieldD.TYPE_INT32: ('int32_t', 'PB_LTYPE_VARINT', True, 'INT32'),
-    FieldD.TYPE_INT64: ('int64_t', 'PB_LTYPE_VARINT'),
+    FieldD.TYPE_INT64: ('int64_t', 'PB_LTYPE_VARINT', True, 'INT64'),
-    FieldD.TYPE_SFIXED32: ('int32_t', 'PB_LTYPE_FIXED32'),
+    FieldD.TYPE_SFIXED32: ('int32_t', 'PB_LTYPE_FIXED32', True, 'FIXED32'),
-    FieldD.TYPE_SFIXED64: ('int64_t', 'PB_LTYPE_FIXED64'),
+    FieldD.TYPE_SFIXED64: ('int64_t', 'PB_LTYPE_FIXED64', True, 'FIXED64'),
-    FieldD.TYPE_SINT32: ('int32_t', 'PB_LTYPE_SVARINT'),
+    FieldD.TYPE_SINT32: ('int32_t', 'PB_LTYPE_SVARINT', True, 'SINT32'),
-    FieldD.TYPE_SINT64: ('int64_t', 'PB_LTYPE_SVARINT'),
+    FieldD.TYPE_SINT64: ('int64_t', 'PB_LTYPE_SVARINT', True, "SINT64"),
-    FieldD.TYPE_UINT32: ('uint32_t', 'PB_LTYPE_VARINT'),
+    FieldD.TYPE_UINT32: ('uint32_t', 'PB_LTYPE_VARINT', True, 'INT32'),
-    FieldD.TYPE_UINT64: ('uint64_t', 'PB_LTYPE_VARINT')
+    FieldD.TYPE_UINT64: ('uint64_t', 'PB_LTYPE_VARINT', True, 'INT64')
 }
 
 class Names:
@@ -73,9 +42,6 @@ class Names:
         else:
             raise ValueError("Name parts should be of type str")
     
-    def __eq__(self, other):
-        return isinstance(other, Names) and self.parts == other.parts
-    
 def names_from_type_name(type_name):
     '''Parse Names() from FieldDescriptorProto type_name'''
     if type_name[0] != '.':
@@ -83,27 +49,19 @@ def names_from_type_name(type_name):
     return Names(type_name[1:].split('.'))
 
 class Enum:
-    def __init__(self, names, desc, enum_options):
+    def __init__(self, names, desc):
         '''desc is EnumDescriptorProto'''
-        
-        self.options = enum_options
         self.names = names + desc.name
-        
+        self.values = [(self.names + x.name, x.number) for x in desc.value]
-        if enum_options.long_names:
-            self.values = [(self.names + x.name, x.number) for x in desc.value]            
-        else:
-            self.values = [(names + x.name, x.number) for x in desc.value] 
-        
-        self.value_longnames = [self.names + x.name for x in desc.value]
     
     def __str__(self):
-        result = 'typedef enum _%s {\n' % self.names
+        result = 'typedef enum {\n'
         result += ',\n'.join(["    %s = %d" % x for x in self.values])
         result += '\n} %s;' % self.names
         return result
 
 class Field:
-    def __init__(self, struct_name, desc, field_options):
+    def __init__(self, struct_name, desc):
         '''desc is FieldDescriptorProto'''
         self.tag = desc.number
         self.struct_name = struct_name
@@ -112,28 +70,32 @@ class Field:
         self.max_size = None
         self.max_count = None
         self.array_decl = ""
+        self.is_last_field = False
+        self.aligned = False
+        self.info_index = None
         
-        # Parse field options
+        # Parse nanopb-specific field options
-        if field_options.HasField("max_size"):
+        if desc.options.HasExtension(nanopb_pb2.nanopb):
-            self.max_size = field_options.max_size
+            ext = desc.options.Extensions[nanopb_pb2.nanopb]
-        
+            if ext.HasField("max_size"):
-        if field_options.HasField("max_count"):
+                self.max_size = ext.max_size
-            self.max_count = field_options.max_count
+            if ext.HasField("max_count"):
+                self.max_count = ext.max_count
         
         if desc.HasField('default_value'):
             self.default = desc.default_value
-           
+        
         # Decide HTYPE
         # HTYPE is the high-order nibble of nanopb field description,
         # defining whether value is required/optional/repeated.
-        can_be_static = True
+        is_callback = False
         if desc.label == FieldD.LABEL_REQUIRED:
             self.htype = 'PB_HTYPE_REQUIRED'
         elif desc.label == FieldD.LABEL_OPTIONAL:
             self.htype = 'PB_HTYPE_OPTIONAL'
         elif desc.label == FieldD.LABEL_REPEATED:
             if self.max_count is None:
-                can_be_static = False
+                is_callback = True
             else:
                 self.htype = 'PB_HTYPE_ARRAY'
                 self.array_decl = '[%d]' % self.max_count
@@ -145,23 +107,25 @@ class Field:
         # defining how to decode an individual value.
         # CTYPE is the name of the c type to use in the struct.
         if datatypes.has_key(desc.type):
-            self.ctype, self.ltype = datatypes[desc.type]
+            self.ctype, self.ltype, self.aligned, self.common_info_name = datatypes[desc.type]
         elif desc.type == FieldD.TYPE_ENUM:
             self.ltype = 'PB_LTYPE_VARINT'
             self.ctype = names_from_type_name(desc.type_name)
+            self.aligned = True
+            self.common_info_name = 'INT32'
             if self.default is not None:
                 self.default = self.ctype + self.default
         elif desc.type == FieldD.TYPE_STRING:
             self.ltype = 'PB_LTYPE_STRING'
             if self.max_size is None:
-                can_be_static = False
+                is_callback = True
             else:
                 self.ctype = 'char'
                 self.array_decl += '[%d]' % self.max_size
         elif desc.type == FieldD.TYPE_BYTES:
             self.ltype = 'PB_LTYPE_BYTES'
             if self.max_size is None:
-                can_be_static = False
+                is_callback = True
             else:
                 self.ctype = self.struct_name + self.name + 't'
         elif desc.type == FieldD.TYPE_MESSAGE:
@@ -170,16 +134,7 @@ class Field:
         else:
             raise NotImplementedError(desc.type)
         
-        if field_options.type == nanopb_pb2.FT_DEFAULT:
+        if is_callback:
-            if can_be_static:
-                field_options.type = nanopb_pb2.FT_STATIC
-            else:
-                field_options.type = nanopb_pb2.FT_CALLBACK
-        
-        if field_options.type == nanopb_pb2.FT_STATIC and not can_be_static:
-            raise Exception("Field %s is defined as static, but max_size or max_count is not given." % self.name)
-        
-        if field_options.type == nanopb_pb2.FT_CALLBACK:
             self.htype = 'PB_HTYPE_CALLBACK'
             self.ctype = 'pb_callback_t'
             self.array_decl = ''
@@ -241,16 +196,34 @@ class Field:
             return 'extern const %s %s_default%s;' % (ctype, self.struct_name + self.name, array_decl)
         else:
             return 'const %s %s_default%s = %s;' % (ctype, self.struct_name + self.name, array_decl, default)
+
+    def pb_field_key_t(self):
+        '''Return the pb_field_t field key initializer to use in the constant array.
+        '''
+        result = '    {%d' % self.tag
+        if self.is_last_field:
+            result += ' | PB_LAST_FIELD'
+            
+        if self.info_index is not None:
+            result += ', %d}' % self.info_index
+        else:
+            if 'REQUIRED' in self.htype:
+                prefix = 'REQUIRED'
+            elif 'OPTIONAL' in self.htype:
+                prefix = 'OPTIONAL'
+            result += ', %s_%s_INFO}' % (prefix, self.common_info_name)
+        return result
     
     def pb_field_t(self, prev_field_name):
-        '''Return the pb_field_t initializer to use in the constant array.
+        '''Return the pb_field_t field info initializer to use in the constant array.
         prev_field_name is the name of the previous field or None.
         '''
-        result = '    {%d, ' % self.tag
+        ''' result = '    {0, '''
-        result += '(pb_type_t) ((int) ' + self.htype
+        result = '    {%d, ' % self.tag        
+        result += self.htype
         if self.ltype is not None:
-            result += ' | (int) ' + self.ltype
+            result += ' | ' + self.ltype          
-        result += '),\n'
+        result += ',\n'
         
         if prev_field_name is None:
             result += '    offsetof(%s, %s),' % (self.struct_name, self.name)
@@ -282,54 +255,33 @@ class Field:
         
         return result
     
-    def largest_field_value(self):
+    def should_generate_field_info(self, prev):
-        '''Determine if this field needs 16bit or 32bit pb_field_t structure to compile properly.
+        return  g_no_optimization or not ((prev is None or prev.aligned) and (self.ltype in ['PB_LTYPE_VARINT', 'PB_LTYPE_SVARINT', 'PB_LTYPE_FIXED32', 'PB_LTYPE_FIXED64']) and (self.htype in ['PB_HTYPE_REQUIRED', 'PB_HTYPE_OPTIONAL']))
-        Returns numeric value or a C-expression for assert.'''
+    
-        if self.ltype == 'PB_LTYPE_SUBMESSAGE':
-            if self.htype == 'PB_HTYPE_ARRAY':
-                return 'pb_membersize(%s, %s[0])' % (self.struct_name, self.name)
-            else:
-                return 'pb_membersize(%s, %s)' % (self.struct_name, self.name)
-
-        return max(self.tag, self.max_size, self.max_count)        
-
-
-
-
-
-
-# ---------------------------------------------------------------------------
-#                   Generation of messages (structures)
-# ---------------------------------------------------------------------------
-
-
 class Message:
-    def __init__(self, names, desc, message_options):
+    def __init__(self, names, desc):
         self.name = names
-        self.fields = []
+        self.fields = [Field(self.name, f) for f in desc.field]
-        
-        for f in desc.field:
-            field_options = get_nanopb_suboptions(f, message_options)
-            if field_options.type != nanopb_pb2.FT_IGNORE:
-                self.fields.append(Field(self.name, f, field_options))
-        
-        self.packed = message_options.packed_struct
         self.ordered_fields = self.fields[:]
         self.ordered_fields.sort()
-
+        if self.ordered_fields:
+            self.ordered_fields[-1].is_last_field = True
+        self.num_info = 0
+        prev = None
+        for f in self.ordered_fields:
+            if f.should_generate_field_info(prev):
+                f.info_index = self.num_info
+                self.num_info += 1
+            prev = f
+        
     def get_dependencies(self):
         '''Get list of type names that this structure refers to.'''
         return [str(field.ctype) for field in self.fields]
     
     def __str__(self):
-        result = 'typedef struct _%s {\n' % self.name
+        result = 'typedef struct {\n'
         result += '\n'.join([str(f) for f in self.ordered_fields])
-        result += '\n}'
+        result += '\n} %s;' % self.name
-        
-        if self.packed:
-            result += ' pb_packed'
-        
-        result += ' %s;' % self.name
         return result
     
     def types(self):
@@ -349,31 +301,50 @@ class Message:
         return result
 
     def fields_declaration(self):
-        result = 'extern const pb_field_t %s_fields[%d];' % (self.name, len(self.fields) + 1)
+        result = 'extern const pb_field_info_t %s_fields[1];' % self.name
+         
         return result
 
     def fields_definition(self):
-        result = 'const pb_field_t %s_fields[%d] = {\n' % (self.name, len(self.fields) + 1)
+        num_fields = len(self.fields)
         
-        prev = None
+        result = 'static const pb_field_key_t %s_field_keys[%d] = {\n' % (self.name, num_fields)
+
         for field in self.ordered_fields:
-            result += field.pb_field_t(prev)
+            result += field.pb_field_key_t()
-            result += ',\n\n'
+            if not field.is_last_field:
-            prev = field.name
+                result += ',\n'
+            prev = field                
+        result += '\n};\n\n'
+    
+        if self.num_info > 0:
+            result += 'static const pb_field_t %s_field_info[%d] = {\n' % (self.name, self.num_info)    
+            prev = None
+            for field in self.ordered_fields:
+                if field.info_index is not None:
+                    result += field.pb_field_t(prev)
+                    if field.info_index < self.num_info - 1:
+                        result += ',\n\n'
+                prev = field.name
+            result += '\n};\n\n'
+        
+        decl = 'const pb_field_info_t %s_fields[1] = { {' % self.name
+        
+        if num_fields == 0:
+            result = decl
+            result += '\n    0,'
+            result += '\n    0' 
+        else:
+            result += decl
+            result += '\n    &%s_field_keys[0],' % self.name
+            if self.num_info > 0:
+                result += '\n    &%s_field_info[0]' % self.name
+            else:
+                result += '\n    0' 
+        result += '\n}};\n' 
         
-        result += '    PB_LAST_FIELD\n};'
         return result
 
-
-
-
-
-
-# ---------------------------------------------------------------------------
-#                    Processing of entire .proto files
-# ---------------------------------------------------------------------------
-
-
 def iterate_messages(desc, names = Names()):
     '''Recursively find all messages. For each, yield name, DescriptorProto.'''
     if hasattr(desc, 'message_type'):
@@ -388,7 +359,7 @@ def iterate_messages(desc, names = Names()):
         for x in iterate_messages(submsg, sub_names):
             yield x
 
-def parse_file(fdesc, file_options):
+def parse_file(fdesc):
     '''Takes a FileDescriptorProto and returns tuple (enum, messages).'''
     
     enums = []
@@ -400,24 +371,12 @@ def parse_file(fdesc, file_options):
         base_name = Names()
     
     for enum in fdesc.enum_type:
-        enum_options = get_nanopb_suboptions(enum, file_options)
+        enums.append(Enum(base_name, enum))
-        enums.append(Enum(base_name, enum, enum_options))
     
     for names, message in iterate_messages(fdesc, base_name):
-        message_options = get_nanopb_suboptions(message, file_options)
+        messages.append(Message(names,message))
-        messages.append(Message(names, message, message_options))
         for enum in message.enum_type:
-            enum_options = get_nanopb_suboptions(enum, message_options)
+            enums.append(Enum(names, enum))
-            enums.append(Enum(names, enum, enum_options))
-    
-    # Fix field default values where enum short names are used.
-    for enum in enums:
-        if not enum.options.long_names:
-            for message in messages:
-                for field in message.fields:
-                    if field.default in enum.value_longnames:
-                        idx = enum.value_longnames.index(field.default)
-                        field.default = enum.values[idx][0]
     
     return enums, messages
 
@@ -428,7 +387,7 @@ def toposort2(data):
     '''
     for k, v in data.items():
         v.discard(k) # Ignore self dependencies
-    extra_items_in_deps = reduce(set.union, data.values(), set()) - set(data.keys())
+    extra_items_in_deps = reduce(set.union, data.values()) - set(data.keys())
     data.update(dict([(item, set()) for item in extra_items_in_deps]))
     while True:
         ordered = set(item for item,dep in data.items() if not dep)
@@ -452,25 +411,14 @@ def sort_dependencies(messages):
         if msgname in message_by_name:
             yield message_by_name[msgname]
 
-def make_identifier(headername):
-    '''Make #ifndef identifier that contains uppercase A-Z and digits 0-9'''
-    result = ""
-    for c in headername.upper():
-        if c.isalnum():
-            result += c
-        else:
-            result += '_'
-    return result
-
 def generate_header(dependencies, headername, enums, messages):
     '''Generate content for a header file.
     Generates strings, which should be concatenated and stored to file.
     '''
     
     yield '/* Automatically generated nanopb header */\n'
-    yield '/* Generated by %s at %s. */\n\n' % (nanopb_version, time.asctime())
     
-    symbol = make_identifier(headername)
+    symbol = headername.replace('.', '_').upper()
     yield '#ifndef _PB_%s_\n' % symbol
     yield '#define _PB_%s_\n' % symbol
     yield '#include <pb.h>\n\n'
@@ -478,10 +426,7 @@ def generate_header(dependencies, headername, enums, messages):
     for dependency in dependencies:
         noext = os.path.splitext(dependency)[0]
         yield '#include "%s.pb.h"\n' % noext
-    
+    yield '\n'
-    yield '#ifdef __cplusplus\n'
-    yield 'extern "C" {\n'
-    yield '#endif\n\n'
     
     yield '/* Enum definitions */\n'
     for enum in enums:
@@ -501,81 +446,12 @@ def generate_header(dependencies, headername, enums, messages):
     for msg in messages:
         yield msg.fields_declaration() + '\n'
     
-    if messages:
-        count_required_fields = lambda m: len([f for f in msg.fields if f.htype == 'PB_HTYPE_REQUIRED'])
-        largest_msg = max(messages, key = count_required_fields)
-        largest_count = count_required_fields(largest_msg)
-        if largest_count > 64:
-            yield '\n/* Check that missing required fields will be properly detected */\n'
-            yield '#if PB_MAX_REQUIRED_FIELDS < %d\n' % largest_count
-            yield '#error Properly detecting missing required fields in %s requires \\\n' % largest_msg.name
-            yield '       setting PB_MAX_REQUIRED_FIELDS to %d or more.\n' % largest_count
-            yield '#endif\n'
-    
-    # Add checks for numeric limits
-    worst = 0
-    worst_field = ''
-    checks = []
-    checks_msgnames = []
-    for msg in messages:
-        checks_msgnames.append(msg.name)
-        for field in msg.fields:
-            status = field.largest_field_value()
-            if isinstance(status, (str, unicode)):
-                checks.append(status)
-            elif status > worst:
-                worst = status
-                worst_field = str(field.struct_name) + '.' + str(field.name)
-
-    if worst > 255 or checks:
-        yield '\n/* Check that field information fits in pb_field_t */\n'
-        
-        if worst < 65536:
-            yield '#if !defined(PB_FIELD_16BIT) && !defined(PB_FIELD_32BIT)\n'
-            if worst > 255:
-                yield '#error Field descriptor for %s is too large. Define PB_FIELD_16BIT to fix this.\n' % worst_field
-            else:
-                assertion = ' && '.join(str(c) + ' < 256' for c in checks)
-                msgs = '_'.join(str(n) for n in checks_msgnames)
-                yield 'STATIC_ASSERT((%s), YOU_MUST_DEFINE_PB_FIELD_16BIT_FOR_MESSAGES_%s)\n'%(assertion,msgs)
-            yield '#endif\n\n'
-        
-        if worst > 65535 or checks:
-            yield '#if !defined(PB_FIELD_32BIT)\n'
-            if worst > 65535:
-                yield '#error Field descriptor for %s is too large. Define PB_FIELD_32BIT to fix this.\n' % worst_field
-            else:
-                assertion = ' && '.join(str(c) + ' < 65536' for c in checks)
-                msgs = '_'.join(str(n) for n in checks_msgnames)
-                yield 'STATIC_ASSERT((%s), YOU_MUST_DEFINE_PB_FIELD_32BIT_FOR_MESSAGES_%s)\n'%(assertion,msgs)
-            yield '#endif\n'
-    
-    # Add check for sizeof(double)
-    has_double = False
-    for msg in messages:
-        for field in msg.fields:
-            if field.ctype == 'double':
-                has_double = True
-    
-    if has_double:
-        yield '\n'
-        yield '/* On some platforms (such as AVR), double is really float.\n'
-        yield ' * These are not directly supported by nanopb, but see example_avr_double.\n'
-        yield ' */\n'
-        yield 'STATIC_ASSERT(sizeof(double) == 8, DOUBLE_MUST_BE_8_BYTES)\n'
-    
-    yield '\n#ifdef __cplusplus\n'
-    yield '} /* extern "C" */\n'
-    yield '#endif\n'
-    
-    # End of header
     yield '\n#endif\n'
 
 def generate_source(headername, enums, messages):
     '''Generate content for a source file.'''
     
     yield '/* Automatically generated nanopb constant definitions */\n'
-    yield '/* Generated by %s at %s. */\n\n' % (nanopb_version, time.asctime())
     yield '#include "%s"\n\n' % headername
     
     for msg in messages:
@@ -586,105 +462,45 @@ def generate_source(headername, enums, messages):
     for msg in messages:
         yield msg.fields_definition() + '\n\n'
 
-
-
-# ---------------------------------------------------------------------------
-#                         Command line interface
-# ---------------------------------------------------------------------------
-
-import sys
-import os.path    
-from optparse import OptionParser
-import google.protobuf.text_format as text_format
-
-optparser = OptionParser(
-    usage = "Usage: nanopb_generator.py [options] file.pb ...",
-    epilog = "Compile file.pb from file.proto by: 'protoc -ofile.pb file.proto'. " +
-             "Output will be written to file.pb.h and file.pb.c.")
-optparser.add_option("-x", dest="exclude", metavar="FILE", action="append", default=[],
-    help="Exclude file from generated #include list.")
-optparser.add_option("-q", "--quiet", dest="quiet", action="store_true", default=False,
-    help="Don't print anything except errors.")
-optparser.add_option("-v", "--verbose", dest="verbose", action="store_true", default=False,
-    help="Print more information.")
-optparser.add_option("-s", dest="settings", metavar="OPTION:VALUE", action="append", default=[],
-    help="Set generator option (max_size, max_count etc.).")
-
-def get_nanopb_suboptions(subdesc, options):
-    '''Get copy of options, and merge information from subdesc.'''
-    new_options = nanopb_pb2.NanoPBOptions()
-    new_options.CopyFrom(options)
-    
-    if isinstance(subdesc.options, descriptor.FieldOptions):
-        ext_type = nanopb_pb2.nanopb
-    elif isinstance(subdesc.options, descriptor.FileOptions):
-        ext_type = nanopb_pb2.nanopb_fileopt
-    elif isinstance(subdesc.options, descriptor.MessageOptions):
-        ext_type = nanopb_pb2.nanopb_msgopt
-    elif isinstance(subdesc.options, descriptor.EnumOptions):
-        ext_type = nanopb_pb2.nanopb_enumopt
-    else:
-        raise Exception("Unknown options type")
-    
-    if subdesc.options.HasExtension(ext_type):
-        ext = subdesc.options.Extensions[ext_type]
-        new_options.MergeFrom(ext)
-    
-    return new_options
-
-def process(filenames, options):
-    '''Process the files given on the command line.'''
-    
-    if not filenames:
-        optparser.print_help()
-        return False
-    
-    if options.quiet:
-        options.verbose = False
-    
-    toplevel_options = nanopb_pb2.NanoPBOptions()
-    for s in options.settings:
-        text_format.Merge(s, toplevel_options)
-    
-    for filename in filenames:
-        data = open(filename, 'rb').read()
-        fdesc = descriptor.FileDescriptorSet.FromString(data)
-        
-        file_options = get_nanopb_suboptions(fdesc.file[0], toplevel_options)
-        
-        if options.verbose:
-            print "Options for " + filename + ":"
-            print text_format.MessageToString(file_options)
-        
-        enums, messages = parse_file(fdesc.file[0], file_options)
-        
-        noext = os.path.splitext(filename)[0]
-        headername = noext + '.pb.h'
-        sourcename = noext + '.pb.c'
-        headerbasename = os.path.basename(headername)
-        
-        if not options.quiet:
-            print "Writing to " + headername + " and " + sourcename
-        
-        # List of .proto files that should not be included in the C header file
-        # even if they are mentioned in the source .proto.
-        excludes = ['nanopb.proto', 'google/protobuf/descriptor.proto'] + options.exclude
-        dependencies = [d for d in fdesc.file[0].dependency if d not in excludes]
-        
-        header = open(headername, 'w')
-        for part in generate_header(dependencies, headerbasename, enums, messages):
-            header.write(part)
-
-        source = open(sourcename, 'w')
-        for part in generate_source(headerbasename, enums, messages):
-            source.write(part)
-
-    return True
-
 if __name__ == '__main__':
-    options, filenames = optparser.parse_args()
+    import sys
-    status = process(filenames, options)
+    import os.path
+    from optparse import OptionParser
+    usage = "usage: %prog [options] file.pb\n" + \
+            "where file.pb has been compiled from .proto by:\n" + \
+            "    protoc -ofile.pb file.proto\n" + \
+            "Output fill be written to file.pb.h and file.pb.c"
+
+    parser = OptionParser(usage=usage)
+    parser.add_option('-n', '--no-opt', action='store_true', dest='no_optimization', default=False, help='disable code reduction optimization as 64-bit architecture is not supported [default=optimization on]')
+    (options, args) = parser.parse_args()
     
-    if not status:
+    if len(args) != 1:
+        parser.print_help()
         sys.exit(1)
+    g_no_optimization = options.no_optimization
+    data = open(args[0], 'rb').read()
+    fdesc = descriptor.FileDescriptorSet.FromString(data)
+    enums, messages = parse_file(fdesc.file[0])
+    
+    noext = os.path.splitext(args[0])[0]
+    headername = noext + '.pb.h'
+    sourcename = noext + '.pb.c'
+    headerbasename = os.path.basename(headername)
+    
+    print "Writing to " + headername + " and " + sourcename
+    
+    # List of .proto files that should not be included in the C header file
+    # even if they are mentioned in the source .proto.
+    excludes = ['nanopb.proto']
+    dependencies = [d for d in fdesc.file[0].dependency if d not in excludes]
+    
+    header = open(headername, 'w')
+    for part in generate_header(dependencies, headerbasename, enums, messages):
+        header.write(part)
+
+    source = open(sourcename, 'w')
+    for part in generate_source(headerbasename, enums, messages):
+        source.write(part)
+
     

generator/nanopb_pb2.py

@@ -7,75 +7,15 @@ from google.protobuf import descriptor_pb2
 # @@protoc_insertion_point(imports)
 
 
-import google.protobuf.descriptor_pb2
-
 DESCRIPTOR = descriptor.FileDescriptor(
   name='nanopb.proto',
   package='',
-  serialized_pb='\n\x0cnanopb.proto\x1a google/protobuf/descriptor.proto\"\x92\x01\n\rNanoPBOptions\x12\x10\n\x08max_size\x18\x01 \x01(\x05\x12\x11\n\tmax_count\x18\x02 \x01(\x05\x12$\n\x04type\x18\x03 \x01(\x0e\x32\n.FieldType:\nFT_DEFAULT\x12\x18\n\nlong_names\x18\x04 \x01(\x08:\x04true\x12\x1c\n\rpacked_struct\x18\x05 \x01(\x08:\x05\x66\x61lse*J\n\tFieldType\x12\x0e\n\nFT_DEFAULT\x10\x00\x12\x0f\n\x0b\x46T_CALLBACK\x10\x01\x12\r\n\tFT_STATIC\x10\x02\x12\r\n\tFT_IGNORE\x10\x03:E\n\x0enanopb_fileopt\x12\x1c.google.protobuf.FileOptions\x18\xf2\x07 \x01(\x0b\x32\x0e.NanoPBOptions:G\n\rnanopb_msgopt\x12\x1f.google.protobuf.MessageOptions\x18\xf2\x07 \x01(\x0b\x32\x0e.NanoPBOptions:E\n\x0enanopb_enumopt\x12\x1c.google.protobuf.EnumOptions\x18\xf2\x07 \x01(\x0b\x32\x0e.NanoPBOptions:>\n\x06nanopb\x12\x1d.google.protobuf.FieldOptions\x18\xf2\x07 \x01(\x0b\x32\x0e.NanoPBOptions')
+  serialized_pb='\n\x0cnanopb.proto\x1a google/protobuf/descriptor.proto\"4\n\rNanoPBOptions\x12\x10\n\x08max_size\x18\x01 \x01(\x05\x12\x11\n\tmax_count\x18\x02 \x01(\x05:>\n\x06nanopb\x12\x1d.google.protobuf.FieldOptions\x18\xf2\x07 \x01(\x0b\x32\x0e.NanoPBOptions')
-
-_FIELDTYPE = descriptor.EnumDescriptor(
-  name='FieldType',
-  full_name='FieldType',
-  filename=None,
-  file=DESCRIPTOR,
-  values=[
-    descriptor.EnumValueDescriptor(
-      name='FT_DEFAULT', index=0, number=0,
-      options=None,
-      type=None),
-    descriptor.EnumValueDescriptor(
-      name='FT_CALLBACK', index=1, number=1,
-      options=None,
-      type=None),
-    descriptor.EnumValueDescriptor(
-      name='FT_STATIC', index=2, number=2,
-      options=None,
-      type=None),
-    descriptor.EnumValueDescriptor(
-      name='FT_IGNORE', index=3, number=3,
-      options=None,
-      type=None),
-  ],
-  containing_type=None,
-  options=None,
-  serialized_start=199,
-  serialized_end=273,
-)
 
 
-FT_DEFAULT = 0
-FT_CALLBACK = 1
-FT_STATIC = 2
-FT_IGNORE = 3
-
-NANOPB_FILEOPT_FIELD_NUMBER = 1010
-nanopb_fileopt = descriptor.FieldDescriptor(
-  name='nanopb_fileopt', full_name='nanopb_fileopt', index=0,
-  number=1010, type=11, cpp_type=10, label=1,
-  has_default_value=False, default_value=None,
-  message_type=None, enum_type=None, containing_type=None,
-  is_extension=True, extension_scope=None,
-  options=None)
-NANOPB_MSGOPT_FIELD_NUMBER = 1010
-nanopb_msgopt = descriptor.FieldDescriptor(
-  name='nanopb_msgopt', full_name='nanopb_msgopt', index=1,
-  number=1010, type=11, cpp_type=10, label=1,
-  has_default_value=False, default_value=None,
-  message_type=None, enum_type=None, containing_type=None,
-  is_extension=True, extension_scope=None,
-  options=None)
-NANOPB_ENUMOPT_FIELD_NUMBER = 1010
-nanopb_enumopt = descriptor.FieldDescriptor(
-  name='nanopb_enumopt', full_name='nanopb_enumopt', index=2,
-  number=1010, type=11, cpp_type=10, label=1,
-  has_default_value=False, default_value=None,
-  message_type=None, enum_type=None, containing_type=None,
-  is_extension=True, extension_scope=None,
-  options=None)
 NANOPB_FIELD_NUMBER = 1010
 nanopb = descriptor.FieldDescriptor(
-  name='nanopb', full_name='nanopb', index=3,
+  name='nanopb', full_name='nanopb', index=0,
   number=1010, type=11, cpp_type=10, label=1,
   has_default_value=False, default_value=None,
   message_type=None, enum_type=None, containing_type=None,
@@ -104,27 +44,6 @@ _NANOPBOPTIONS = descriptor.Descriptor(
       message_type=None, enum_type=None, containing_type=None,
       is_extension=False, extension_scope=None,
       options=None),
-    descriptor.FieldDescriptor(
-      name='type', full_name='NanoPBOptions.type', index=2,
-      number=3, type=14, cpp_type=8, label=1,
-      has_default_value=True, default_value=0,
-      message_type=None, enum_type=None, containing_type=None,
-      is_extension=False, extension_scope=None,
-      options=None),
-    descriptor.FieldDescriptor(
-      name='long_names', full_name='NanoPBOptions.long_names', index=3,
-      number=4, type=8, cpp_type=7, label=1,
-      has_default_value=True, default_value=True,
-      message_type=None, enum_type=None, containing_type=None,
-      is_extension=False, extension_scope=None,
-      options=None),
-    descriptor.FieldDescriptor(
-      name='packed_struct', full_name='NanoPBOptions.packed_struct', index=4,
-      number=5, type=8, cpp_type=7, label=1,
-      has_default_value=True, default_value=False,
-      message_type=None, enum_type=None, containing_type=None,
-      is_extension=False, extension_scope=None,
-      options=None),
   ],
   extensions=[
   ],
@@ -134,12 +53,12 @@ _NANOPBOPTIONS = descriptor.Descriptor(
   options=None,
   is_extendable=False,
   extension_ranges=[],
-  serialized_start=51,
+  serialized_start=50,
-  serialized_end=197,
+  serialized_end=102,
 )
 
-_NANOPBOPTIONS.fields_by_name['type'].enum_type = _FIELDTYPE
+import google.protobuf.descriptor_pb2
-DESCRIPTOR.message_types_by_name['NanoPBOptions'] = _NANOPBOPTIONS
+
 
 class NanoPBOptions(message.Message):
   __metaclass__ = reflection.GeneratedProtocolMessageType
@@ -147,12 +66,6 @@ class NanoPBOptions(message.Message):
   
   # @@protoc_insertion_point(class_scope:NanoPBOptions)
 
-nanopb_fileopt.message_type = _NANOPBOPTIONS
-google.protobuf.descriptor_pb2.FileOptions.RegisterExtension(nanopb_fileopt)
-nanopb_msgopt.message_type = _NANOPBOPTIONS
-google.protobuf.descriptor_pb2.MessageOptions.RegisterExtension(nanopb_msgopt)
-nanopb_enumopt.message_type = _NANOPBOPTIONS
-google.protobuf.descriptor_pb2.EnumOptions.RegisterExtension(nanopb_enumopt)
 nanopb.message_type = _NANOPBOPTIONS
 google.protobuf.descriptor_pb2.FieldOptions.RegisterExtension(nanopb)
 # @@protoc_insertion_point(module_scope)

pb.h

@@ -5,161 +5,7 @@
  * Most of these are quite low-level stuff. For the high-level interface,
  * see pb_encode.h or pb_decode.h
  */
-
+#include <pb_field.h>
-#define NANOPB_VERSION nanopb-0.1.9.1
-
-#include <stdint.h>
-#include <stddef.h>
-#include <stdbool.h>
-
-#ifdef __GNUC__
-/* This just reduces memory requirements, but is not required. */
-#define pb_packed __attribute__((packed))
-#else
-#define pb_packed
-#endif
-
-/* Handly macro for suppressing unreferenced-parameter compiler warnings.    */
-#ifndef UNUSED
-#define UNUSED(x) (void)(x)
-#endif
-
-/* Compile-time assertion, used for checking compatible compilation options.
- * If this fails on your compiler for some reason, use #define STATIC_ASSERT
- * to disable it. */
-#ifndef STATIC_ASSERT
-#define STATIC_ASSERT(COND,MSG) typedef char STATIC_ASSERT_MSG(MSG, __LINE__, __COUNTER__)[(COND)?1:-1];
-#define STATIC_ASSERT_MSG(MSG, LINE, COUNTER) STATIC_ASSERT_MSG_(MSG, LINE, COUNTER)
-#define STATIC_ASSERT_MSG_(MSG, LINE, COUNTER) static_assertion_##MSG##LINE##COUNTER
-#endif
-
-/* Number of required fields to keep track of
- * (change here or on compiler command line). */
-#ifndef PB_MAX_REQUIRED_FIELDS
-#define PB_MAX_REQUIRED_FIELDS 64
-#endif
-
-#if PB_MAX_REQUIRED_FIELDS < 64
-#error You should not lower PB_MAX_REQUIRED_FIELDS from the default value (64).
-#endif
-
-/* List of possible field types. These are used in the autogenerated code.
- * Least-significant 4 bits tell the scalar type
- * Most-significant 4 bits specify repeated/required/packed etc.
- * 
- * INT32 and UINT32 are treated the same, as are (U)INT64 and (S)FIXED*
- * These types are simply casted to correct field type when they are
- * assigned to the memory pointer.
- * SINT* is different, though, because it is zig-zag coded.
- */
-
-typedef enum {
-    /************************
-     * Field contents types *
-     ************************/
-    
-    /* Numeric types */
-    PB_LTYPE_VARINT = 0x00, /* int32, uint32, int64, uint64, bool, enum */
-    PB_LTYPE_SVARINT = 0x01, /* sint32, sint64 */
-    PB_LTYPE_FIXED32 = 0x02, /* fixed32, sfixed32, float */
-    PB_LTYPE_FIXED64 = 0x03, /* fixed64, sfixed64, double */
-    
-    /* Marker for last packable field type. */
-    PB_LTYPE_LAST_PACKABLE = 0x03,
-    
-    /* Byte array with pre-allocated buffer.
-     * data_size is the length of the allocated PB_BYTES_ARRAY structure. */
-    PB_LTYPE_BYTES = 0x04,
-    
-    /* String with pre-allocated buffer.
-     * data_size is the maximum length. */
-    PB_LTYPE_STRING = 0x05,
-    
-    /* Submessage
-     * submsg_fields is pointer to field descriptions */
-    PB_LTYPE_SUBMESSAGE = 0x06,
-    
-    /* Number of declared LTYPES */
-    PB_LTYPES_COUNT = 7,
-    PB_LTYPE_MASK = 0x0F,
-    
-    /******************
-     * Modifier flags *
-     ******************/
-    
-    /* Just the basic, write data at data_offset */
-    PB_HTYPE_REQUIRED = 0x00,
-    
-    /* Write true at size_offset */
-    PB_HTYPE_OPTIONAL = 0x10,
-    
-    /* Read to pre-allocated array
-     * Maximum number of entries is array_size,
-     * actual number is stored at size_offset */
-    PB_HTYPE_ARRAY = 0x20,
-    
-    /* Works for all required/optional/repeated fields.
-     * data_offset points to pb_callback_t structure.
-     * LTYPE should be valid or 0 (it is ignored, but
-     * sometimes used to speculatively index an array). */
-    PB_HTYPE_CALLBACK = 0x30,
-    
-    PB_HTYPE_MASK = 0xF0
-} pb_packed pb_type_t;
-
-#define PB_HTYPE(x) ((x) & PB_HTYPE_MASK)
-#define PB_LTYPE(x) ((x) & PB_LTYPE_MASK)
-
-/* This structure is used in auto-generated constants
- * to specify struct fields.
- * You can change field sizes if you need structures
- * larger than 256 bytes or field tags larger than 256.
- * The compiler should complain if your .proto has such
- * structures. Fix that by defining PB_FIELD_16BIT or
- * PB_FIELD_32BIT.
- */
-typedef struct _pb_field_t pb_field_t;
-struct _pb_field_t {
-
-#if !defined(PB_FIELD_16BIT) && !defined(PB_FIELD_32BIT)
-    uint8_t tag;
-    pb_type_t type;
-    uint8_t data_offset; /* Offset of field data, relative to previous field. */
-    int8_t size_offset; /* Offset of array size or has-boolean, relative to data */
-    uint8_t data_size; /* Data size in bytes for a single item */
-    uint8_t array_size; /* Maximum number of entries in array */
-#elif defined(PB_FIELD_16BIT) && !defined(PB_FIELD_32BIT)
-    uint16_t tag;
-    pb_type_t type;
-    uint8_t data_offset;
-    int8_t size_offset;
-    uint16_t data_size;
-    uint16_t array_size;
-#else
-    uint32_t tag;
-    pb_type_t type;
-    uint8_t data_offset;
-    int8_t size_offset;
-    uint32_t data_size;
-    uint32_t array_size;
-#endif
-    
-    /* Field definitions for submessage
-     * OR default value for all other non-array, non-callback types
-     * If null, then field will zeroed. */
-    const void *ptr;
-} pb_packed;
-
-/* This structure is used for 'bytes' arrays.
- * It has the number of bytes in the beginning, and after that an array.
- * Note that actual structs used will have a different length of bytes array.
- */
-struct _pb_bytes_array_t {
-    size_t size;
-    uint8_t bytes[1];
-};
-
-typedef struct _pb_bytes_array_t pb_bytes_array_t;
 
 /* This structure is used for giving the callback function.
  * It is stored in the message structure and filled in by the method that
@@ -200,30 +46,4 @@ typedef enum {
     PB_WT_32BIT  = 5
 } pb_wire_type_t;
 
-/* These macros are used to declare pb_field_t's in the constant array. */
-#define pb_membersize(st, m) (sizeof ((st*)0)->m)
-#define pb_arraysize(st, m) (pb_membersize(st, m) / pb_membersize(st, m[0]))
-#define pb_delta(st, m1, m2) ((int)offsetof(st, m1) - (int)offsetof(st, m2))
-#define pb_delta_end(st, m1, m2) (offsetof(st, m1) - offsetof(st, m2) - pb_membersize(st, m2))
-#define PB_LAST_FIELD {0,(pb_type_t) 0,0,0,0,0,0}
-
-/* These macros are used for giving out error messages.
- * They are mostly a debugging aid; the main error information
- * is the true/false return value from functions.
- * Some code space can be saved by disabling the error
- * messages if not used.
- */
-#ifdef PB_NO_ERRMSG
-#define PB_RETURN_ERROR(stream,msg) return false
-#define PB_GET_ERROR(stream) "(errmsg disabled)"
-#else
-#define PB_RETURN_ERROR(stream,msg) \
-    do {\
-        if ((stream)->errmsg == NULL) \
-            (stream)->errmsg = (msg); \
-        return false; \
-    } while(0)
-#define PB_GET_ERROR(stream) ((stream)->errmsg ? (stream)->errmsg : "(none)")
-#endif
-
 #endif

pb_decode.c

@@ -3,15 +3,14 @@
  * 2011 Petteri Aimonen <jpa@kapsi.fi>
  */
 
-/* The warn_unused_result attribute appeared first in gcc-3.4.0 */
+
-#if !defined(__GNUC__) || ( __GNUC__ < 3) || (__GNUC__ == 3 && __GNUC_MINOR__ < 4)
+#ifdef __GNUC__
-    #define checkreturn
+/* Verify that we remember to check all return values for proper error propagation */
+#define checkreturn __attribute__((warn_unused_result))
 #else
-    /* Verify that we remember to check all return values for proper error propagation */
+#define checkreturn
-    #define checkreturn __attribute__((warn_unused_result))
 #endif
 
-#define NANOPB_INTERNALS
 #include "pb.h"
 #include "pb_decode.h"
 #include <string.h>
@@ -36,67 +35,35 @@ static const pb_decoder_t PB_DECODERS[PB_LTYPES_COUNT] = {
  * pb_istream *
  **************/
 
-static bool checkreturn buf_read(pb_istream_t *stream, uint8_t *buf, size_t count)
+bool checkreturn pb_read(pb_istream_t *stream, uint8_t *buf, size_t count)
 {
-    uint8_t *source = (uint8_t*)stream->state;
+    if (stream->bytes_left < count)
-    stream->state = source + count;
+        return false;
     
-    if (buf != NULL)
+    if (!stream->callback(stream, buf, count))
-    {
+        return false;
-        while (count--)
-            *buf++ = *source++;
-    }
     
+    stream->bytes_left -= count;
     return true;
 }
 
-bool checkreturn pb_read(pb_istream_t *stream, uint8_t *buf, size_t count)
+static bool checkreturn buf_read(pb_istream_t *stream, uint8_t *buf, size_t count)
 {
-#ifndef PB_BUFFER_ONLY
+    uint8_t *source = (uint8_t*)stream->state;
-	if (buf == NULL && stream->callback != buf_read)
-	{
-		/* Skip input bytes */
-		uint8_t tmp[16];
-		while (count > 16)
-		{
-			if (!pb_read(stream, tmp, 16))
-				return false;
-			
-			count -= 16;
-		}
-		
-		return pb_read(stream, tmp, count);
-	}
-#endif
-
-    if (stream->bytes_left < count)
-        PB_RETURN_ERROR(stream, "end-of-stream");
     
-#ifndef PB_BUFFER_ONLY
+    if (buf != NULL)
-    if (!stream->callback(stream, buf, count))
+        memcpy(buf, source, count);
-        PB_RETURN_ERROR(stream, "io error");
-#else
-    if (!buf_read(stream, buf, count))
-        return false;
-#endif
     
-    stream->bytes_left -= count;
+    stream->state = source + count;
     return true;
 }
 
 pb_istream_t pb_istream_from_buffer(uint8_t *buf, size_t bufsize)
 {
     pb_istream_t stream;
-#ifdef PB_BUFFER_ONLY
-    stream.callback = NULL;
-#else
     stream.callback = &buf_read;
-#endif
     stream.state = buf;
     stream.bytes_left = bufsize;
-#ifndef PB_NO_ERRMSG
-    stream.errmsg = NULL;
-#endif
     return stream;
 }
 
@@ -106,60 +73,28 @@ pb_istream_t pb_istream_from_buffer(uint8_t *buf, size_t bufsize)
 
 static bool checkreturn pb_decode_varint32(pb_istream_t *stream, uint32_t *dest)
 {
-    uint8_t byte;
+    uint64_t temp;
-    uint32_t result;
+    bool status = pb_decode_varint(stream, &temp);
-    
+    *dest = temp;
-    if (!pb_read(stream, &byte, 1))
+    return status;
-        return false;
-    
-    if (!(byte & 0x80))
-    {
-        /* Quick case, 1 byte value */
-        result = byte;
-    }
-    else
-    {
-        /* Multibyte case */
-        uint8_t bitpos = 7;
-        result = byte & 0x7F;
-        
-        do
-        {
-            if (bitpos >= 32)
-                PB_RETURN_ERROR(stream, "varint overflow");
-            
-            if (!pb_read(stream, &byte, 1))
-                return false;
-            
-            result |= (uint32_t)(byte & 0x7F) << bitpos;
-            bitpos = (uint8_t)(bitpos + 7);
-        } while (byte & 0x80);
-   }
-   
-   *dest = result;
-   return true;
 }
 
 bool checkreturn pb_decode_varint(pb_istream_t *stream, uint64_t *dest)
 {
     uint8_t byte;
     uint8_t bitpos = 0;
-    uint64_t result = 0;
+    *dest = 0;
     
-    do
+    while (bitpos < 64 && pb_read(stream, &byte, 1))
     {
-        if (bitpos >= 64)
+        *dest |= (uint64_t)(byte & 0x7F) << bitpos;
-            PB_RETURN_ERROR(stream, "varint overflow");
+        bitpos += 7;
         
-        if (!pb_read(stream, &byte, 1))
+        if (!(byte & 0x80))
-            return false;
+            return true;
-
+    }
-        result |= (uint64_t)(byte & 0x7F) << bitpos;
-        bitpos = (uint8_t)(bitpos + 7);
-    } while (byte & 0x80);
     
-    *dest = result;
+    return false;
-    return true;
 }
 
 bool checkreturn pb_skip_varint(pb_istream_t *stream)
@@ -182,33 +117,12 @@ bool checkreturn pb_skip_string(pb_istream_t *stream)
     return pb_read(stream, NULL, length);
 }
 
-bool checkreturn pb_decode_tag(pb_istream_t *stream, pb_wire_type_t *wire_type, uint32_t *tag, bool *eof)
+/* Currently the wire type related stuff is kept hidden from
-{
+ * callbacks. They shouldn't need it. It's better for performance
-    uint32_t temp;
+ * to just assume the correct type and fail safely on corrupt message.
-    *eof = false;
+ */
-    *wire_type = (pb_wire_type_t) 0;
-    *tag = 0;
-    
-    if (!pb_decode_varint32(stream, &temp))
-    {
-        if (stream->bytes_left == 0)
-            *eof = true;
 
-        return false;
+static bool checkreturn skip(pb_istream_t *stream, pb_wire_type_t wire_type)
-    }
-    
-    if (temp == 0)
-    {
-        *eof = true; /* Special feature: allow 0-terminated messages. */
-        return false;
-    }
-    
-    *tag = temp >> 3;
-    *wire_type = (pb_wire_type_t)(temp & 7);
-    return true;
-}
-
-bool checkreturn pb_skip_field(pb_istream_t *stream, pb_wire_type_t wire_type)
 {
     switch (wire_type)
     {
@@ -216,7 +130,7 @@ bool checkreturn pb_skip_field(pb_istream_t *stream, pb_wire_type_t wire_type)
         case PB_WT_64BIT: return pb_read(stream, NULL, 8);
         case PB_WT_STRING: return pb_skip_string(stream);
         case PB_WT_32BIT: return pb_read(stream, NULL, 4);
-        default: PB_RETURN_ERROR(stream, "invalid wire_type");
+        default: return false;
     }
 }
 
@@ -246,14 +160,15 @@ static bool checkreturn read_raw_value(pb_istream_t *stream, pb_wire_type_t wire
             *size = 4;
             return pb_read(stream, buf, 4);
         
-        default: PB_RETURN_ERROR(stream, "invalid wire_type");
+        default: return false;
     }
 }
 
 /* Decode string length from stream and return a substream with limited length.
- * Remember to close the substream using pb_close_string_substream().
+ * Before disposing the substream, remember to copy the substream->state back
+ * to stream->state.
  */
-bool checkreturn pb_make_string_substream(pb_istream_t *stream, pb_istream_t *substream)
+static bool checkreturn make_string_substream(pb_istream_t *stream, pb_istream_t *substream)
 {
     uint32_t size;
     if (!pb_decode_varint32(stream, &size))
@@ -261,139 +176,59 @@ bool checkreturn pb_make_string_substream(pb_istream_t *stream, pb_istream_t *su
     
     *substream = *stream;
     if (substream->bytes_left < size)
-        PB_RETURN_ERROR(stream, "parent stream too short");
+        return false;
     
     substream->bytes_left = size;
     stream->bytes_left -= size;
     return true;
 }
 
-void pb_close_string_substream(pb_istream_t *stream, pb_istream_t *substream)
-{
-    stream->state = substream->state;
-
-#ifndef PB_NO_ERRMSG
-    stream->errmsg = substream->errmsg;
-#endif
-}
-
-/* Iterator for pb_field_t list */
-typedef struct {
-    const pb_field_t *start; /* Start of the pb_field_t array */
-    const pb_field_t *current; /* Current position of the iterator */
-    unsigned field_index; /* Zero-based index of the field. */
-    unsigned required_field_index; /* Zero-based index that counts only the required fields */
-    void *dest_struct; /* Pointer to the destination structure to decode to */
-    void *pData; /* Pointer where to store current field value */
-    void *pSize; /* Pointer where to store the size of current array field */
-} pb_field_iterator_t;
-
-static void pb_field_init(pb_field_iterator_t *iter, const pb_field_t *fields, void *dest_struct)
-{
-    iter->start = iter->current = fields;
-    iter->field_index = 0;
-    iter->required_field_index = 0;
-    iter->pData = (char*)dest_struct + iter->current->data_offset;
-    iter->pSize = (char*)iter->pData + iter->current->size_offset;
-    iter->dest_struct = dest_struct;
-}
-
-static bool pb_field_next(pb_field_iterator_t *iter)
-{
-    bool notwrapped = true;
-    size_t prev_size = iter->current->data_size;
-    
-    if (PB_HTYPE(iter->current->type) == PB_HTYPE_ARRAY)
-        prev_size *= iter->current->array_size;
-    
-    if (PB_HTYPE(iter->current->type) == PB_HTYPE_REQUIRED)
-        iter->required_field_index++;
-    
-    iter->current++;
-    iter->field_index++;
-    if (iter->current->tag == 0)
-    {
-        iter->current = iter->start;
-        iter->field_index = 0;
-        iter->required_field_index = 0;
-        iter->pData = iter->dest_struct;
-        prev_size = 0;
-        notwrapped = false;
-    }
-    
-    iter->pData = (char*)iter->pData + prev_size + iter->current->data_offset;
-    iter->pSize = (char*)iter->pData + iter->current->size_offset;
-    return notwrapped;
-}
-
-static bool checkreturn pb_field_find(pb_field_iterator_t *iter, uint32_t tag)
-{
-    unsigned start = iter->field_index;
-    
-    do {
-        if (iter->current->tag == tag)
-            return true;
-        pb_field_next(iter);
-    } while (iter->field_index != start);
-    
-    return false;
-}
-
 /*************************
  * Decode a single field *
  *************************/
 
 static bool checkreturn decode_field(pb_istream_t *stream, pb_wire_type_t wire_type, pb_field_iterator_t *iter)
 {
-    pb_decoder_t func = PB_DECODERS[PB_LTYPE(iter->current->type)];
+    pb_decoder_t func = PB_DECODERS[PB_LTYPE(iter->current.type)];
     
-    switch (PB_HTYPE(iter->current->type))
+    switch (PB_HTYPE(iter->current.type))
     {
         case PB_HTYPE_REQUIRED:
-            return func(stream, iter->current, iter->pData);
+            return func(stream, &iter->current, iter->pData);
             
         case PB_HTYPE_OPTIONAL:
             *(bool*)iter->pSize = true;
-            return func(stream, iter->current, iter->pData);
+            return func(stream, &iter->current, iter->pData);
     
         case PB_HTYPE_ARRAY:
             if (wire_type == PB_WT_STRING
-                && PB_LTYPE(iter->current->type) <= PB_LTYPE_LAST_PACKABLE)
+                && PB_LTYPE(iter->current.type) <= PB_LTYPE_LAST_PACKABLE)
             {
                 /* Packed array */
-                bool status = true;
                 size_t *size = (size_t*)iter->pSize;
                 pb_istream_t substream;
-                if (!pb_make_string_substream(stream, &substream))
+                if (!make_string_substream(stream, &substream))
                     return false;
                 
-                while (substream.bytes_left && *size < iter->current->array_size)
+                while (substream.bytes_left && *size < iter->current.array_size)
                 {
-                    void *pItem = (uint8_t*)iter->pData + iter->current->data_size * (*size);
+                    void *pItem = (uint8_t*)iter->pData + iter->current.data_size * (*size);
-                    if (!func(&substream, iter->current, pItem))
+                    if (!func(&substream, &iter->current, pItem))
-                    {
+                        return false;
-                        status = false;
-                        break;
-                    }
                     (*size)++;
                 }
-                pb_close_string_substream(stream, &substream);
+                return (substream.bytes_left == 0);
-                
-                if (substream.bytes_left != 0)
-                    PB_RETURN_ERROR(stream, "array overflow");
-                
-                return status;
             }
             else
             {
                 /* Repeated field */
                 size_t *size = (size_t*)iter->pSize;
-                void *pItem = (uint8_t*)iter->pData + iter->current->data_size * (*size);
+                void *pItem = (uint8_t*)iter->pData + iter->current.data_size * (*size);
-                if (*size >= iter->current->array_size)
+                if (*size >= iter->current.array_size)
-                    PB_RETURN_ERROR(stream, "array overflow");
+                    return false;
                 
                 (*size)++;
-                return func(stream, iter->current, pItem);
+                return func(stream, &iter->current, pItem);
             }
         
         case PB_HTYPE_CALLBACK:
@@ -401,22 +236,22 @@ static bool checkreturn decode_field(pb_istream_t *stream, pb_wire_type_t wire_t
             pb_callback_t *pCallback = (pb_callback_t*)iter->pData;
             
             if (pCallback->funcs.decode == NULL)
-                return pb_skip_field(stream, wire_type);
+                return skip(stream, wire_type);
             
             if (wire_type == PB_WT_STRING)
             {
                 pb_istream_t substream;
                 
-                if (!pb_make_string_substream(stream, &substream))
+                if (!make_string_substream(stream, &substream))
                     return false;
                 
                 while (substream.bytes_left)
                 {
-                    if (!pCallback->funcs.decode(&substream, iter->current, pCallback->arg))
+                    if (!pCallback->funcs.decode(&substream, &iter->current, pCallback->arg))
-                        PB_RETURN_ERROR(stream, "callback failed");
+                        return false;
                 }
                 
-                pb_close_string_substream(stream, &substream);
+                stream->state = substream.state;
                 return true;
             }
             else
@@ -433,54 +268,54 @@ static bool checkreturn decode_field(pb_istream_t *stream, pb_wire_type_t wire_t
                     return false;
                 substream = pb_istream_from_buffer(buffer, size);
                 
-                return pCallback->funcs.decode(&substream, iter->current, pCallback->arg);
+                return pCallback->funcs.decode(&substream, &iter->current, pCallback->arg);
             }
         }
         
         default:
-            PB_RETURN_ERROR(stream, "invalid field type");
+            return false;
     }
 }
 
 /* Initialize message fields to default values, recursively */
-static void pb_message_set_to_defaults(const pb_field_t fields[], void *dest_struct)
+static void pb_message_set_to_defaults(const pb_field_info_t *fields, void *dest_struct)
 {
     pb_field_iterator_t iter;
+
+    if (fields->field_keys == NULL) return;
+
     pb_field_init(&iter, fields, dest_struct);
     
     /* Initialize size/has fields and apply default values */
     do
     {
-        if (iter.current->tag == 0)
-            continue;
-        
         /* Initialize the size field for optional/repeated fields to 0. */
-        if (PB_HTYPE(iter.current->type) == PB_HTYPE_OPTIONAL)
+        if (PB_HTYPE(iter.current.type) == PB_HTYPE_OPTIONAL)
         {
             *(bool*)iter.pSize = false;
         }
-        else if (PB_HTYPE(iter.current->type) == PB_HTYPE_ARRAY)
+        else if (PB_HTYPE(iter.current.type) == PB_HTYPE_ARRAY)
         {
             *(size_t*)iter.pSize = 0;
             continue; /* Array is empty, no need to initialize contents */
         }
         
         /* Initialize field contents to default value */
-        if (PB_HTYPE(iter.current->type) == PB_HTYPE_CALLBACK)
+        if (PB_HTYPE(iter.current.type) == PB_HTYPE_CALLBACK)
         {
             continue; /* Don't overwrite callback */
         }
-        else if (PB_LTYPE(iter.current->type) == PB_LTYPE_SUBMESSAGE)
+        else if (PB_LTYPE(iter.current.type) == PB_LTYPE_SUBMESSAGE)
         {
-            pb_message_set_to_defaults((const pb_field_t *) iter.current->ptr, iter.pData);
+            pb_message_set_to_defaults(iter.current.ptr, iter.pData);
         }
-        else if (iter.current->ptr != NULL)
+        else if (iter.current.ptr != NULL)
         {
-            memcpy(iter.pData, iter.current->ptr, iter.current->data_size);
+            memcpy(iter.pData, iter.current.ptr, iter.current.data_size);
         }
         else
         {
-            memset(iter.pData, 0, iter.current->data_size);
+            memset(iter.pData, 0, iter.current.data_size);
         }
     } while (pb_field_next(&iter));
 }
@@ -489,184 +324,126 @@ static void pb_message_set_to_defaults(const pb_field_t fields[], void *dest_str
  * Decode all fields *
  *********************/
 
-bool checkreturn pb_decode_noinit(pb_istream_t *stream, const pb_field_t fields[], void *dest_struct)
+bool checkreturn pb_decode(pb_istream_t *stream, const pb_field_info_t *fields, void *dest_struct)
 {
-    uint8_t fields_seen[(PB_MAX_REQUIRED_FIELDS + 7) / 8] = {0}; /* Used to check for required fields */
+    uint32_t fields_seen = 0; /* Used to check for required fields */
     pb_field_iterator_t iter;
+    const pb_field_key_t *field_keys = fields->field_keys;
+    int i;
+    
+    pb_message_set_to_defaults(fields, dest_struct);
     
     pb_field_init(&iter, fields, dest_struct);
     
     while (stream->bytes_left)
     {
-        uint32_t tag;
+        uint32_t temp;
+        int tag;
         pb_wire_type_t wire_type;
-        bool eof;
+        if (!pb_decode_varint32(stream, &temp))
-        
-        if (!pb_decode_tag(stream, &wire_type, &tag, &eof))
         {
-            if (eof)
+            if (stream->bytes_left == 0)
-                break;
+                break; /* It was EOF */
             else
-                return false;
+                return false; /* It was error */
         }
         
+        if (temp == 0)
+            break; /* Special feature: allow 0-terminated messages. */
+        
+        tag = temp >> 3;
+        wire_type = (pb_wire_type_t)(temp & 7);
+        
         if (!pb_field_find(&iter, tag))
         {
             /* No match found, skip data */
-            if (!pb_skip_field(stream, wire_type))
+            if (!skip(stream, wire_type))
                 return false;
             continue;
         }
         
-        if (PB_HTYPE(iter.current->type) == PB_HTYPE_REQUIRED
+        fields_seen |= 1 << (iter.field_index & 31);
-            && iter.required_field_index < PB_MAX_REQUIRED_FIELDS)
-        {
-            fields_seen[iter.required_field_index >> 3] |= (uint8_t)(1 << (iter.required_field_index & 7));
-        }
             
         if (!decode_field(stream, wire_type, &iter))
             return false;
     }
     
-    /* Check that all required fields were present. */
+    /* Check that all required fields (mod 31) were present. */
+    for (i = 0; field_keys != NULL; i++)
     {
-        /* First figure out the number of required fields by
+        if (PB_HTYPE(PB_FIELD_INFO(&field_keys[i], fields->field_info)->type) == PB_HTYPE_REQUIRED &&
-         * seeking to the end of the field array. Usually we
+            !(fields_seen & (1 << (i & 31))))
-         * are already close to end after decoding.
-         */
-        unsigned req_field_count;
-        pb_type_t last_type;
-        unsigned i;
-        do {
-            req_field_count = iter.required_field_index;
-            last_type = iter.current->type;
-        } while (pb_field_next(&iter));
-        
-        /* Fixup if last field was also required. */
-        if (PB_HTYPE(last_type) == PB_HTYPE_REQUIRED)
-            req_field_count++;
-        
-        /* Check the whole bytes */
-        for (i = 0; i < (req_field_count >> 3); i++)
         {
-            if (fields_seen[i] != 0xFF)
+            return false;
-                PB_RETURN_ERROR(stream, "missing required field");
         }
-        
+        if (PB_IS_LAST(&field_keys[i])) break;
-        /* Check the remaining bits */
-        if (fields_seen[req_field_count >> 3] != (0xFF >> (8 - (req_field_count & 7))))
-            PB_RETURN_ERROR(stream, "missing required field");
     }
     
     return true;
 }
 
-bool checkreturn pb_decode(pb_istream_t *stream, const pb_field_t fields[], void *dest_struct)
-{
-    pb_message_set_to_defaults(fields, dest_struct);
-    return pb_decode_noinit(stream, fields, dest_struct);
-}
-
 /* Field decoders */
 
-bool pb_decode_svarint(pb_istream_t *stream, int64_t *dest)
+/* Copy destsize bytes from src so that values are casted properly.
+ * On little endian machine, copy first n bytes of src
+ * On big endian machine, copy last n bytes of src
+ * srcsize must always be larger than destsize
+ */
+static void endian_copy(void *dest, void *src, size_t destsize, size_t srcsize)
 {
-    uint64_t value;
+#ifdef __BIG_ENDIAN__
-    if (!pb_decode_varint(stream, &value))
+    memcpy(dest, (char*)src + (srcsize - destsize), destsize);
-        return false;
+#else
-    
+    memcpy(dest, src, destsize);
-    if (value & 1)
+#endif
-        *dest = (int64_t)(~(value >> 1));
-    else
-        *dest = (int64_t)(value >> 1);
-    
-    return true;
-}
-
-bool pb_decode_fixed32(pb_istream_t *stream, void *dest)
-{
-    #ifdef __BIG_ENDIAN__
-    uint8_t *bytes = (uint8_t*)dest;
-    uint8_t lebytes[4];
-    
-    if (!pb_read(stream, lebytes, 4))
-        return false;
-    
-    bytes[0] = lebytes[3];
-    bytes[1] = lebytes[2];
-    bytes[2] = lebytes[1];
-    bytes[3] = lebytes[0];
-    return true;
-    #else
-    return pb_read(stream, (uint8_t*)dest, 4);
-    #endif   
-}
-
-bool pb_decode_fixed64(pb_istream_t *stream, void *dest)
-{
-    #ifdef __BIG_ENDIAN__
-    uint8_t *bytes = (uint8_t*)dest;
-    uint8_t lebytes[8];
-    
-    if (!pb_read(stream, lebytes, 8))
-        return false;
-    
-    bytes[0] = lebytes[7];
-    bytes[1] = lebytes[6];
-    bytes[2] = lebytes[5];
-    bytes[3] = lebytes[4];
-    bytes[4] = lebytes[3];
-    bytes[5] = lebytes[2];
-    bytes[6] = lebytes[1];
-    bytes[7] = lebytes[0];
-    return true;
-    #else
-    return pb_read(stream, (uint8_t*)dest, 8);
-    #endif   
 }
 
 bool checkreturn pb_dec_varint(pb_istream_t *stream, const pb_field_t *field, void *dest)
 {
-    uint64_t value;
+    uint64_t temp;
-    bool status = pb_decode_varint(stream, &value);
+    bool status = pb_decode_varint(stream, &temp);
-    
+    endian_copy(dest, &temp, field->data_size, sizeof(temp));
-    switch (field->data_size)
-    {
-        case 1: *(uint8_t*)dest = (uint8_t)value; break;
-        case 2: *(uint16_t*)dest = (uint16_t)value; break;
-        case 4: *(uint32_t*)dest = (uint32_t)value; break;
-        case 8: *(uint64_t*)dest = value; break;
-        default: PB_RETURN_ERROR(stream, "invalid data_size");
-    }
-    
     return status;
 }
 
 bool checkreturn pb_dec_svarint(pb_istream_t *stream, const pb_field_t *field, void *dest)
 {
-    int64_t value;
+    uint64_t temp;
-    bool status = pb_decode_svarint(stream, &value);
+    bool status = pb_decode_varint(stream, &temp);
-    
+    temp = (temp >> 1) ^ -(int64_t)(temp & 1);
-    switch (field->data_size)
+    endian_copy(dest, &temp, field->data_size, sizeof(temp));
-    {
-        case 4: *(int32_t*)dest = (int32_t)value; break;
-        case 8: *(int64_t*)dest = value; break;
-        default: PB_RETURN_ERROR(stream, "invalid data_size");
-    }
-    
     return status;
 }
 
 bool checkreturn pb_dec_fixed32(pb_istream_t *stream, const pb_field_t *field, void *dest)
 {
-    UNUSED(field);
+#ifdef __BIG_ENDIAN__
-    return pb_decode_fixed32(stream, dest);
+    uint8_t bytes[4] = {0};
+    bool status = pb_read(stream, bytes, 4);
+    if (status) {
+      uint8_t bebytes[4] = {bytes[3], bytes[2], bytes[1], bytes[0]};
+      memcpy(dest, bebytes, 4);
+    }
+    return status;
+#else
+    return pb_read(stream, (uint8_t*)dest, 4);
+#endif
 }
 
 bool checkreturn pb_dec_fixed64(pb_istream_t *stream, const pb_field_t *field, void *dest)
 {
-    UNUSED(field);
+#ifdef __BIG_ENDIAN__
-    return pb_decode_fixed64(stream, dest);
+    uint8_t bytes[8] = {0};
+    bool status = pb_read(stream, bytes, 8);
+    if (status) {
+      uint8_t bebytes[8] = {bytes[7], bytes[6], bytes[5], bytes[4], 
+                            bytes[3], bytes[2], bytes[1], bytes[0]};
+      memcpy(dest, bebytes, 8);
+    }
+    return status;
+#else
+    return pb_read(stream, (uint8_t*)dest, 8);
+#endif
 }
 
 bool checkreturn pb_dec_bytes(pb_istream_t *stream, const pb_field_t *field, void *dest)
@@ -678,12 +455,9 @@ bool checkreturn pb_dec_bytes(pb_istream_t *stream, const pb_field_t *field, voi
         return false;
     x->size = temp;
     
-    if (x->size < temp)
-        PB_RETURN_ERROR(stream, "size too large");
-    
     /* Check length, noting the space taken by the size_t header. */
     if (x->size > field->data_size - offsetof(pb_bytes_array_t, bytes))
-        PB_RETURN_ERROR(stream, "bytes overflow");
+        return false;    
     
     return pb_read(stream, x->bytes, x->size);
 }
@@ -691,19 +465,12 @@ bool checkreturn pb_dec_bytes(pb_istream_t *stream, const pb_field_t *field, voi
 bool checkreturn pb_dec_string(pb_istream_t *stream, const pb_field_t *field, void *dest)
 {
     uint32_t size;
-    size_t alloc_size;
     bool status;
     if (!pb_decode_varint32(stream, &size))
         return false;
     
-    alloc_size = size + 1;
+    if ((int) size > field->data_size - 1)
-    
+        return false;
-    if (alloc_size < size)
-        PB_RETURN_ERROR(stream, "size too large");
-    
-    /* Check length, noting the null terminator */
-    if (alloc_size > field->data_size)
-        PB_RETURN_ERROR(stream, "string overflow");
     
     status = pb_read(stream, (uint8_t*)dest, size);
     *((uint8_t*)dest + size) = 0;
@@ -714,21 +481,14 @@ bool checkreturn pb_dec_submessage(pb_istream_t *stream, const pb_field_t *field
 {
     bool status;
     pb_istream_t substream;
-    const pb_field_t* submsg_fields = (const pb_field_t*)field->ptr;
     
-    if (!pb_make_string_substream(stream, &substream))
+    if (!make_string_substream(stream, &substream))
         return false;
     
     if (field->ptr == NULL)
-        PB_RETURN_ERROR(stream, "invalid field descriptor");
+        return false;
     
-    /* New array entries need to be initialized, while required and optional
+    status = pb_decode(&substream, (pb_field_info_t*)field->ptr, dest);
-     * submessages have already been initialized in the top-level pb_decode. */
+    stream->state = substream.state;
-    if (PB_HTYPE(field->type) == PB_HTYPE_ARRAY)
-        status = pb_decode(&substream, submsg_fields, dest);
-    else
-        status = pb_decode_noinit(&substream, submsg_fields, dest);
-    
-    pb_close_string_substream(stream, &substream);
     return status;
 }

pb_decode.h

@@ -3,7 +3,7 @@
 
 /* pb_decode.h: Functions to decode protocol buffers. Depends on pb_decode.c.
  * The main function is pb_decode. You will also need to create an input
- * stream, which is easiest to do with pb_istream_from_buffer().
+ * stream, which is easiest to do with pb_istream_t.
  * 
  * You also need structures and their corresponding pb_field_t descriptions.
  * These are usually generated from .proto-files with a script.
@@ -12,10 +12,6 @@
 #include <stdbool.h>
 #include "pb.h"
 
-#ifdef __cplusplus
-extern "C" {
-#endif
-
 /* Lightweight input stream.
  * You can provide a callback function for reading or use
  * pb_istream_from_buffer.
@@ -23,31 +19,20 @@ extern "C" {
  * Rules for callback:
  * 1) Return false on IO errors. This will cause decoding to abort.
  * 
- * 2) You can use state to store your own data (e.g. buffer pointer),
+ * 2) If buf is NULL, read but don't store bytes ("skip input").
+ * 
+ * 3) You can use state to store your own data (e.g. buffer pointer),
  * and rely on pb_read to verify that no-body reads past bytes_left.
  * 
- * 3) Your callback may be used with substreams, in which case bytes_left
+ * 4) Your callback may be used with substreams, in which case bytes_left
  * is different than from the main stream. Don't use bytes_left to compute
  * any pointers.
  */
 struct _pb_istream_t
 {
-#ifdef PB_BUFFER_ONLY
-    /* Callback pointer is not used in buffer-only configuration.
-     * Having an int pointer here allows binary compatibility but
-     * gives an error if someone tries to assign callback function.
-     */
-    int *callback;
-#else
     bool (*callback)(pb_istream_t *stream, uint8_t *buf, size_t count);
-#endif
-
     void *state; /* Free field for use by callback implementation */
     size_t bytes_left;
-    
-#ifndef PB_NO_ERRMSG
-    const char *errmsg;
-#endif
 };
 
 pb_istream_t pb_istream_from_buffer(uint8_t *buf, size_t bufsize);
@@ -57,51 +42,23 @@ bool pb_read(pb_istream_t *stream, uint8_t *buf, size_t count);
  * Returns true on success, false on any failure.
  * The actual struct pointed to by dest must match the description in fields.
  */
-bool pb_decode(pb_istream_t *stream, const pb_field_t fields[], void *dest_struct);
+bool pb_decode(pb_istream_t *stream, const pb_field_info_t *fields, void *dest_struct);
-
-/* Same as pb_decode, except does not initialize the destination structure
- * to default values. This is slightly faster if you need no default values
- * and just do memset(struct, 0, sizeof(struct)) yourself.
- */
-bool pb_decode_noinit(pb_istream_t *stream, const pb_field_t fields[], void *dest_struct);
 
 /* --- Helper functions ---
  * You may want to use these from your caller or callbacks.
  */
 
-/* Decode the tag for the next field in the stream. Gives the wire type and
- * field tag. At end of the message, returns false and sets eof to true. */
-bool pb_decode_tag(pb_istream_t *stream, pb_wire_type_t *wire_type, uint32_t *tag, bool *eof);
-
-/* Skip the field payload data, given the wire type. */
-bool pb_skip_field(pb_istream_t *stream, pb_wire_type_t wire_type);
-
-/* Decode an integer in the varint format. This works for bool, enum, int32,
- * int64, uint32 and uint64 field types. */
 bool pb_decode_varint(pb_istream_t *stream, uint64_t *dest);
 
-/* Decode an integer in the zig-zagged svarint format. This works for sint32
+bool pb_skip_varint(pb_istream_t *stream);
- * and sint64. */
+bool pb_skip_string(pb_istream_t *stream);
-bool pb_decode_svarint(pb_istream_t *stream, int64_t *dest);
 
-/* Decode a fixed32, sfixed32 or float value. You need to pass a pointer to
+/* --- Field decoders ---
- * a 4-byte wide C variable. */
+ * Each decoder takes stream and field description, and a pointer to the field
-bool pb_decode_fixed32(pb_istream_t *stream, void *dest);
+ * in the destination struct (dest = struct_addr + field->data_offset).
-
+ * For arrays, these functions are called repeatedly.
-/* Decode a fixed64, sfixed64 or double value. You need to pass a pointer to
- * a 8-byte wide C variable. */
-bool pb_decode_fixed64(pb_istream_t *stream, void *dest);
-
-/* Make a limited-length substream for reading a PB_WT_STRING field. */
-bool pb_make_string_substream(pb_istream_t *stream, pb_istream_t *substream);
-void pb_close_string_substream(pb_istream_t *stream, pb_istream_t *substream);
-
-/* --- Internal functions ---
- * These functions are not terribly useful for the average library user, but
- * are exported to make the unit testing and extending nanopb easier.
  */
 
-#ifdef NANOPB_INTERNALS
 bool pb_dec_varint(pb_istream_t *stream, const pb_field_t *field, void *dest);
 bool pb_dec_svarint(pb_istream_t *stream, const pb_field_t *field, void *dest);
 bool pb_dec_fixed32(pb_istream_t *stream, const pb_field_t *field, void *dest);
@@ -111,12 +68,6 @@ bool pb_dec_bytes(pb_istream_t *stream, const pb_field_t *field, void *dest);
 bool pb_dec_string(pb_istream_t *stream, const pb_field_t *field, void *dest);
 bool pb_dec_submessage(pb_istream_t *stream, const pb_field_t *field, void *dest);
 
-bool pb_skip_varint(pb_istream_t *stream);
+#define PB_ISTREAM_INIT {0,0,0}
-bool pb_skip_string(pb_istream_t *stream);
-#endif
-
-#ifdef __cplusplus
-} /* extern "C" */
-#endif
 
 #endif

pb_encode.c

@@ -3,19 +3,18 @@
  * 2011 Petteri Aimonen <jpa@kapsi.fi>
  */
 
-#define NANOPB_INTERNALS
 #include "pb.h"
 #include "pb_encode.h"
 #include <string.h>
 
-/* The warn_unused_result attribute appeared first in gcc-3.4.0 */
+#ifdef __GNUC__
-#if !defined(__GNUC__) || ( __GNUC__ < 3) || (__GNUC__ == 3 && __GNUC_MINOR__ < 4)
+/* Verify that we remember to check all return values for proper error propagation */
-    #define checkreturn
+#define checkreturn __attribute__((warn_unused_result))
 #else
-    /* Verify that we remember to check all return values for proper error propagation */
+#define checkreturn
-    #define checkreturn __attribute__((warn_unused_result))
 #endif
 
+
 typedef bool (*pb_encoder_t)(pb_ostream_t *stream, const pb_field_t *field, const void *src) checkreturn;
 
 /* --- Function pointers to field encoders ---
@@ -37,22 +36,15 @@ static const pb_encoder_t PB_ENCODERS[PB_LTYPES_COUNT] = {
 static bool checkreturn buf_write(pb_ostream_t *stream, const uint8_t *buf, size_t count)
 {
     uint8_t *dest = (uint8_t*)stream->state;
+    memcpy(dest, buf, count);
     stream->state = dest + count;
-    
-    while (count--)
-        *dest++ = *buf++;
-    
     return true;
 }
 
 pb_ostream_t pb_ostream_from_buffer(uint8_t *buf, size_t bufsize)
 {
     pb_ostream_t stream;
-#ifdef PB_BUFFER_ONLY
-    stream.callback = (void*)1; /* Just some marker value */
-#else
     stream.callback = &buf_write;
-#endif
     stream.state = buf;
     stream.max_size = bufsize;
     stream.bytes_written = 0;
@@ -65,14 +57,9 @@ bool checkreturn pb_write(pb_ostream_t *stream, const uint8_t *buf, size_t count
     {
         if (stream->bytes_written + count > stream->max_size)
             return false;
-
+        
-#ifdef PB_BUFFER_ONLY
-        if (!buf_write(stream, buf, count))
-            return false;
-#else        
         if (!stream->callback(stream, buf, count))
             return false;
-#endif
     }
     
     stream->bytes_written += count;
@@ -111,7 +98,7 @@ static bool checkreturn encode_array(pb_ostream_t *stream, const pb_field_t *fie
         }
         else
         {
-            pb_ostream_t sizestream = {0,0,0,0};
+            pb_ostream_t sizestream = PB_OSTREAM_INIT;
             p = pData;
             for (i = 0; i < count; i++)
             {
@@ -122,7 +109,7 @@ static bool checkreturn encode_array(pb_ostream_t *stream, const pb_field_t *fie
             size = sizestream.bytes_written;
         }
         
-        if (!pb_encode_varint(stream, (uint64_t)size))
+        if (!pb_encode_varint(stream, size))
             return false;
         
         if (stream->callback == NULL)
@@ -153,15 +140,19 @@ static bool checkreturn encode_array(pb_ostream_t *stream, const pb_field_t *fie
     return true;
 }
 
-bool checkreturn pb_encode(pb_ostream_t *stream, const pb_field_t fields[], const void *src_struct)
+bool checkreturn pb_encode(pb_ostream_t *stream, const pb_field_info_t *fields, const void *src_struct)
 {
-    const pb_field_t *field = fields;
+    const pb_field_t *field;
+    const pb_field_key_t *field_key = fields->field_keys;
     const void *pData = src_struct;
     const void *pSize;
     size_t prev_size = 0;
     
-    while (field->tag != 0)
+    while(field_key != NULL)
     {
+        pb_field_t f = *(PB_FIELD_INFO(field_key, fields->field_info));
+        f.tag = PB_TAG_VAL(field_key);
+        field = &f;
         pb_encoder_t func = PB_ENCODERS[PB_LTYPE(field->type)];
         pData = (const char*)pData + prev_size + field->data_offset;
         pSize = (const char*)pData + field->size_offset;
@@ -180,7 +171,7 @@ bool checkreturn pb_encode(pb_ostream_t *stream, const pb_field_t fields[], cons
                 break;
             
             case PB_HTYPE_OPTIONAL:
-                if (*(const bool*)pSize)
+                if (*(bool*)pSize)
                 {
                     if (!pb_encode_tag_for_field(stream, field))
                         return false;
@@ -191,13 +182,13 @@ bool checkreturn pb_encode(pb_ostream_t *stream, const pb_field_t fields[], cons
                 break;
             
             case PB_HTYPE_ARRAY:
-                if (!encode_array(stream, field, pData, *(const size_t*)pSize, func))
+                if (!encode_array(stream, field, pData, *(size_t*)pSize, func))
                     return false;
                 break;
             
             case PB_HTYPE_CALLBACK:
             {
-                const pb_callback_t *callback = (const pb_callback_t*)pData;
+                pb_callback_t *callback = (pb_callback_t*)pData;
                 if (callback->funcs.encode != NULL)
                 {
                     if (!callback->funcs.encode(stream, field, callback->arg))
@@ -206,25 +197,32 @@ bool checkreturn pb_encode(pb_ostream_t *stream, const pb_field_t fields[], cons
                 break;
             }
         }
-    
+        if (PB_IS_LAST(field_key++)) break;
-        field++;
     }
     
     return true;
 }
 
+int checkreturn pb_get_message_size(const pb_field_info_t *fields, const void *src_struct)
+{
+    pb_ostream_t ostream = PB_OSTREAM_INIT;
+    if (pb_encode(&ostream, fields, src_struct))
+        return ostream.bytes_written;
+    return -1;
+}
+
 /* Helper functions */
 bool checkreturn pb_encode_varint(pb_ostream_t *stream, uint64_t value)
 {
     uint8_t buffer[10];
-    size_t i = 0;
+    int i = 0;
     
     if (value == 0)
         return pb_write(stream, (uint8_t*)&value, 1);
     
     while (value)
     {
-        buffer[i] = (uint8_t)((value & 0x7F) | 0x80);
+        buffer[i] = (value & 0x7F) | 0x80;
         value >>= 7;
         i++;
     }
@@ -233,54 +231,9 @@ bool checkreturn pb_encode_varint(pb_ostream_t *stream, uint64_t value)
     return pb_write(stream, buffer, i);
 }
 
-bool checkreturn pb_encode_svarint(pb_ostream_t *stream, int64_t value)
+bool checkreturn pb_encode_tag(pb_ostream_t *stream, pb_wire_type_t wiretype, int field_number)
 {
-    uint64_t zigzagged;
+    int tag = wiretype | (field_number << 3);
-    if (value < 0)
-        zigzagged = (uint64_t)(~(value << 1));
-    else
-        zigzagged = (uint64_t)(value << 1);
-    
-    return pb_encode_varint(stream, zigzagged);
-}
-
-bool checkreturn pb_encode_fixed32(pb_ostream_t *stream, const void *value)
-{
-    #ifdef __BIG_ENDIAN__
-    const uint8_t *bytes = value;
-    uint8_t lebytes[4];
-    lebytes[0] = bytes[3];
-    lebytes[1] = bytes[2];
-    lebytes[2] = bytes[1];
-    lebytes[3] = bytes[0];
-    return pb_write(stream, lebytes, 4);
-    #else
-    return pb_write(stream, (const uint8_t*)value, 4);
-    #endif
-}
-
-bool checkreturn pb_encode_fixed64(pb_ostream_t *stream, const void *value)
-{
-    #ifdef __BIG_ENDIAN__
-    const uint8_t *bytes = value;
-    uint8_t lebytes[8];
-    lebytes[0] = bytes[7];
-    lebytes[1] = bytes[6];
-    lebytes[2] = bytes[5];
-    lebytes[3] = bytes[4];
-    lebytes[4] = bytes[3];
-    lebytes[5] = bytes[2];
-    lebytes[6] = bytes[1];
-    lebytes[7] = bytes[0];
-    return pb_write(stream, lebytes, 8);
-    #else
-    return pb_write(stream, (const uint8_t*)value, 8);
-    #endif
-}
-
-bool checkreturn pb_encode_tag(pb_ostream_t *stream, pb_wire_type_t wiretype, uint32_t field_number)
-{
-    uint64_t tag = wiretype | (field_number << 3);
     return pb_encode_varint(stream, tag);
 }
 
@@ -317,25 +270,105 @@ bool checkreturn pb_encode_tag_for_field(pb_ostream_t *stream, const pb_field_t
 
 bool checkreturn pb_encode_string(pb_ostream_t *stream, const uint8_t *buffer, size_t size)
 {
-    if (!pb_encode_varint(stream, (uint64_t)size))
+    if (!pb_encode_varint(stream, size))
         return false;
     
     return pb_write(stream, buffer, size);
 }
 
-bool checkreturn pb_encode_submessage(pb_ostream_t *stream, const pb_field_t fields[], const void *src_struct)
+/* Field encoders */
+
+/* Copy srcsize bytes from src so that values are casted properly.
+ * On little endian machine, copy to start of dest
+ * On big endian machine, copy to end of dest
+ * destsize must always be larger than srcsize
+ * 
+ * Note: This is the reverse of the endian_copy in pb_decode.c.
+ */
+static void endian_copy(void *dest, const void *src, size_t destsize, size_t srcsize)
 {
-    /* First calculate the message size using a non-writing substream. */
+#ifdef __BIG_ENDIAN__
-    pb_ostream_t substream = {0,0,0,0};
+    memcpy((char*)dest + (destsize - srcsize), src, srcsize);
+#else
+    memcpy(dest, src, srcsize);
+#endif
+}
+
+bool checkreturn pb_enc_varint(pb_ostream_t *stream, const pb_field_t *field, const void *src)
+{
+    uint64_t value = 0;
+    endian_copy(&value, src, sizeof(value), field->data_size);
+    return pb_encode_varint(stream, value);
+}
+
+bool checkreturn pb_enc_svarint(pb_ostream_t *stream, const pb_field_t *field, const void *src)
+{
+    uint64_t value = 0;
+    uint64_t zigzagged;
+    uint64_t signbitmask, xormask;
+    endian_copy(&value, src, sizeof(value), field->data_size);
+    
+    signbitmask = (uint64_t)0x80 << (field->data_size * 8 - 8);
+    xormask = ((uint64_t)-1) >> (64 - field->data_size * 8);
+    if (value & signbitmask)
+        zigzagged = ((value ^ xormask) << 1) | 1;
+    else
+        zigzagged = value << 1;
+    
+    return pb_encode_varint(stream, zigzagged);
+}
+
+bool checkreturn pb_enc_fixed64(pb_ostream_t *stream, const pb_field_t *field, const void *src)
+{
+    #ifdef __BIG_ENDIAN__
+    uint8_t bytes[8] = {0};
+    memcpy(bytes, src, 8);
+    uint8_t lebytes[8] = {bytes[7], bytes[6], bytes[5], bytes[4], 
+                          bytes[3], bytes[2], bytes[1], bytes[0]};
+    return pb_write(stream, lebytes, 8);
+    #else
+    return pb_write(stream, (uint8_t*)src, 8);
+    #endif
+}
+
+bool checkreturn pb_enc_fixed32(pb_ostream_t *stream, const pb_field_t *field, const void *src)
+{
+    #ifdef __BIG_ENDIAN__
+    uint8_t bytes[4] = {0};
+    memcpy(bytes, src, 4);
+    uint8_t lebytes[4] = {bytes[3], bytes[2], bytes[1], bytes[0]};
+    return pb_write(stream, lebytes, 4);
+    #else
+    return pb_write(stream, (uint8_t*)src, 4);
+    #endif
+}
+
+bool checkreturn pb_enc_bytes(pb_ostream_t *stream, const pb_field_t *field, const void *src)
+{
+    pb_bytes_array_t *bytes = (pb_bytes_array_t*)src;
+    return pb_encode_string(stream, bytes->bytes, bytes->size);
+}
+
+bool checkreturn pb_enc_string(pb_ostream_t *stream, const pb_field_t *field, const void *src)
+{
+    return pb_encode_string(stream, (uint8_t*)src, strlen((char*)src));
+}
+
+bool checkreturn pb_enc_submessage(pb_ostream_t *stream, const pb_field_t *field, const void *src)
+{
+    pb_ostream_t substream = {0, 0, 0, 0};
     size_t size;
     bool status;
     
-    if (!pb_encode(&substream, fields, src_struct))
+    if (field->ptr == NULL)
+        return false;
+    
+    if (!pb_encode(&substream, (pb_field_info_t*)field->ptr, src))
         return false;
     
     size = substream.bytes_written;
     
-    if (!pb_encode_varint(stream, (uint64_t)size))
+    if (!pb_encode_varint(stream, size))
         return false;
     
     if (stream->callback == NULL)
@@ -351,7 +384,7 @@ bool checkreturn pb_encode_submessage(pb_ostream_t *stream, const pb_field_t fie
     substream.max_size = size;
     substream.bytes_written = 0;
     
-    status = pb_encode(&substream, fields, src_struct);
+    status = pb_encode(&substream, (pb_field_info_t*)field->ptr, src);
     
     stream->bytes_written += substream.bytes_written;
     stream->state = substream.state;
@@ -362,68 +395,3 @@ bool checkreturn pb_encode_submessage(pb_ostream_t *stream, const pb_field_t fie
     return status;
 }
 
-/* Field encoders */
-
-bool checkreturn pb_enc_varint(pb_ostream_t *stream, const pb_field_t *field, const void *src)
-{
-    uint64_t value = 0;
-    
-    switch (field->data_size)
-    {
-        case 1: value = *(const uint8_t*)src; break;
-        case 2: value = *(const uint16_t*)src; break;
-        case 4: value = *(const uint32_t*)src; break;
-        case 8: value = *(const uint64_t*)src; break;
-        default: return false;
-    }
-    
-    return pb_encode_varint(stream, value);
-}
-
-bool checkreturn pb_enc_svarint(pb_ostream_t *stream, const pb_field_t *field, const void *src)
-{
-    int64_t value = 0;
-    
-    switch (field->data_size)
-    {
-        case 4: value = *(const int32_t*)src; break;
-        case 8: value = *(const int64_t*)src; break;
-        default: return false;
-    }
-    
-    return pb_encode_svarint(stream, value);
-}
-
-bool checkreturn pb_enc_fixed64(pb_ostream_t *stream, const pb_field_t *field, const void *src)
-{
-    UNUSED(field);
-    return pb_encode_fixed64(stream, src);
-}
-
-bool checkreturn pb_enc_fixed32(pb_ostream_t *stream, const pb_field_t *field, const void *src)
-{
-    UNUSED(field);
-    return pb_encode_fixed32(stream, src);
-}
-
-bool checkreturn pb_enc_bytes(pb_ostream_t *stream, const pb_field_t *field, const void *src)
-{
-    const pb_bytes_array_t *bytes = (const pb_bytes_array_t*)src;
-    UNUSED(field);
-    return pb_encode_string(stream, bytes->bytes, bytes->size);
-}
-
-bool checkreturn pb_enc_string(pb_ostream_t *stream, const pb_field_t *field, const void *src)
-{
-    UNUSED(field);
-    return pb_encode_string(stream, (const uint8_t*)src, strlen((const char*)src));
-}
-
-bool checkreturn pb_enc_submessage(pb_ostream_t *stream, const pb_field_t *field, const void *src)
-{
-    if (field->ptr == NULL)
-        return false;
-    
-    return pb_encode_submessage(stream, (const pb_field_t*)field->ptr, src);
-}
-

pb_encode.h

@@ -9,10 +9,6 @@
 #include <stdbool.h>
 #include "pb.h"
 
-#ifdef __cplusplus
-extern "C" {
-#endif
-
 /* Lightweight output stream.
  * You can provide callback for writing or use pb_ostream_from_buffer.
  * 
@@ -32,17 +28,7 @@ extern "C" {
  */
 struct _pb_ostream_t
 {
-#ifdef PB_BUFFER_ONLY
-    /* Callback pointer is not used in buffer-only configuration.
-     * Having an int pointer here allows binary compatibility but
-     * gives an error if someone tries to assign callback function.
-     * Also, NULL pointer marks a 'sizing stream' that does not
-     * write anything.
-     */
-    int *callback;
-#else
     bool (*callback)(pb_ostream_t *stream, const uint8_t *buf, size_t count);
-#endif
     void *state; /* Free field for use by callback implementation */
     size_t max_size; /* Limit number of output bytes written (or use SIZE_MAX). */
     size_t bytes_written;
@@ -56,65 +42,34 @@ bool pb_write(pb_ostream_t *stream, const uint8_t *buf, size_t count);
  * The actual struct pointed to by src_struct must match the description in fields.
  * All required fields in the struct are assumed to have been filled in.
  */
-bool pb_encode(pb_ostream_t *stream, const pb_field_t fields[], const void *src_struct);
+bool pb_encode(pb_ostream_t *stream, const pb_field_info_t *fields, const void *src_struct);
+
+int pb_get_message_size(const pb_field_info_t *fields, const void *src_struct);
 
 /* --- Helper functions ---
  * You may want to use these from your caller or callbacks.
  */
 
-/* Encode field header based on LTYPE and field number defined in the field structure.
- * Call this from the callback before writing out field contents. */
-bool pb_encode_tag_for_field(pb_ostream_t *stream, const pb_field_t *field);
-
-/* Encode field header by manually specifing wire type. You need to use this if
- * you want to write out packed arrays from a callback field. */
-bool pb_encode_tag(pb_ostream_t *stream, pb_wire_type_t wiretype, uint32_t field_number);
-
-/* Encode an integer in the varint format.
- * This works for bool, enum, int32, int64, uint32 and uint64 field types. */
 bool pb_encode_varint(pb_ostream_t *stream, uint64_t value);
-
+bool pb_encode_tag(pb_ostream_t *stream, pb_wire_type_t wiretype, int field_number);
-/* Encode an integer in the zig-zagged svarint format.
+/* Encode tag based on LTYPE and field number defined in the field structure. */
- * This works for sint32 and sint64. */
+bool pb_encode_tag_for_field(pb_ostream_t *stream, const pb_field_t *field);
-bool pb_encode_svarint(pb_ostream_t *stream, int64_t value);
+/* Write length as varint and then the contents of buffer. */
-
-/* Encode a string or bytes type field. For strings, pass strlen(s) as size. */
 bool pb_encode_string(pb_ostream_t *stream, const uint8_t *buffer, size_t size);
 
-/* Encode a fixed32, sfixed32 or float value.
+/* --- Field encoders ---
- * You need to pass a pointer to a 4-byte wide C variable. */
+ * Each encoder writes the content for the field.
-bool pb_encode_fixed32(pb_ostream_t *stream, const void *value);
+ * The tag/wire type has been written already.
-
-/* Encode a fixed64, sfixed64 or double value.
- * You need to pass a pointer to a 8-byte wide C variable. */
-bool pb_encode_fixed64(pb_ostream_t *stream, const void *value);
-
-/* Encode a submessage field.
- * You need to pass the pb_field_t array and pointer to struct, just like with pb_encode().
- * This internally encodes the submessage twice, first to calculate message size and then to actually write it out.
- */
-bool pb_encode_submessage(pb_ostream_t *stream, const pb_field_t fields[], const void *src_struct);
-
-/* --- Internal functions ---
- * These functions are not terribly useful for the average library user, but
- * are exported to make the unit testing and extending nanopb easier.
  */
 
-#ifdef NANOPB_INTERNALS
 bool pb_enc_varint(pb_ostream_t *stream, const pb_field_t *field, const void *src);
 bool pb_enc_svarint(pb_ostream_t *stream, const pb_field_t *field, const void *src);
 bool pb_enc_fixed32(pb_ostream_t *stream, const pb_field_t *field, const void *src);
 bool pb_enc_fixed64(pb_ostream_t *stream, const pb_field_t *field, const void *src);
+
 bool pb_enc_bytes(pb_ostream_t *stream, const pb_field_t *field, const void *src);
 bool pb_enc_string(pb_ostream_t *stream, const pb_field_t *field, const void *src);
-#endif
-
-/* This function is not recommended for new programs. Use pb_encode_submessage()
- * instead, it has the same functionality with a less confusing interface. */
 bool pb_enc_submessage(pb_ostream_t *stream, const pb_field_t *field, const void *src);
 
-#ifdef __cplusplus
+#define PB_OSTREAM_INIT {0,0,0,0}
-} /* extern "C" */
-#endif
-
 #endif

pb_field.c

@@ -0,0 +1,98 @@
+#include "pb_field.h"
+
+#ifdef __GNUC__
+/* Verify that we remember to check all return values for proper error propagation */
+#define checkreturn __attribute__((warn_unused_result))
+#else
+#define checkreturn
+#endif
+
+/**
+ * pb_common_aligned_field_info array holds the common field info that can be shared
+ * by any numeric fields whose previous field is memory aligned
+ */
+const pb_field_t pb_common_aligned_field_info[NUM_COMMON_FIELD_INFO] = {
+	/* REQUIRED bool */
+    {0, PB_HTYPE_REQUIRED | PB_LTYPE_VARINT, 0, 0, sizeof(bool), 0, 0},
+    /* OPTIONAL bool */
+    {0, PB_HTYPE_OPTIONAL | PB_LTYPE_VARINT, 1, -1, sizeof(bool), 0, 0},
+	/* REQUIRED int32, uint32, enum */
+    {0, PB_HTYPE_REQUIRED | PB_LTYPE_VARINT, 0, 0, sizeof(uint32_t), 0, 0},
+    /* OPTIONAL int32, uint32, enum */
+    {0, PB_HTYPE_OPTIONAL | PB_LTYPE_VARINT, 4, -4, sizeof(uint32_t), 0, 0},
+	/* REQUIRED int64, uint64 */
+    {0, PB_HTYPE_REQUIRED | PB_LTYPE_VARINT, 0, 0, sizeof(uint64_t), 0, 0},
+    /* OPTIONAL int64, uint64 */
+    {0, PB_HTYPE_OPTIONAL | PB_LTYPE_VARINT, 4, -4, sizeof(uint64_t), 0, 0},
+    /* REQUIRED sint32 */
+    {0, PB_HTYPE_REQUIRED | PB_LTYPE_SVARINT, 0, 0, sizeof(int32_t), 0, 0},
+    /* OPTIONAL sint32 */
+    {0, PB_HTYPE_OPTIONAL | PB_LTYPE_SVARINT, 4, -4, sizeof(int32_t), 0, 0},
+    /* REQUIRED sint64 */
+    {0, PB_HTYPE_REQUIRED | PB_LTYPE_SVARINT, 0, 0, sizeof(int64_t), 0, 0},
+    /* OPTIONAL sint64 */
+    {0, PB_HTYPE_OPTIONAL | PB_LTYPE_SVARINT, 4, -4, sizeof(int64_t), 0, 0},
+    /* REQUIRED fixed32, sfixed32, float */
+    {0, PB_HTYPE_REQUIRED | PB_LTYPE_FIXED32, 0, 0, sizeof(uint32_t), 0, 0},
+    /* OPTIONAL fixed32, sfixed32, float */
+    {0, PB_HTYPE_OPTIONAL | PB_LTYPE_FIXED32, 4, -4, sizeof(uint32_t), 0, 0},
+    /* REQUIRED fixed64, sfixed64, double */
+    {0, PB_HTYPE_REQUIRED | PB_LTYPE_FIXED64, 0, 0, sizeof(uint64_t), 0, 0},
+    /* OPTIONAL fixed64, sfixed64, double */
+    {0, PB_HTYPE_OPTIONAL | PB_LTYPE_FIXED64, 4, -4, sizeof(uint64_t), 0, 0}
+};
+
+void pb_field_init(pb_field_iterator_t *iter, const pb_field_info_t *fields, void *dest_struct)
+{
+    if (fields->field_keys == NULL) return;
+    iter->start_key = iter->current_key = fields->field_keys;
+    iter->field_info = fields->field_info;
+    iter->current = *(PB_FIELD_INFO(iter->current_key, iter->field_info));
+    iter->current.tag = PB_TAG_VAL(iter->current_key);
+    iter->field_index = 0;
+    iter->pData = (char*)dest_struct + iter->current.data_offset;
+    iter->pSize = (char*)iter->pData + iter->current.size_offset;
+    iter->dest_struct = dest_struct;
+}
+
+bool pb_field_next(pb_field_iterator_t *iter)
+{
+    bool notwrapped = true;
+    size_t prev_size = iter->current.data_size;
+
+    if (PB_HTYPE(iter->current.type) == PB_HTYPE_ARRAY)
+        prev_size *= iter->current.array_size;
+
+    iter->field_index++;
+    if (PB_IS_LAST(iter->current_key))
+    {
+        iter->current_key = iter->start_key;
+        iter->current = *(PB_FIELD_INFO(iter->current_key, iter->field_info));
+        iter->current.tag = PB_TAG_VAL(iter->current_key);
+        iter->field_index = 0;
+        iter->pData = iter->dest_struct;
+        prev_size = 0;
+        notwrapped = false;
+    } else {
+        iter->current_key++;
+        iter->current = *(PB_FIELD_INFO(iter->current_key, iter->field_info));
+        iter->current.tag = PB_TAG_VAL(iter->current_key);
+    }
+
+    iter->pData = (char*)iter->pData + prev_size + iter->current.data_offset;
+    iter->pSize = (char*)iter->pData + iter->current.size_offset;
+    return notwrapped;
+}
+
+bool checkreturn pb_field_find(pb_field_iterator_t *iter, int tag)
+{
+    int start = iter->field_index;
+
+    do {
+        if (iter->current.tag == tag)
+            return true;
+        pb_field_next(iter);
+    } while (iter->field_index != start);
+
+    return false;
+}

pb_field.h

@@ -0,0 +1,211 @@
+#ifndef _PB_FIELD_H_
+#define _PB_FIELD_H_
+
+#include <stdint.h>
+#include <stddef.h>
+#include <stdbool.h>
+
+
+#ifdef __GNUC__
+/* This just reduces memory requirements, but is not required. */
+#define pb_packed __attribute__((packed))
+#else
+#define pb_packed
+#endif
+
+/* List of possible field types. These are used in the autogenerated code.
+ * Least-significant 4 bits tell the scalar type
+ * Most-significant 4 bits specify repeated/required/packed etc.
+ *
+ * INT32 and UINT32 are treated the same, as are (U)INT64 and (S)FIXED*
+ * These types are simply casted to correct field type when they are
+ * assigned to the memory pointer.
+ * SINT* is different, though, because it is zig-zag coded.
+ */
+
+typedef enum {
+    /************************
+     * Field contents types *
+     ************************/
+
+    /* Numeric types */
+    PB_LTYPE_VARINT = 0x00, /* int32, uint32, int64, uint64, bool, enum */
+    PB_LTYPE_SVARINT = 0x01, /* sint32, sint64 */
+    PB_LTYPE_FIXED32 = 0x02, /* fixed32, sfixed32, float */
+    PB_LTYPE_FIXED64 = 0x03, /* fixed64, sfixed64, double */
+
+    /* Marker for last packable field type. */
+    PB_LTYPE_LAST_PACKABLE = 0x03,
+
+    /* Byte array with pre-allocated buffer.
+     * data_size is the length of the allocated PB_BYTES_ARRAY structure. */
+    PB_LTYPE_BYTES = 0x04,
+
+    /* String with pre-allocated buffer.
+     * data_size is the maximum length. */
+    PB_LTYPE_STRING = 0x05,
+
+    /* Submessage
+     * submsg_fields is pointer to field descriptions */
+    PB_LTYPE_SUBMESSAGE = 0x06,
+
+    /* Number of declared LTYPES */
+    PB_LTYPES_COUNT = 7,
+
+    /******************
+     * Modifier flags *
+     ******************/
+
+    /* Just the basic, write data at data_offset */
+    PB_HTYPE_REQUIRED = 0x00,
+
+    /* Write true at size_offset */
+    PB_HTYPE_OPTIONAL = 0x10,
+
+    /* Read to pre-allocated array
+     * Maximum number of entries is array_size,
+     * actual number is stored at size_offset */
+    PB_HTYPE_ARRAY = 0x20,
+
+    /* Works for all required/optional/repeated fields.
+     * data_offset points to pb_callback_t structure.
+     * LTYPE should be 0 (it is ignored, but sometimes
+     * used to speculatively index an array). */
+    PB_HTYPE_CALLBACK = 0x30
+
+} pb_packed pb_type_t;
+
+#define PB_HTYPE(x) ((x) & 0xF0)
+#define PB_LTYPE(x) ((x) & 0x0F)
+
+/* This structure is used for 'bytes' arrays.
+ * It has the number of bytes in the beginning, and after that an array.
+ * Note that actual structs used will have a different length of bytes array.
+ */
+typedef struct {
+    size_t size;
+    uint8_t bytes[1];
+} pb_bytes_array_t;
+
+/* The next three pb_field_ structures are used in auto-generated constants
+ * to specify struct fields.
+ */
+
+typedef struct _pb_field_key_t pb_field_key_t;
+typedef struct _pb_field_t pb_field_t;
+typedef struct _pb_field_info_t pb_field_info_t;
+/* pb_field_key_t is a structure for storing the tag and an index into an array
+ * that stores the actual field info. This approach is used to reduce code size
+ * as many numeric fields have the same field info.
+ *
+ * A uint8_t tag will limit the field tag to 128 as the MSB bit is used to indicate
+ * whether or not it's the last field in the message. You may change it to uint16_t
+ * if you want to specify larger field tag. Please also change the corresponding
+ * tag in pb_field_t
+ */
+typedef uint8_t tag_t;
+struct _pb_field_key_t {
+    tag_t tag;     /* The MSB bit of the tag is used to indicate it's the last field in the message */
+    /* The MSB bit of the info_index is used to indicate the field info is retrieved
+     * from the global pb_common_aligned_field_info array instead of the auto-generated field
+     * info.
+     */
+    uint8_t info_index;
+} pb_packed;
+
+/* pb_field_t is a structure for storing the pb field descriptor information
+ * You can change field sizes here if you need structures
+ * larger than 256 bytes
+ */
+struct _pb_field_t {
+    tag_t tag;
+    pb_type_t type;
+    uint8_t data_offset; /* Offset of field data, relative to previous field. */
+    int8_t size_offset; /* Offset of array size or has-boolean, relative to data */
+    uint8_t data_size; /* Data size in bytes for a single item */
+    uint8_t array_size; /* Maximum number of entries in array */
+
+    /* Field definitions for submessage
+     * OR default value for all other non-array, non-callback types
+     * If null, then field will zeroed. */
+    const void *ptr;
+} pb_packed;
+
+/* pb_field_info_t is the structure for holding together the key and the field info arrays.
+ * This is the structure that will be passed to pb_encode and pb_decode
+ */
+struct _pb_field_info_t {
+    const pb_field_key_t *field_keys;
+    const pb_field_t *field_info;
+};
+
+/* Iterator for pb_field_t list */
+typedef struct {
+    const pb_field_key_t *start_key;
+    const pb_field_key_t *current_key;
+    pb_field_t current;
+    const pb_field_t *field_info;
+    int field_index;
+    void *dest_struct;
+    void *pData;
+    void *pSize;
+} pb_field_iterator_t;
+
+/* Functions for iterating through the field */
+void pb_field_init(pb_field_iterator_t *iter, const pb_field_info_t *fields, void *dest_struct);
+bool pb_field_next(pb_field_iterator_t *iter);
+bool pb_field_find(pb_field_iterator_t *iter, int tag);
+
+/* These macros are used to declare pb_field_t's in the constant array. */
+#define pb_membersize(st, m) (sizeof ((st*)0)->m)
+#define pb_arraysize(st, m) (pb_membersize(st, m) / pb_membersize(st, m[0]))
+#define pb_delta(st, m1, m2) ((int)offsetof(st, m1) - (int)offsetof(st, m2))
+#define pb_delta_end(st, m1, m2) (offsetof(st, m1) - offsetof(st, m2) - pb_membersize(st, m2))
+
+/* The MSB bit of the pb_field_key_t.tag indicates whether or not it's the last element */
+#define PB_LAST_FIELD (0x1 << (pb_membersize(pb_field_key_t, tag) * 8 - 1))
+#define PB_IS_LAST(key) ((key)->tag & PB_LAST_FIELD)
+#define PB_TAG_VAL(key) ((key)->tag & ~PB_LAST_FIELD)
+
+/* The MSB bit of the pb_field_key_tag.info_index indicates whether it's a common or generated field info */
+#define PB_COMMON_INFO_FLAG (0x1 << (pb_membersize(pb_field_key_t, info_index) * 8 -1))
+
+/* A common field info is retrieved from the globally declared pb_common_aligned_field_info array or
+ * locally auto-generated field info array */
+#define PB_FIELD_INFO(key, info) (((key)->info_index & PB_COMMON_INFO_FLAG) ? \
+    &pb_common_aligned_field_info[(key)->info_index ^ PB_COMMON_INFO_FLAG] : \
+    &((info)[(key)->info_index]))
+
+/* Defines the indices for pb_common_aligned_field_info array
+ * Note that MSB bit PB_COMMON_INFO_FLAG is set to indicate the index
+ * should be used on pb_common_aligned_field_info instead of generated
+ * array
+ * */
+enum {
+    REQUIRED_BOOL_INFO = 0 | PB_COMMON_INFO_FLAG,
+    OPTIONAL_BOOL_INFO = 1 | PB_COMMON_INFO_FLAG,
+    REQUIRED_INT32_INFO = 2 | PB_COMMON_INFO_FLAG,
+    OPTIONAL_INT32_INFO = 3 | PB_COMMON_INFO_FLAG,
+    REQUIRED_INT64_INFO = 4 | PB_COMMON_INFO_FLAG,
+    OPTIONAL_INT64_INFO = 5 | PB_COMMON_INFO_FLAG,
+    REQUIRED_SINT32_INFO = 6 | PB_COMMON_INFO_FLAG,
+    OPTIONAL_SINT32_INFO = 7 | PB_COMMON_INFO_FLAG,
+    REQUIRED_SINT64_INFO = 8 | PB_COMMON_INFO_FLAG,
+    OPTIONAL_SINT64_INFO = 9 | PB_COMMON_INFO_FLAG,
+    REQUIRED_FIXED32_INFO = 10 | PB_COMMON_INFO_FLAG,
+    OPTIONAL_FIXED32_INFO = 11 | PB_COMMON_INFO_FLAG,
+    REQUIRED_FIXED64_INFO = 12 | PB_COMMON_INFO_FLAG,
+    OPTIONAL_FIXED64_INFO = 13 | PB_COMMON_INFO_FLAG,
+
+    /* leave this enum to determine num of elements */
+    MAX_COMMON_FIELD_INFO
+};
+
+#define NUM_COMMON_FIELD_INFO (MAX_COMMON_FIELD_INFO ^ PB_COMMON_INFO_FLAG)
+
+/* pb_common_aligned_field_info array holds the common field info that can be shared
+ * by any numeric fields whose previous field is memory aligned
+ */
+extern const pb_field_t pb_common_aligned_field_info[NUM_COMMON_FIELD_INFO];
+
+#endif /* _PB_FIELD_H_ */

tests/Makefile

@@ -1,84 +1,50 @@
-CFLAGS=-ansi -Wall -Werror -I .. -g -O0
+CFLAGS=-ansi -Wall -Werror -I .. -g -O0 --coverage
-DEPS=../pb_decode.h ../pb_encode.h ../pb.h person.pb.h \
+LDFLAGS=--coverage
-	callbacks2.pb.h callbacks.pb.h unittests.h unittestproto.pb.h \
+DEPS=../pb_decode.h ../pb_encode.h ../pb.h ../pb_field.h person.pb.h callbacks.pb.h unittests.h unittestproto.pb.h alltypes.pb.h aligntype.pb.h
-	alltypes.pb.h missing_fields.pb.h
+TESTS=test_decode1 test_encode1 test_encode2 test_decode2 test_encode3 test_decode3 test_encode4 test_decode4 decode_unittests encode_unittests test_encode_callbacks test_decode_callbacks
-TESTS=  decode_unittests encode_unittests \
-	test_decode1 test_decode2 test_decode3 test_decode3_buf \
-	test_encode1 test_encode2 test_encode3 test_encode3_buf \
-	test_decode_callbacks test_encode_callbacks \
-	test_missing_fields test_no_messages test_funny_name \
-	test_multiple_files test_cxxcompile test_options \
-	bc_encode bc_decode
 
-# More strict checks for the core part of nanopb
+CC_VER := $(shell gcc --version | grep gcc)
-CC_VERSION=$(shell $(CC) -v 2>&1)
+ifneq "$(CC_VER)" ""
-CFLAGS_CORE=
+CFLAGS += -m32
-ifneq (,$(findstring gcc,$(CC_VERSION)))
+LDFLAGS += -m32
-	CFLAGS_CORE=-pedantic -Wextra -Wcast-qual -Wlogical-op -Wconversion
-        CFLAGS+=--coverage
-        LDFLAGS+=--coverage
 endif
-ifneq (,$(findstring clang,$(CC_VERSION)))
+ifndef PB_PATH
-	CFLAGS_CORE=-pedantic -Wextra -Wcast-qual -Wconversion
+PBPATHOPT=-I/usr/include -I/usr/local/include
+else
+PBPATHOPT=-I$(PB_PATH)
 endif
 
 all: breakpoints $(TESTS) run_unittests
 
 clean:
-	rm -f $(TESTS) person.pb* alltypes.pb* *.o *.gcda *.gcno *.pb.h *.pb.c
+	rm -f breakpoints $(TESTS) *.pb *.pb.c *.pb.h *.o *.gcda *.gcno
-
-%.pb.o: %.pb.c %.pb.h
-	$(CC) $(CFLAGS) $(CFLAGS_CORE) -c -o $@ $<
 
 %.o: %.c
 %.o: %.c $(DEPS)
 	$(CC) $(CFLAGS) -c -o $@ $<
 
 pb_encode.o: ../pb_encode.c $(DEPS)
-	$(CC) $(CFLAGS) $(CFLAGS_CORE) -c -o $@ $<
+	$(CC) $(CFLAGS) -c -o $@ $<
 pb_decode.o: ../pb_decode.c $(DEPS)
-	$(CC) $(CFLAGS) $(CFLAGS_CORE) -c -o $@ $<
+	$(CC) $(CFLAGS) -c -o $@ $<
+pb_field.o: ../pb_field.c $(DEPS)
+	$(CC) $(CFLAGS) -c -o $@ $<
 
-# Test for compilability with c++ compiler
+test_decode1: test_decode1.o pb_decode.o pb_field.o person.pb.o
-
+test_decode2: test_decode2.o pb_decode.o pb_field.o person.pb.o
-pb_encode.cxx.o: ../pb_encode.c $(DEPS)
+test_decode3: test_decode3.o pb_decode.o pb_field.o alltypes.pb.o
-	$(CXX) $(CFLAGS) $(CFLAGS_CORE) -c -o $@ $<
+test_decode4: test_decode4.o pb_decode.o pb_field.o aligntype.pb.o
-pb_decode.cxx.o: ../pb_decode.c $(DEPS)
+test_encode1: test_encode1.o pb_encode.o pb_field.o person.pb.o
-	$(CXX) $(CFLAGS) $(CFLAGS_CORE) -c -o $@ $<
+test_encode2: test_encode2.o pb_encode.o pb_field.o person.pb.o
-
+test_encode3: test_encode3.o pb_encode.o pb_field.o alltypes.pb.o
-# Test for PB_BUF_ONLY compilation option
+test_encode4: test_encode4.o pb_encode.o pb_field.o aligntype.pb.o
-
+test_decode_callbacks: test_decode_callbacks.o pb_decode.o pb_field.o callbacks.pb.o
-pb_encode.buf.o: ../pb_encode.c $(DEPS)
+test_encode_callbacks: test_encode_callbacks.o pb_encode.o pb_field.o callbacks.pb.o
-	$(CC) -DPB_BUFFER_ONLY $(CFLAGS) $(CFLAGS_CORE) -c -o $@ $<
+decode_unittests: decode_unittests.o pb_decode.o pb_field.o unittestproto.pb.o
-pb_decode.buf.o: ../pb_decode.c $(DEPS)
+encode_unittests: encode_unittests.o pb_encode.o pb_field.o unittestproto.pb.o
-	$(CC) -DPB_BUFFER_ONLY $(CFLAGS) $(CFLAGS_CORE) -c -o $@ $<
-%.buf.o: %.c $(DEPS)
-	$(CC) -DPB_BUFFER_ONLY $(CFLAGS) -c -o $@ $<	
-test_encode3_buf: test_encode3.buf.o pb_encode.buf.o alltypes.pb.o
-	$(CC) $(LDFLAGS) $^ -o $@
-test_decode3_buf: test_decode3.buf.o pb_decode.buf.o alltypes.pb.o
-	$(CC) $(LDFLAGS) $^ -o $@
-
-test_cxxcompile: pb_encode.cxx.o pb_decode.cxx.o
-test_decode1: test_decode1.o pb_decode.o person.pb.o
-test_decode2: test_decode2.o pb_decode.o person.pb.o
-test_decode3: test_decode3.o pb_decode.o alltypes.pb.o
-test_encode1: test_encode1.o pb_encode.o person.pb.o
-test_encode2: test_encode2.o pb_encode.o person.pb.o
-test_encode3: test_encode3.o pb_encode.o alltypes.pb.o
-test_multiple_files: test_multiple_files.o pb_encode.o callbacks2.pb.o callbacks.pb.o
-test_decode_callbacks: test_decode_callbacks.o pb_decode.o callbacks.pb.o
-test_encode_callbacks: test_encode_callbacks.o pb_encode.o callbacks.pb.o
-test_missing_fields: test_missing_fields.o pb_encode.o pb_decode.o missing_fields.pb.o
-decode_unittests: decode_unittests.o pb_decode.o unittestproto.pb.o
-encode_unittests: encode_unittests.o pb_encode.o unittestproto.pb.o
-test_no_messages: no_messages.pb.h no_messages.pb.c no_messages.pb.o
-test_funny_name: funny-proto+name.pb.h funny-proto+name.pb.o
-bc_encode: bc_alltypes.pb.o pb_encode.o bc_encode.o
-bc_decode: bc_alltypes.pb.o pb_decode.o bc_decode.o
 
 %.pb: %.proto
-	protoc -I. -I../generator -I/usr/include -o$@ $<
+	protoc -I. -I../generator $(PBPATHOPT) -o$@ $<
 
 %.pb.c %.pb.h: %.pb ../generator/nanopb_generator.py
 	python ../generator/nanopb_generator.py $<
@@ -97,35 +63,22 @@ run_unittests: $(TESTS)
 	./encode_unittests > /dev/null
 	
 	[ "`./test_encode1 | ./test_decode1`" = \
-	"`./test_encode1 | protoc --decode=Person -I. -I../generator -I/usr/include person.proto`" ]
+	"`./test_encode1 | protoc --decode=Person -I. -I../generator $(PBPATHOPT) person.proto`" ]
 
 	[ "`./test_encode2 | ./test_decode1`" = \
-	"`./test_encode2 | protoc --decode=Person -I. -I../generator -I/usr/include person.proto`" ]
+	"`./test_encode2 | protoc --decode=Person -I. -I../generator $(PBPATHOPT) person.proto`" ]
 
 	[ "`./test_encode2 | ./test_decode2`" = \
-	"`./test_encode2 | protoc --decode=Person -I. -I../generator -I/usr/include person.proto`" ]
+	"`./test_encode2 | protoc --decode=Person -I. -I../generator $(PBPATHOPT) person.proto`" ]
-	
-	[ "`./test_decode2 < person_with_extra_field.pb`" = \
-	"`./test_encode2 | ./test_decode2`" ]
 	
 	[ "`./test_encode_callbacks | ./test_decode_callbacks`" = \
 	"`./test_encode_callbacks | protoc --decode=TestMessage callbacks.proto`" ]
 
 	./test_encode3 | ./test_decode3
-	./test_encode3 1 | ./test_decode3 1
+	./test_encode3 | protoc --decode=AllTypes -I. -I../generator $(PBPATHOPT) alltypes.proto >/dev/null
-	./test_encode3 1 | protoc --decode=AllTypes -I. -I../generator -I/usr/include alltypes.proto >/dev/null
-	./test_encode3_buf 1 | ./test_decode3_buf 1
-	./bc_encode | ./bc_decode
-	
-	./test_missing_fields
 
-test_options: options.pb.h options.expected options.pb.o
+	./test_encode4 | ./test_decode4
-	cat options.expected | while read -r p; do \
+	./test_encode4 | protoc --decode=AlignTypes -I. -I../generator $(PBPATHOPT) aligntype.proto >/dev/null
-	    if ! grep -q "$$p" $<; then \
-	        echo Expected: "$$p"; \
-	        exit 1; \
-	    fi \
-	done
 
 run_fuzztest: test_decode2
 	bash -c 'I=1; while true; do cat /dev/urandom | ./test_decode2 > /dev/null; I=$$(($$I+1)); echo -en "\r$$I"; done'

tests/aligntype.proto

@@ -0,0 +1,80 @@
+import "nanopb.proto";
+
+message SubMessage {
+    required string substuff1 = 1 [(nanopb).max_size = 16];
+    required int32 substuff2 = 2;
+}
+
+enum MyEnum {
+    First = 1;
+    Second = 2;
+    Truth = 42;
+}
+
+message AlignTypes {
+    required bool       req_bool    = 1;
+    required int32      req_int32   = 2;
+    required SubMessage req_submsg  = 3;
+    required int64      req_int64   = 4;
+    required string     req_string  = 5 [(nanopb).max_size = 16];
+    required MyEnum     req_enum    = 6;
+    required bytes      req_bytes   = 7 [(nanopb).max_size = 16];
+    required sint32     req_sint32  = 8;
+    required bool       req_bool_2  = 9;
+    required sint64     req_sint64  = 10;
+    required bool       req_bool_3  = 11;
+    required fixed32    req_fixed32 = 12;
+    required bool       req_bool_4  = 13;
+    required fixed64    req_fixed64 = 14;
+    required bool       req_bool_5  = 15;
+    required float      req_float   = 16;
+    required bool       req_bool_6  = 17;
+    required double     req_double  = 18;
+
+    optional bool       opt_bool    = 19;
+    optional int32      opt_int32   = 20;
+    optional SubMessage opt_submsg  = 21;
+    optional int64      opt_int64   = 22;
+    optional string     opt_string  = 23 [(nanopb).max_size = 16];
+    optional MyEnum     opt_enum    = 24;
+    optional bytes      opt_bytes   = 25 [(nanopb).max_size = 16];
+    optional sint32     opt_sint32  = 26;
+    optional bool       opt_bool_2  = 27;
+    optional sint64     opt_sint64  = 28;
+    optional bool       opt_bool_3  = 29;
+    optional fixed32    opt_fixed32 = 30;
+    optional bool       opt_bool_4  = 31;
+    optional fixed64    opt_fixed64 = 32;
+    optional bool       opt_bool_5  = 33;
+    optional float      opt_float   = 34;
+    optional bool       opt_bool_6  = 35;
+    optional double     opt_double  = 36;
+
+    required bool       req_bool_aligned    = 37; 
+    required int32      req_int32_aligned   = 38;
+    required int64      req_int64_aligned   = 39;
+    required MyEnum     req_enum_aligned    = 40;
+    required sint32     req_sint32_aligned  = 41;
+    required sint64     req_sint64_aligned  = 42;
+    required fixed32    req_fixed32_aligned = 43;
+    required fixed64    req_fixed64_aligned = 44;
+    required float      req_float_aligned   = 45;
+    required double     req_double_aligned  = 46;
+
+    optional bool       opt_bool_aligned    = 47;
+    optional int32      opt_int32_aligned   = 48;
+    optional int64      opt_int64_aligned   = 49;
+    optional MyEnum     opt_enum_aligned    = 50;
+    optional sint32     opt_sint32_aligned  = 51;
+    optional sint64     opt_sint64_aligned  = 52;
+    optional fixed32    opt_fixed32_aligned = 53;
+    optional fixed64    opt_fixed64_aligned = 54;
+    optional float      opt_float_aligned   = 55;
+    optional double     opt_double_aligned  = 56;
+
+
+    // Just to make sure that the size of the fields has been calculated
+    // properly, i.e. otherwise a bug in last field might not be detected.
+    required int32      end = 99;
+}
+

tests/alltypes.proto

@@ -1,13 +1,11 @@
 import "nanopb.proto";
 
 message SubMessage {
-    required string substuff1 = 1 [(nanopb).max_size = 16, default = "1"];
+    required string substuff1 = 1 [(nanopb).max_size = 16];
-    required int32 substuff2 = 2 [default = 2];
+    required int32 substuff2 = 2;
-    optional fixed32 substuff3 = 3 [default = 3];
 }
 
 enum MyEnum {
-    Zero = 0;
     First = 1;
     Second = 2;
     Truth = 42;
@@ -35,49 +33,6 @@ message AllTypes {
     required SubMessage req_submsg  = 16;
     required MyEnum     req_enum    = 17;
     
-    
-    repeated int32      rep_int32   = 21 [(nanopb).max_count = 5];
-    repeated int64      rep_int64   = 22 [(nanopb).max_count = 5];
-    repeated uint32     rep_uint32  = 23 [(nanopb).max_count = 5];
-    repeated uint64     rep_uint64  = 24 [(nanopb).max_count = 5];
-    repeated sint32     rep_sint32  = 25 [(nanopb).max_count = 5];
-    repeated sint64     rep_sint64  = 26 [(nanopb).max_count = 5];
-    repeated bool       rep_bool    = 27 [(nanopb).max_count = 5];
-    
-    repeated fixed32    rep_fixed32 = 28 [(nanopb).max_count = 5];
-    repeated sfixed32   rep_sfixed32= 29 [(nanopb).max_count = 5];
-    repeated float      rep_float   = 30 [(nanopb).max_count = 5];
-    
-    repeated fixed64    rep_fixed64 = 31 [(nanopb).max_count = 5];
-    repeated sfixed64   rep_sfixed64= 32 [(nanopb).max_count = 5];
-    repeated double     rep_double  = 33 [(nanopb).max_count = 5];
-    
-    repeated string     rep_string  = 34 [(nanopb).max_size = 16, (nanopb).max_count = 5];
-    repeated bytes      rep_bytes   = 35 [(nanopb).max_size = 16, (nanopb).max_count = 5];
-    repeated SubMessage rep_submsg  = 36 [(nanopb).max_count = 5];
-    repeated MyEnum     rep_enum    = 37 [(nanopb).max_count = 5];
-    
-    optional int32      opt_int32   = 41 [default = 4041];
-    optional int64      opt_int64   = 42 [default = 4042];
-    optional uint32     opt_uint32  = 43 [default = 4043];
-    optional uint64     opt_uint64  = 44 [default = 4044];
-    optional sint32     opt_sint32  = 45 [default = 4045];
-    optional sint64     opt_sint64  = 46 [default = 4046];
-    optional bool       opt_bool    = 47 [default = false];
-    
-    optional fixed32    opt_fixed32 = 48 [default = 4048];
-    optional sfixed32   opt_sfixed32= 49 [default = 4049];
-    optional float      opt_float   = 50 [default = 4050];
-    
-    optional fixed64    opt_fixed64 = 51 [default = 4051];
-    optional sfixed64   opt_sfixed64= 52 [default = 4052];
-    optional double     opt_double  = 53 [default = 4053];
-    
-    optional string     opt_string  = 54 [(nanopb).max_size = 16, default = "4054"];
-    optional bytes      opt_bytes   = 55 [(nanopb).max_size = 16, default = "4055"];
-    optional SubMessage opt_submsg  = 56;
-    optional MyEnum     opt_enum    = 57 [default = Second];
-
     // Just to make sure that the size of the fields has been calculated
     // properly, i.e. otherwise a bug in last field might not be detected.
     required int32      end = 99;

tests/bc_alltypes.pb.c

@@ -1,326 +0,0 @@
-/* Automatically generated nanopb constant definitions */
-#include "bc_alltypes.pb.h"
-
-const char SubMessage_substuff1_default[17] = "1";
-const int32_t SubMessage_substuff2_default = 2;
-const uint32_t SubMessage_substuff3_default = 3;
-const int32_t AllTypes_opt_int32_default = 4041;
-const int64_t AllTypes_opt_int64_default = 4042;
-const uint32_t AllTypes_opt_uint32_default = 4043;
-const uint64_t AllTypes_opt_uint64_default = 4044;
-const int32_t AllTypes_opt_sint32_default = 4045;
-const int64_t AllTypes_opt_sint64_default = 4046;
-const bool AllTypes_opt_bool_default = false;
-const uint32_t AllTypes_opt_fixed32_default = 4048;
-const int32_t AllTypes_opt_sfixed32_default = 4049;
-const float AllTypes_opt_float_default = 4050;
-const uint64_t AllTypes_opt_fixed64_default = 4051;
-const int64_t AllTypes_opt_sfixed64_default = 4052;
-const double AllTypes_opt_double_default = 4053;
-const char AllTypes_opt_string_default[17] = "4054";
-const AllTypes_opt_bytes_t AllTypes_opt_bytes_default = {4, {0x34,0x30,0x35,0x35}};
-const MyEnum AllTypes_opt_enum_default = MyEnum_Second;
-
-
-const pb_field_t SubMessage_fields[4] = {
-    {1, PB_HTYPE_REQUIRED | PB_LTYPE_STRING,
-    offsetof(SubMessage, substuff1), 0,
-    pb_membersize(SubMessage, substuff1), 0,
-    &SubMessage_substuff1_default},
-
-    {2, PB_HTYPE_REQUIRED | PB_LTYPE_VARINT,
-    pb_delta_end(SubMessage, substuff2, substuff1), 0,
-    pb_membersize(SubMessage, substuff2), 0,
-    &SubMessage_substuff2_default},
-
-    {3, PB_HTYPE_OPTIONAL | PB_LTYPE_FIXED32,
-    pb_delta_end(SubMessage, substuff3, substuff2),
-    pb_delta(SubMessage, has_substuff3, substuff3),
-    pb_membersize(SubMessage, substuff3), 0,
-    &SubMessage_substuff3_default},
-
-    PB_LAST_FIELD
-};
-
-const pb_field_t AllTypes_fields[53] = {
-    {1, PB_HTYPE_REQUIRED | PB_LTYPE_VARINT,
-    offsetof(AllTypes, req_int32), 0,
-    pb_membersize(AllTypes, req_int32), 0, 0},
-
-    {2, PB_HTYPE_REQUIRED | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, req_int64, req_int32), 0,
-    pb_membersize(AllTypes, req_int64), 0, 0},
-
-    {3, PB_HTYPE_REQUIRED | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, req_uint32, req_int64), 0,
-    pb_membersize(AllTypes, req_uint32), 0, 0},
-
-    {4, PB_HTYPE_REQUIRED | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, req_uint64, req_uint32), 0,
-    pb_membersize(AllTypes, req_uint64), 0, 0},
-
-    {5, PB_HTYPE_REQUIRED | PB_LTYPE_SVARINT,
-    pb_delta_end(AllTypes, req_sint32, req_uint64), 0,
-    pb_membersize(AllTypes, req_sint32), 0, 0},
-
-    {6, PB_HTYPE_REQUIRED | PB_LTYPE_SVARINT,
-    pb_delta_end(AllTypes, req_sint64, req_sint32), 0,
-    pb_membersize(AllTypes, req_sint64), 0, 0},
-
-    {7, PB_HTYPE_REQUIRED | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, req_bool, req_sint64), 0,
-    pb_membersize(AllTypes, req_bool), 0, 0},
-
-    {8, PB_HTYPE_REQUIRED | PB_LTYPE_FIXED32,
-    pb_delta_end(AllTypes, req_fixed32, req_bool), 0,
-    pb_membersize(AllTypes, req_fixed32), 0, 0},
-
-    {9, PB_HTYPE_REQUIRED | PB_LTYPE_FIXED32,
-    pb_delta_end(AllTypes, req_sfixed32, req_fixed32), 0,
-    pb_membersize(AllTypes, req_sfixed32), 0, 0},
-
-    {10, PB_HTYPE_REQUIRED | PB_LTYPE_FIXED32,
-    pb_delta_end(AllTypes, req_float, req_sfixed32), 0,
-    pb_membersize(AllTypes, req_float), 0, 0},
-
-    {11, PB_HTYPE_REQUIRED | PB_LTYPE_FIXED64,
-    pb_delta_end(AllTypes, req_fixed64, req_float), 0,
-    pb_membersize(AllTypes, req_fixed64), 0, 0},
-
-    {12, PB_HTYPE_REQUIRED | PB_LTYPE_FIXED64,
-    pb_delta_end(AllTypes, req_sfixed64, req_fixed64), 0,
-    pb_membersize(AllTypes, req_sfixed64), 0, 0},
-
-    {13, PB_HTYPE_REQUIRED | PB_LTYPE_FIXED64,
-    pb_delta_end(AllTypes, req_double, req_sfixed64), 0,
-    pb_membersize(AllTypes, req_double), 0, 0},
-
-    {14, PB_HTYPE_REQUIRED | PB_LTYPE_STRING,
-    pb_delta_end(AllTypes, req_string, req_double), 0,
-    pb_membersize(AllTypes, req_string), 0, 0},
-
-    {15, PB_HTYPE_REQUIRED | PB_LTYPE_BYTES,
-    pb_delta_end(AllTypes, req_bytes, req_string), 0,
-    pb_membersize(AllTypes, req_bytes), 0, 0},
-
-    {16, PB_HTYPE_REQUIRED | PB_LTYPE_SUBMESSAGE,
-    pb_delta_end(AllTypes, req_submsg, req_bytes), 0,
-    pb_membersize(AllTypes, req_submsg), 0,
-    &SubMessage_fields},
-
-    {17, PB_HTYPE_REQUIRED | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, req_enum, req_submsg), 0,
-    pb_membersize(AllTypes, req_enum), 0, 0},
-
-    {21, PB_HTYPE_ARRAY | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, rep_int32, req_enum),
-    pb_delta(AllTypes, rep_int32_count, rep_int32),
-    pb_membersize(AllTypes, rep_int32[0]),
-    pb_membersize(AllTypes, rep_int32) / pb_membersize(AllTypes, rep_int32[0]), 0},
-
-    {22, PB_HTYPE_ARRAY | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, rep_int64, rep_int32),
-    pb_delta(AllTypes, rep_int64_count, rep_int64),
-    pb_membersize(AllTypes, rep_int64[0]),
-    pb_membersize(AllTypes, rep_int64) / pb_membersize(AllTypes, rep_int64[0]), 0},
-
-    {23, PB_HTYPE_ARRAY | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, rep_uint32, rep_int64),
-    pb_delta(AllTypes, rep_uint32_count, rep_uint32),
-    pb_membersize(AllTypes, rep_uint32[0]),
-    pb_membersize(AllTypes, rep_uint32) / pb_membersize(AllTypes, rep_uint32[0]), 0},
-
-    {24, PB_HTYPE_ARRAY | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, rep_uint64, rep_uint32),
-    pb_delta(AllTypes, rep_uint64_count, rep_uint64),
-    pb_membersize(AllTypes, rep_uint64[0]),
-    pb_membersize(AllTypes, rep_uint64) / pb_membersize(AllTypes, rep_uint64[0]), 0},
-
-    {25, PB_HTYPE_ARRAY | PB_LTYPE_SVARINT,
-    pb_delta_end(AllTypes, rep_sint32, rep_uint64),
-    pb_delta(AllTypes, rep_sint32_count, rep_sint32),
-    pb_membersize(AllTypes, rep_sint32[0]),
-    pb_membersize(AllTypes, rep_sint32) / pb_membersize(AllTypes, rep_sint32[0]), 0},
-
-    {26, PB_HTYPE_ARRAY | PB_LTYPE_SVARINT,
-    pb_delta_end(AllTypes, rep_sint64, rep_sint32),
-    pb_delta(AllTypes, rep_sint64_count, rep_sint64),
-    pb_membersize(AllTypes, rep_sint64[0]),
-    pb_membersize(AllTypes, rep_sint64) / pb_membersize(AllTypes, rep_sint64[0]), 0},
-
-    {27, PB_HTYPE_ARRAY | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, rep_bool, rep_sint64),
-    pb_delta(AllTypes, rep_bool_count, rep_bool),
-    pb_membersize(AllTypes, rep_bool[0]),
-    pb_membersize(AllTypes, rep_bool) / pb_membersize(AllTypes, rep_bool[0]), 0},
-
-    {28, PB_HTYPE_ARRAY | PB_LTYPE_FIXED32,
-    pb_delta_end(AllTypes, rep_fixed32, rep_bool),
-    pb_delta(AllTypes, rep_fixed32_count, rep_fixed32),
-    pb_membersize(AllTypes, rep_fixed32[0]),
-    pb_membersize(AllTypes, rep_fixed32) / pb_membersize(AllTypes, rep_fixed32[0]), 0},
-
-    {29, PB_HTYPE_ARRAY | PB_LTYPE_FIXED32,
-    pb_delta_end(AllTypes, rep_sfixed32, rep_fixed32),
-    pb_delta(AllTypes, rep_sfixed32_count, rep_sfixed32),
-    pb_membersize(AllTypes, rep_sfixed32[0]),
-    pb_membersize(AllTypes, rep_sfixed32) / pb_membersize(AllTypes, rep_sfixed32[0]), 0},
-
-    {30, PB_HTYPE_ARRAY | PB_LTYPE_FIXED32,
-    pb_delta_end(AllTypes, rep_float, rep_sfixed32),
-    pb_delta(AllTypes, rep_float_count, rep_float),
-    pb_membersize(AllTypes, rep_float[0]),
-    pb_membersize(AllTypes, rep_float) / pb_membersize(AllTypes, rep_float[0]), 0},
-
-    {31, PB_HTYPE_ARRAY | PB_LTYPE_FIXED64,
-    pb_delta_end(AllTypes, rep_fixed64, rep_float),
-    pb_delta(AllTypes, rep_fixed64_count, rep_fixed64),
-    pb_membersize(AllTypes, rep_fixed64[0]),
-    pb_membersize(AllTypes, rep_fixed64) / pb_membersize(AllTypes, rep_fixed64[0]), 0},
-
-    {32, PB_HTYPE_ARRAY | PB_LTYPE_FIXED64,
-    pb_delta_end(AllTypes, rep_sfixed64, rep_fixed64),
-    pb_delta(AllTypes, rep_sfixed64_count, rep_sfixed64),
-    pb_membersize(AllTypes, rep_sfixed64[0]),
-    pb_membersize(AllTypes, rep_sfixed64) / pb_membersize(AllTypes, rep_sfixed64[0]), 0},
-
-    {33, PB_HTYPE_ARRAY | PB_LTYPE_FIXED64,
-    pb_delta_end(AllTypes, rep_double, rep_sfixed64),
-    pb_delta(AllTypes, rep_double_count, rep_double),
-    pb_membersize(AllTypes, rep_double[0]),
-    pb_membersize(AllTypes, rep_double) / pb_membersize(AllTypes, rep_double[0]), 0},
-
-    {34, PB_HTYPE_ARRAY | PB_LTYPE_STRING,
-    pb_delta_end(AllTypes, rep_string, rep_double),
-    pb_delta(AllTypes, rep_string_count, rep_string),
-    pb_membersize(AllTypes, rep_string[0]),
-    pb_membersize(AllTypes, rep_string) / pb_membersize(AllTypes, rep_string[0]), 0},
-
-    {35, PB_HTYPE_ARRAY | PB_LTYPE_BYTES,
-    pb_delta_end(AllTypes, rep_bytes, rep_string),
-    pb_delta(AllTypes, rep_bytes_count, rep_bytes),
-    pb_membersize(AllTypes, rep_bytes[0]),
-    pb_membersize(AllTypes, rep_bytes) / pb_membersize(AllTypes, rep_bytes[0]), 0},
-
-    {36, PB_HTYPE_ARRAY | PB_LTYPE_SUBMESSAGE,
-    pb_delta_end(AllTypes, rep_submsg, rep_bytes),
-    pb_delta(AllTypes, rep_submsg_count, rep_submsg),
-    pb_membersize(AllTypes, rep_submsg[0]),
-    pb_membersize(AllTypes, rep_submsg) / pb_membersize(AllTypes, rep_submsg[0]),
-    &SubMessage_fields},
-
-    {37, PB_HTYPE_ARRAY | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, rep_enum, rep_submsg),
-    pb_delta(AllTypes, rep_enum_count, rep_enum),
-    pb_membersize(AllTypes, rep_enum[0]),
-    pb_membersize(AllTypes, rep_enum) / pb_membersize(AllTypes, rep_enum[0]), 0},
-
-    {41, PB_HTYPE_OPTIONAL | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, opt_int32, rep_enum),
-    pb_delta(AllTypes, has_opt_int32, opt_int32),
-    pb_membersize(AllTypes, opt_int32), 0,
-    &AllTypes_opt_int32_default},
-
-    {42, PB_HTYPE_OPTIONAL | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, opt_int64, opt_int32),
-    pb_delta(AllTypes, has_opt_int64, opt_int64),
-    pb_membersize(AllTypes, opt_int64), 0,
-    &AllTypes_opt_int64_default},
-
-    {43, PB_HTYPE_OPTIONAL | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, opt_uint32, opt_int64),
-    pb_delta(AllTypes, has_opt_uint32, opt_uint32),
-    pb_membersize(AllTypes, opt_uint32), 0,
-    &AllTypes_opt_uint32_default},
-
-    {44, PB_HTYPE_OPTIONAL | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, opt_uint64, opt_uint32),
-    pb_delta(AllTypes, has_opt_uint64, opt_uint64),
-    pb_membersize(AllTypes, opt_uint64), 0,
-    &AllTypes_opt_uint64_default},
-
-    {45, PB_HTYPE_OPTIONAL | PB_LTYPE_SVARINT,
-    pb_delta_end(AllTypes, opt_sint32, opt_uint64),
-    pb_delta(AllTypes, has_opt_sint32, opt_sint32),
-    pb_membersize(AllTypes, opt_sint32), 0,
-    &AllTypes_opt_sint32_default},
-
-    {46, PB_HTYPE_OPTIONAL | PB_LTYPE_SVARINT,
-    pb_delta_end(AllTypes, opt_sint64, opt_sint32),
-    pb_delta(AllTypes, has_opt_sint64, opt_sint64),
-    pb_membersize(AllTypes, opt_sint64), 0,
-    &AllTypes_opt_sint64_default},
-
-    {47, PB_HTYPE_OPTIONAL | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, opt_bool, opt_sint64),
-    pb_delta(AllTypes, has_opt_bool, opt_bool),
-    pb_membersize(AllTypes, opt_bool), 0,
-    &AllTypes_opt_bool_default},
-
-    {48, PB_HTYPE_OPTIONAL | PB_LTYPE_FIXED32,
-    pb_delta_end(AllTypes, opt_fixed32, opt_bool),
-    pb_delta(AllTypes, has_opt_fixed32, opt_fixed32),
-    pb_membersize(AllTypes, opt_fixed32), 0,
-    &AllTypes_opt_fixed32_default},
-
-    {49, PB_HTYPE_OPTIONAL | PB_LTYPE_FIXED32,
-    pb_delta_end(AllTypes, opt_sfixed32, opt_fixed32),
-    pb_delta(AllTypes, has_opt_sfixed32, opt_sfixed32),
-    pb_membersize(AllTypes, opt_sfixed32), 0,
-    &AllTypes_opt_sfixed32_default},
-
-    {50, PB_HTYPE_OPTIONAL | PB_LTYPE_FIXED32,
-    pb_delta_end(AllTypes, opt_float, opt_sfixed32),
-    pb_delta(AllTypes, has_opt_float, opt_float),
-    pb_membersize(AllTypes, opt_float), 0,
-    &AllTypes_opt_float_default},
-
-    {51, PB_HTYPE_OPTIONAL | PB_LTYPE_FIXED64,
-    pb_delta_end(AllTypes, opt_fixed64, opt_float),
-    pb_delta(AllTypes, has_opt_fixed64, opt_fixed64),
-    pb_membersize(AllTypes, opt_fixed64), 0,
-    &AllTypes_opt_fixed64_default},
-
-    {52, PB_HTYPE_OPTIONAL | PB_LTYPE_FIXED64,
-    pb_delta_end(AllTypes, opt_sfixed64, opt_fixed64),
-    pb_delta(AllTypes, has_opt_sfixed64, opt_sfixed64),
-    pb_membersize(AllTypes, opt_sfixed64), 0,
-    &AllTypes_opt_sfixed64_default},
-
-    {53, PB_HTYPE_OPTIONAL | PB_LTYPE_FIXED64,
-    pb_delta_end(AllTypes, opt_double, opt_sfixed64),
-    pb_delta(AllTypes, has_opt_double, opt_double),
-    pb_membersize(AllTypes, opt_double), 0,
-    &AllTypes_opt_double_default},
-
-    {54, PB_HTYPE_OPTIONAL | PB_LTYPE_STRING,
-    pb_delta_end(AllTypes, opt_string, opt_double),
-    pb_delta(AllTypes, has_opt_string, opt_string),
-    pb_membersize(AllTypes, opt_string), 0,
-    &AllTypes_opt_string_default},
-
-    {55, PB_HTYPE_OPTIONAL | PB_LTYPE_BYTES,
-    pb_delta_end(AllTypes, opt_bytes, opt_string),
-    pb_delta(AllTypes, has_opt_bytes, opt_bytes),
-    pb_membersize(AllTypes, opt_bytes), 0,
-    &AllTypes_opt_bytes_default},
-
-    {56, PB_HTYPE_OPTIONAL | PB_LTYPE_SUBMESSAGE,
-    pb_delta_end(AllTypes, opt_submsg, opt_bytes),
-    pb_delta(AllTypes, has_opt_submsg, opt_submsg),
-    pb_membersize(AllTypes, opt_submsg), 0,
-    &SubMessage_fields},
-
-    {57, PB_HTYPE_OPTIONAL | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, opt_enum, opt_submsg),
-    pb_delta(AllTypes, has_opt_enum, opt_enum),
-    pb_membersize(AllTypes, opt_enum), 0,
-    &AllTypes_opt_enum_default},
-
-    {99, PB_HTYPE_REQUIRED | PB_LTYPE_VARINT,
-    pb_delta_end(AllTypes, end, opt_enum), 0,
-    pb_membersize(AllTypes, end), 0, 0},
-
-    PB_LAST_FIELD
-};
-

tests/bc_alltypes.pb.h

@@ -1,155 +0,0 @@
-/* Automatically generated nanopb header */
-/* This is a file generated using nanopb-0.1.1.
- * It is used as a part of test suite in order to detect any
- * incompatible changes made to the generator in future versions.
- */
-#ifndef _PB_BC_ALLTYPES_PB_H_
-#define _PB_BC_ALLTYPES_PB_H_
-#include <pb.h>
-
-/* Enum definitions */
-typedef enum {
-    MyEnum_Zero = 0,
-    MyEnum_First = 1,
-    MyEnum_Second = 2,
-    MyEnum_Truth = 42
-} MyEnum;
-
-/* Struct definitions */
-typedef struct {
-    char substuff1[16];
-    int32_t substuff2;
-    bool has_substuff3;
-    uint32_t substuff3;
-} SubMessage;
-
-typedef struct {
-    size_t size;
-    uint8_t bytes[16];
-} AllTypes_req_bytes_t;
-
-typedef struct {
-    size_t size;
-    uint8_t bytes[16];
-} AllTypes_rep_bytes_t;
-
-typedef struct {
-    size_t size;
-    uint8_t bytes[16];
-} AllTypes_opt_bytes_t;
-
-typedef struct {
-    int32_t req_int32;
-    int64_t req_int64;
-    uint32_t req_uint32;
-    uint64_t req_uint64;
-    int32_t req_sint32;
-    int64_t req_sint64;
-    bool req_bool;
-    uint32_t req_fixed32;
-    int32_t req_sfixed32;
-    float req_float;
-    uint64_t req_fixed64;
-    int64_t req_sfixed64;
-    double req_double;
-    char req_string[16];
-    AllTypes_req_bytes_t req_bytes;
-    SubMessage req_submsg;
-    MyEnum req_enum;
-    size_t rep_int32_count;
-    int32_t rep_int32[5];
-    size_t rep_int64_count;
-    int64_t rep_int64[5];
-    size_t rep_uint32_count;
-    uint32_t rep_uint32[5];
-    size_t rep_uint64_count;
-    uint64_t rep_uint64[5];
-    size_t rep_sint32_count;
-    int32_t rep_sint32[5];
-    size_t rep_sint64_count;
-    int64_t rep_sint64[5];
-    size_t rep_bool_count;
-    bool rep_bool[5];
-    size_t rep_fixed32_count;
-    uint32_t rep_fixed32[5];
-    size_t rep_sfixed32_count;
-    int32_t rep_sfixed32[5];
-    size_t rep_float_count;
-    float rep_float[5];
-    size_t rep_fixed64_count;
-    uint64_t rep_fixed64[5];
-    size_t rep_sfixed64_count;
-    int64_t rep_sfixed64[5];
-    size_t rep_double_count;
-    double rep_double[5];
-    size_t rep_string_count;
-    char rep_string[5][16];
-    size_t rep_bytes_count;
-    AllTypes_rep_bytes_t rep_bytes[5];
-    size_t rep_submsg_count;
-    SubMessage rep_submsg[5];
-    size_t rep_enum_count;
-    MyEnum rep_enum[5];
-    bool has_opt_int32;
-    int32_t opt_int32;
-    bool has_opt_int64;
-    int64_t opt_int64;
-    bool has_opt_uint32;
-    uint32_t opt_uint32;
-    bool has_opt_uint64;
-    uint64_t opt_uint64;
-    bool has_opt_sint32;
-    int32_t opt_sint32;
-    bool has_opt_sint64;
-    int64_t opt_sint64;
-    bool has_opt_bool;
-    bool opt_bool;
-    bool has_opt_fixed32;
-    uint32_t opt_fixed32;
-    bool has_opt_sfixed32;
-    int32_t opt_sfixed32;
-    bool has_opt_float;
-    float opt_float;
-    bool has_opt_fixed64;
-    uint64_t opt_fixed64;
-    bool has_opt_sfixed64;
-    int64_t opt_sfixed64;
-    bool has_opt_double;
-    double opt_double;
-    bool has_opt_string;
-    char opt_string[16];
-    bool has_opt_bytes;
-    AllTypes_opt_bytes_t opt_bytes;
-    bool has_opt_submsg;
-    SubMessage opt_submsg;
-    bool has_opt_enum;
-    MyEnum opt_enum;
-    int32_t end;
-} AllTypes;
-
-/* Default values for struct fields */
-extern const char SubMessage_substuff1_default[17];
-extern const int32_t SubMessage_substuff2_default;
-extern const uint32_t SubMessage_substuff3_default;
-extern const int32_t AllTypes_opt_int32_default;
-extern const int64_t AllTypes_opt_int64_default;
-extern const uint32_t AllTypes_opt_uint32_default;
-extern const uint64_t AllTypes_opt_uint64_default;
-extern const int32_t AllTypes_opt_sint32_default;
-extern const int64_t AllTypes_opt_sint64_default;
-extern const bool AllTypes_opt_bool_default;
-extern const uint32_t AllTypes_opt_fixed32_default;
-extern const int32_t AllTypes_opt_sfixed32_default;
-extern const float AllTypes_opt_float_default;
-extern const uint64_t AllTypes_opt_fixed64_default;
-extern const int64_t AllTypes_opt_sfixed64_default;
-extern const double AllTypes_opt_double_default;
-extern const char AllTypes_opt_string_default[17];
-extern const AllTypes_opt_bytes_t AllTypes_opt_bytes_default;
-extern const MyEnum AllTypes_opt_enum_default;
-
-/* Struct field encoding specification for nanopb */
-extern const pb_field_t SubMessage_fields[4];
-extern const pb_field_t AllTypes_fields[53];
-
-#endif

tests/bc_decode.c

@@ -1,197 +0,0 @@
-/* Tests the decoding of all types.
- * This is a backwards-compatibility test, using bc_alltypes.pb.h.
- * It is similar to test_decode3, but duplicated in order to allow
- * test_decode3 to test any new features introduced later.
- *
- * Run e.g. ./bc_encode | ./bc_decode
- */
-
-#include <stdio.h>
-#include <string.h>
-#include <stdlib.h>
-#include <pb_decode.h>
-#include "bc_alltypes.pb.h"
-
-#define TEST(x) if (!(x)) { \
-    printf("Test " #x " failed.\n"); \
-    return false; \
-    }
-
-/* This function is called once from main(), it handles
-   the decoding and checks the fields. */
-bool check_alltypes(pb_istream_t *stream, int mode)
-{
-    AllTypes alltypes;
-    
-    /* Fill with garbage to better detect initialization errors */
-    memset(&alltypes, 0xAA, sizeof(alltypes));
-    
-    if (!pb_decode(stream, AllTypes_fields, &alltypes))
-        return false;
-    
-    TEST(alltypes.req_int32         == -1001);
-    TEST(alltypes.req_int64         == -1002);
-    TEST(alltypes.req_uint32        == 1003);
-    TEST(alltypes.req_uint64        == 1004);
-    TEST(alltypes.req_sint32        == -1005);
-    TEST(alltypes.req_sint64        == -1006);
-    TEST(alltypes.req_bool          == true);
-    
-    TEST(alltypes.req_fixed32       == 1008);
-    TEST(alltypes.req_sfixed32      == -1009);
-    TEST(alltypes.req_float         == 1010.0f);
-    
-    TEST(alltypes.req_fixed64       == 1011);
-    TEST(alltypes.req_sfixed64      == -1012);
-    TEST(alltypes.req_double        == 1013.0f);
-    
-    TEST(strcmp(alltypes.req_string, "1014") == 0);
-    TEST(alltypes.req_bytes.size == 4);
-    TEST(memcmp(alltypes.req_bytes.bytes, "1015", 4) == 0);
-    TEST(strcmp(alltypes.req_submsg.substuff1, "1016") == 0);
-    TEST(alltypes.req_submsg.substuff2 == 1016);
-    TEST(alltypes.req_submsg.substuff3 == 3);
-    TEST(alltypes.req_enum == MyEnum_Truth);
-    
-    TEST(alltypes.rep_int32_count == 5 && alltypes.rep_int32[4] == -2001 && alltypes.rep_int32[0] == 0);
-    TEST(alltypes.rep_int64_count == 5 && alltypes.rep_int64[4] == -2002 && alltypes.rep_int64[0] == 0);
-    TEST(alltypes.rep_uint32_count == 5 && alltypes.rep_uint32[4] == 2003 && alltypes.rep_uint32[0] == 0);
-    TEST(alltypes.rep_uint64_count == 5 && alltypes.rep_uint64[4] == 2004 && alltypes.rep_uint64[0] == 0);
-    TEST(alltypes.rep_sint32_count == 5 && alltypes.rep_sint32[4] == -2005 && alltypes.rep_sint32[0] == 0);
-    TEST(alltypes.rep_sint64_count == 5 && alltypes.rep_sint64[4] == -2006 && alltypes.rep_sint64[0] == 0);
-    TEST(alltypes.rep_bool_count == 5 && alltypes.rep_bool[4] == true && alltypes.rep_bool[0] == false);
-    
-    TEST(alltypes.rep_fixed32_count == 5 && alltypes.rep_fixed32[4] == 2008 && alltypes.rep_fixed32[0] == 0);
-    TEST(alltypes.rep_sfixed32_count == 5 && alltypes.rep_sfixed32[4] == -2009 && alltypes.rep_sfixed32[0] == 0);
-    TEST(alltypes.rep_float_count == 5 && alltypes.rep_float[4] == 2010.0f && alltypes.rep_float[0] == 0.0f);
-    
-    TEST(alltypes.rep_fixed64_count == 5 && alltypes.rep_fixed64[4] == 2011 && alltypes.rep_fixed64[0] == 0);
-    TEST(alltypes.rep_sfixed64_count == 5 && alltypes.rep_sfixed64[4] == -2012 && alltypes.rep_sfixed64[0] == 0);
-    TEST(alltypes.rep_double_count == 5 && alltypes.rep_double[4] == 2013.0 && alltypes.rep_double[0] == 0.0);
-    
-    TEST(alltypes.rep_string_count == 5 && strcmp(alltypes.rep_string[4], "2014") == 0 && alltypes.rep_string[0][0] == '\0');
-    TEST(alltypes.rep_bytes_count == 5 && alltypes.rep_bytes[4].size == 4 && alltypes.rep_bytes[0].size == 0);
-    TEST(memcmp(alltypes.rep_bytes[4].bytes, "2015", 4) == 0);
-
-    TEST(alltypes.rep_submsg_count == 5);
-    TEST(strcmp(alltypes.rep_submsg[4].substuff1, "2016") == 0 && alltypes.rep_submsg[0].substuff1[0] == '\0');
-    TEST(alltypes.rep_submsg[4].substuff2 == 2016 && alltypes.rep_submsg[0].substuff2 == 0);
-    TEST(alltypes.rep_submsg[4].substuff3 == 2016 && alltypes.rep_submsg[0].substuff3 == 3);
-    
-    TEST(alltypes.rep_enum_count == 5 && alltypes.rep_enum[4] == MyEnum_Truth && alltypes.rep_enum[0] == MyEnum_Zero);
-    
-    if (mode == 0)
-    {
-        /* Expect default values */
-        TEST(alltypes.has_opt_int32     == false);
-        TEST(alltypes.opt_int32         == 4041);
-        TEST(alltypes.has_opt_int64     == false);
-        TEST(alltypes.opt_int64         == 4042);
-        TEST(alltypes.has_opt_uint32    == false);
-        TEST(alltypes.opt_uint32        == 4043);
-        TEST(alltypes.has_opt_uint64    == false);
-        TEST(alltypes.opt_uint64        == 4044);
-        TEST(alltypes.has_opt_sint32    == false);
-        TEST(alltypes.opt_sint32        == 4045);
-        TEST(alltypes.has_opt_sint64    == false);
-        TEST(alltypes.opt_sint64        == 4046);
-        TEST(alltypes.has_opt_bool      == false);
-        TEST(alltypes.opt_bool          == false);
-        
-        TEST(alltypes.has_opt_fixed32   == false);
-        TEST(alltypes.opt_fixed32       == 4048);
-        TEST(alltypes.has_opt_sfixed32  == false);
-        TEST(alltypes.opt_sfixed32      == 4049);
-        TEST(alltypes.has_opt_float     == false);
-        TEST(alltypes.opt_float         == 4050.0f);
-        
-        TEST(alltypes.has_opt_fixed64   == false);
-        TEST(alltypes.opt_fixed64       == 4051);
-        TEST(alltypes.has_opt_sfixed64  == false);
-        TEST(alltypes.opt_sfixed64      == 4052);
-        TEST(alltypes.has_opt_double    == false);
-        TEST(alltypes.opt_double        == 4053.0);
-        
-        TEST(alltypes.has_opt_string    == false);
-        TEST(strcmp(alltypes.opt_string, "4054") == 0);
-        TEST(alltypes.has_opt_bytes     == false);
-        TEST(alltypes.opt_bytes.size == 4);
-        TEST(memcmp(alltypes.opt_bytes.bytes, "4055", 4) == 0);
-        TEST(alltypes.has_opt_submsg    == false);
-        TEST(strcmp(alltypes.opt_submsg.substuff1, "1") == 0);
-        TEST(alltypes.opt_submsg.substuff2 == 2);
-        TEST(alltypes.opt_submsg.substuff3 == 3);
-        TEST(alltypes.has_opt_enum     == false);
-        TEST(alltypes.opt_enum == MyEnum_Second);
-    }
-    else
-    {
-        /* Expect filled-in values */
-        TEST(alltypes.has_opt_int32     == true);
-        TEST(alltypes.opt_int32         == 3041);
-        TEST(alltypes.has_opt_int64     == true);
-        TEST(alltypes.opt_int64         == 3042);
-        TEST(alltypes.has_opt_uint32    == true);
-        TEST(alltypes.opt_uint32        == 3043);
-        TEST(alltypes.has_opt_uint64    == true);
-        TEST(alltypes.opt_uint64        == 3044);
-        TEST(alltypes.has_opt_sint32    == true);
-        TEST(alltypes.opt_sint32        == 3045);
-        TEST(alltypes.has_opt_sint64    == true);
-        TEST(alltypes.opt_sint64        == 3046);
-        TEST(alltypes.has_opt_bool      == true);
-        TEST(alltypes.opt_bool          == true);
-        
-        TEST(alltypes.has_opt_fixed32   == true);
-        TEST(alltypes.opt_fixed32       == 3048);
-        TEST(alltypes.has_opt_sfixed32  == true);
-        TEST(alltypes.opt_sfixed32      == 3049);
-        TEST(alltypes.has_opt_float     == true);
-        TEST(alltypes.opt_float         == 3050.0f);
-        
-        TEST(alltypes.has_opt_fixed64   == true);
-        TEST(alltypes.opt_fixed64       == 3051);
-        TEST(alltypes.has_opt_sfixed64  == true);
-        TEST(alltypes.opt_sfixed64      == 3052);
-        TEST(alltypes.has_opt_double    == true);
-        TEST(alltypes.opt_double        == 3053.0);
-        
-        TEST(alltypes.has_opt_string    == true);
-        TEST(strcmp(alltypes.opt_string, "3054") == 0);
-        TEST(alltypes.has_opt_bytes     == true);
-        TEST(alltypes.opt_bytes.size == 4);
-        TEST(memcmp(alltypes.opt_bytes.bytes, "3055", 4) == 0);
-        TEST(alltypes.has_opt_submsg    == true);
-        TEST(strcmp(alltypes.opt_submsg.substuff1, "3056") == 0);
-        TEST(alltypes.opt_submsg.substuff2 == 3056);
-        TEST(alltypes.opt_submsg.substuff3 == 3);
-        TEST(alltypes.has_opt_enum      == true);
-        TEST(alltypes.opt_enum == MyEnum_Truth);
-    }
-    
-    TEST(alltypes.end == 1099);
-    
-    return true;
-}
-
-int main(int argc, char **argv)
-{
-    /* Whether to expect the optional values or the default values. */
-    int mode = (argc > 1) ? atoi(argv[1]) : 0;
-    
-    /* Read the data into buffer */
-    uint8_t buffer[1024];
-    size_t count = fread(buffer, 1, sizeof(buffer), stdin);
-    
-    /* Construct a pb_istream_t for reading from the buffer */
-    pb_istream_t stream = pb_istream_from_buffer(buffer, count);
-    
-    /* Decode and print out the stuff */
-    if (!check_alltypes(&stream, mode))
-    {
-        printf("Parsing failed: %s\n", PB_GET_ERROR(&stream));
-        return 1;
-    } else {
-        return 0;
-    }
-}

tests/bc_encode.c

@@ -1,131 +0,0 @@
-/* Attempts to test all the datatypes supported by ProtoBuf.
- * This is a backwards-compatibility test, using bc_alltypes.pb.h.
- * It is similar to test_encode3, but duplicated in order to allow
- * test_encode3 to test any new features introduced later.
- */
-
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <pb_encode.h>
-#include "bc_alltypes.pb.h"
-
-int main(int argc, char **argv)
-{
-    int mode = (argc > 1) ? atoi(argv[1]) : 0;
-    
-    /* Initialize the structure with constants */
-    AllTypes alltypes = {0};
-    
-    alltypes.req_int32         = -1001;
-    alltypes.req_int64         = -1002;
-    alltypes.req_uint32        = 1003;
-    alltypes.req_uint64        = 1004;
-    alltypes.req_sint32        = -1005;
-    alltypes.req_sint64        = -1006;
-    alltypes.req_bool          = true;
-    
-    alltypes.req_fixed32       = 1008;
-    alltypes.req_sfixed32      = -1009;
-    alltypes.req_float         = 1010.0f;
-    
-    alltypes.req_fixed64       = 1011;
-    alltypes.req_sfixed64      = -1012;
-    alltypes.req_double        = 1013.0;
-    
-    strcpy(alltypes.req_string, "1014");
-    alltypes.req_bytes.size = 4;
-    memcpy(alltypes.req_bytes.bytes, "1015", 4);
-    strcpy(alltypes.req_submsg.substuff1, "1016");
-    alltypes.req_submsg.substuff2 = 1016;
-    alltypes.req_enum = MyEnum_Truth;
-    
-    alltypes.rep_int32_count = 5; alltypes.rep_int32[4] = -2001;
-    alltypes.rep_int64_count = 5; alltypes.rep_int64[4] = -2002;
-    alltypes.rep_uint32_count = 5; alltypes.rep_uint32[4] = 2003;
-    alltypes.rep_uint64_count = 5; alltypes.rep_uint64[4] = 2004;
-    alltypes.rep_sint32_count = 5; alltypes.rep_sint32[4] = -2005;
-    alltypes.rep_sint64_count = 5; alltypes.rep_sint64[4] = -2006;
-    alltypes.rep_bool_count = 5; alltypes.rep_bool[4] = true;
-    
-    alltypes.rep_fixed32_count = 5; alltypes.rep_fixed32[4] = 2008;
-    alltypes.rep_sfixed32_count = 5; alltypes.rep_sfixed32[4] = -2009;
-    alltypes.rep_float_count = 5; alltypes.rep_float[4] = 2010.0f;
-    
-    alltypes.rep_fixed64_count = 5; alltypes.rep_fixed64[4] = 2011;
-    alltypes.rep_sfixed64_count = 5; alltypes.rep_sfixed64[4] = -2012;
-    alltypes.rep_double_count = 5; alltypes.rep_double[4] = 2013.0;
-    
-    alltypes.rep_string_count = 5; strcpy(alltypes.rep_string[4], "2014");
-    alltypes.rep_bytes_count = 5; alltypes.rep_bytes[4].size = 4;
-    memcpy(alltypes.rep_bytes[4].bytes, "2015", 4);
-
-    alltypes.rep_submsg_count = 5;
-    strcpy(alltypes.rep_submsg[4].substuff1, "2016");
-    alltypes.rep_submsg[4].substuff2 = 2016;
-    alltypes.rep_submsg[4].has_substuff3 = true;
-    alltypes.rep_submsg[4].substuff3 = 2016;
-    
-    alltypes.rep_enum_count = 5; alltypes.rep_enum[4] = MyEnum_Truth;
-    
-    if (mode != 0)
-    {
-        /* Fill in values for optional fields */
-        alltypes.has_opt_int32 = true;
-        alltypes.opt_int32         = 3041;
-        alltypes.has_opt_int64 = true;
-        alltypes.opt_int64         = 3042;
-        alltypes.has_opt_uint32 = true;
-        alltypes.opt_uint32        = 3043;
-        alltypes.has_opt_uint64 = true;
-        alltypes.opt_uint64        = 3044;
-        alltypes.has_opt_sint32 = true;
-        alltypes.opt_sint32        = 3045;
-        alltypes.has_opt_sint64 = true;
-        alltypes.opt_sint64        = 3046;
-        alltypes.has_opt_bool = true;
-        alltypes.opt_bool          = true;
-        
-        alltypes.has_opt_fixed32 = true;
-        alltypes.opt_fixed32       = 3048;
-        alltypes.has_opt_sfixed32 = true;
-        alltypes.opt_sfixed32      = 3049;
-        alltypes.has_opt_float = true;
-        alltypes.opt_float         = 3050.0f;
-        
-        alltypes.has_opt_fixed64 = true;
-        alltypes.opt_fixed64       = 3051;
-        alltypes.has_opt_sfixed64 = true;
-        alltypes.opt_sfixed64      = 3052;
-        alltypes.has_opt_double = true;
-        alltypes.opt_double        = 3053.0;
-        
-        alltypes.has_opt_string = true;
-        strcpy(alltypes.opt_string, "3054");
-        alltypes.has_opt_bytes = true;
-        alltypes.opt_bytes.size = 4;
-        memcpy(alltypes.opt_bytes.bytes, "3055", 4);
-        alltypes.has_opt_submsg = true;
-        strcpy(alltypes.opt_submsg.substuff1, "3056");
-        alltypes.opt_submsg.substuff2 = 3056;
-        alltypes.has_opt_enum = true;
-        alltypes.opt_enum = MyEnum_Truth;
-    }
-    
-    alltypes.end = 1099;
-    
-    uint8_t buffer[1024];
-    pb_ostream_t stream = pb_ostream_from_buffer(buffer, sizeof(buffer));
-    
-    /* Now encode it and check if we succeeded. */
-    if (pb_encode(&stream, AllTypes_fields, &alltypes))
-    {
-        fwrite(buffer, 1, stream.bytes_written, stdout);
-        return 0; /* Success */
-    }
-    else
-    {
-        fprintf(stderr, "Encoding failed!\n");
-        return 1; /* Failure */
-    }
-}

tests/callbacks2.proto

@@ -1,9 +0,0 @@
-// Test if including generated header file for this file + implicit include of
-// callbacks.pb.h still compiles. Used with test_compiles.c.
-import "callbacks.proto";
-
-message Callback2Message {
-    required TestMessage tstmsg = 1;
-    required SubMessage submsg = 2;
-}
-

tests/decode_unittests.c

@@ -1,5 +1,3 @@
-#define NANOPB_INTERNALS
-
 #include <stdio.h>
 #include <string.h>
 #include "pb_decode.h"

tests/encode_unittests.c

@@ -1,5 +1,3 @@
-#define NANOPB_INTERNALS
-
 #include <stdio.h>
 #include <string.h>
 #include "pb_encode.h"
@@ -125,6 +123,7 @@ int main()
         uint8_t buffer[30];
         pb_ostream_t s;
         uint8_t value = 1;
+        int8_t svalue = -1;
         int32_t max = INT32_MAX;
         int32_t min = INT32_MIN;
         int64_t lmax = INT64_MAX;
@@ -133,6 +132,8 @@ int main()
         
         COMMENT("Test pb_enc_varint and pb_enc_svarint")
         TEST(WRITES(pb_enc_varint(&s, &field, &value), "\x01"));
+        TEST(WRITES(pb_enc_svarint(&s, &field, &svalue), "\x01"));
+        TEST(WRITES(pb_enc_svarint(&s, &field, &value), "\x02"));
         
         field.data_size = sizeof(max);
         TEST(WRITES(pb_enc_svarint(&s, &field, &max), "\xfe\xff\xff\xff\x0f"));

tests/missing_fields.proto

@@ -1,138 +0,0 @@
-/* Test for one missing field among many */
-
-message AllFields
-{
-    required int32 field1 = 1;
-    required int32 field2 = 2;
-    required int32 field3 = 3;
-    required int32 field4 = 4;
-    required int32 field5 = 5;
-    required int32 field6 = 6;
-    required int32 field7 = 7;
-    required int32 field8 = 8;
-    required int32 field9 = 9;
-    required int32 field10 = 10;
-    required int32 field11 = 11;
-    required int32 field12 = 12;
-    required int32 field13 = 13;
-    required int32 field14 = 14;
-    required int32 field15 = 15;
-    required int32 field16 = 16;
-    required int32 field17 = 17;
-    required int32 field18 = 18;
-    required int32 field19 = 19;
-    required int32 field20 = 20;
-    required int32 field21 = 21;
-    required int32 field22 = 22;
-    required int32 field23 = 23;
-    required int32 field24 = 24;
-    required int32 field25 = 25;
-    required int32 field26 = 26;
-    required int32 field27 = 27;
-    required int32 field28 = 28;
-    required int32 field29 = 29;
-    required int32 field30 = 30;
-    required int32 field31 = 31;
-    required int32 field32 = 32;
-    required int32 field33 = 33;
-    required int32 field34 = 34;
-    required int32 field35 = 35;
-    required int32 field36 = 36;
-    required int32 field37 = 37;
-    required int32 field38 = 38;
-    required int32 field39 = 39;
-    required int32 field40 = 40;
-    required int32 field41 = 41;
-    required int32 field42 = 42;
-    required int32 field43 = 43;
-    required int32 field44 = 44;
-    required int32 field45 = 45;
-    required int32 field46 = 46;
-    required int32 field47 = 47;
-    required int32 field48 = 48;
-    required int32 field49 = 49;
-    required int32 field50 = 50;
-    required int32 field51 = 51;
-    required int32 field52 = 52;
-    required int32 field53 = 53;
-    required int32 field54 = 54;
-    required int32 field55 = 55;
-    required int32 field56 = 56;
-    required int32 field57 = 57;
-    required int32 field58 = 58;
-    required int32 field59 = 59;
-    required int32 field60 = 60;
-    required int32 field61 = 61;
-    required int32 field62 = 62;
-    required int32 field63 = 63;
-    required int32 field64 = 64;
-}
-
-message MissingField
-{
-    required int32 field1 = 1;
-    required int32 field2 = 2;
-    required int32 field3 = 3;
-    required int32 field4 = 4;
-    required int32 field5 = 5;
-    required int32 field6 = 6;
-    required int32 field7 = 7;
-    required int32 field8 = 8;
-    required int32 field9 = 9;
-    required int32 field10 = 10;
-    required int32 field11 = 11;
-    required int32 field12 = 12;
-    required int32 field13 = 13;
-    required int32 field14 = 14;
-    required int32 field15 = 15;
-    required int32 field16 = 16;
-    required int32 field17 = 17;
-    required int32 field18 = 18;
-    required int32 field19 = 19;
-    required int32 field20 = 20;
-    required int32 field21 = 21;
-    required int32 field22 = 22;
-    required int32 field23 = 23;
-    required int32 field24 = 24;
-    required int32 field25 = 25;
-    required int32 field26 = 26;
-    required int32 field27 = 27;
-    required int32 field28 = 28;
-    required int32 field29 = 29;
-    required int32 field30 = 30;
-    required int32 field31 = 31;
-    required int32 field32 = 32;
-    required int32 field33 = 33;
-    required int32 field34 = 34;
-    required int32 field35 = 35;
-    required int32 field36 = 36;
-    required int32 field37 = 37;
-    required int32 field38 = 38;
-    required int32 field39 = 39;
-    required int32 field40 = 40;
-    required int32 field41 = 41;
-    required int32 field42 = 42;
-    required int32 field43 = 43;
-    required int32 field44 = 44;
-    required int32 field45 = 45;
-    required int32 field46 = 46;
-    required int32 field47 = 47;
-    required int32 field48 = 48;
-    required int32 field49 = 49;
-    required int32 field50 = 50;
-    required int32 field51 = 51;
-    required int32 field52 = 52;
-    required int32 field53 = 53;
-    required int32 field54 = 54;
-    required int32 field55 = 55;
-    required int32 field56 = 56;
-    required int32 field57 = 57;
-    required int32 field58 = 58;
-    required int32 field59 = 59;
-    required int32 field60 = 60;
-    required int32 field61 = 61;
-    required int32 field62 = 62;
-/*    required int32 field63 = 63; */
-    required int32 field64 = 64;
-}
-

tests/no_messages.proto

@@ -1,7 +0,0 @@
-/* Test that a file without any messages works. */
-
-enum Test {
-    First = 1;
-}
-
-

tests/options.expected

@@ -1,7 +0,0 @@
-char filesize\[20\];
-char msgsize\[30\];
-char fieldsize\[40\];
-pb_callback_t int32_callback;
-\sEnumValue1 = 1
-Message5_EnumValue1
-} pb_packed my_packed_struct;

tests/options.proto

@@ -1,73 +0,0 @@
-/* Test nanopb option parsing.
- * options.expected lists the patterns that are searched for in the output.
- */
-
-import "nanopb.proto";
-
-// File level options
-option (nanopb_fileopt).max_size = 20;
-
-message Message1
-{
-    required string filesize = 1;
-}
-
-// Message level options
-message Message2
-{
-    option (nanopb_msgopt).max_size = 30;
-    required string msgsize = 1;
-}
-
-// Field level options
-message Message3
-{
-    required string fieldsize = 1 [(nanopb).max_size = 40];
-}
-
-// Forced callback field
-message Message4
-{
-    required int32 int32_callback = 1 [(nanopb).type = FT_CALLBACK];
-}
-
-// Short enum names
-enum Enum1
-{
-    option (nanopb_enumopt).long_names = false;
-    EnumValue1 = 1;
-    EnumValue2 = 2;
-}
-
-message EnumTest
-{
-    required Enum1 field = 1 [default = EnumValue2];
-}
-
-// Short enum names inside message
-message Message5
-{
-    enum Enum2
-    {
-       option (nanopb_enumopt).long_names = false;
-       EnumValue1 = 1;
-    }
-    required Enum2 field = 1 [default = EnumValue1];
-}
-
-// Packed structure
-message my_packed_struct
-{
-    option (nanopb_msgopt).packed_struct = true;
-    optional int32 myfield = 1;
-}
-
-// Message with ignored field
-// Note: doesn't really test if the field is missing in the output,
-// but atleast tests that the output compiles.
-message Message6
-{
-    required int32 field1 = 1;
-    optional int32 field2 = 2 [(nanopb).type = FT_IGNORE];
-}
-

tests/test_decode1.c

@@ -63,19 +63,13 @@ int main()
     uint8_t buffer[512];
     size_t count = fread(buffer, 1, sizeof(buffer), stdin);
     
-    if (!feof(stdin))
-    {
-    	printf("Message does not fit in buffer\n");
-    	return 1;
-    }
-    
     /* Construct a pb_istream_t for reading from the buffer */
     pb_istream_t stream = pb_istream_from_buffer(buffer, count);
     
     /* Decode and print out the stuff */
     if (!print_person(&stream))
     {
-        printf("Parsing failed: %s\n", PB_GET_ERROR(&stream));
+        printf("Parsing failed.\n");
         return 1;
     } else {
         return 0;

tests/test_decode2.c

@@ -59,6 +59,13 @@ bool callback(pb_istream_t *stream, uint8_t *buf, size_t count)
     FILE *file = (FILE*)stream->state;
     bool status;
     
+    if (buf == NULL)
+    {
+       /* Skipping data */
+        while (count-- && fgetc(file) != EOF);
+        return count == 0;
+    }
+    
     status = (fread(buf, 1, count, file) == count);
     
     if (feof(file))
@@ -75,7 +82,7 @@ int main()
     pb_istream_t stream = {&callback, stdin, 10000};
     if (!print_person(&stream))
     {
-        printf("Parsing failed: %s\n", PB_GET_ERROR(&stream));
+        printf("Parsing failed.\n");
         return 1;
     } else {
         return 0;

tests/test_decode3.c

@@ -1,11 +1,10 @@
-/* Tests the decoding of all types.
+/* Tests the decoding of all types. Currently only in the 'required' variety.
  * This is the counterpart of test_encode3.
  * Run e.g. ./test_encode3 | ./test_decode3
  */
 
 #include <stdio.h>
 #include <string.h>
-#include <stdlib.h>
 #include <pb_decode.h>
 #include "alltypes.pb.h"
 
@@ -16,30 +15,27 @@
 
 /* This function is called once from main(), it handles
    the decoding and checks the fields. */
-bool check_alltypes(pb_istream_t *stream, int mode)
+bool check_alltypes(pb_istream_t *stream)
 {
-    AllTypes alltypes;
+    AllTypes alltypes = {};
-    
-    /* Fill with garbage to better detect initialization errors */
-    memset(&alltypes, 0xAA, sizeof(alltypes));
     
     if (!pb_decode(stream, AllTypes_fields, &alltypes))
         return false;
     
-    TEST(alltypes.req_int32         == -1001);
+    TEST(alltypes.req_int32         == 1001);
-    TEST(alltypes.req_int64         == -1002);
+    TEST(alltypes.req_int64         == 1002);
     TEST(alltypes.req_uint32        == 1003);
     TEST(alltypes.req_uint64        == 1004);
-    TEST(alltypes.req_sint32        == -1005);
+    TEST(alltypes.req_sint32        == 1005);
-    TEST(alltypes.req_sint64        == -1006);
+    TEST(alltypes.req_sint64        == 1006);
     TEST(alltypes.req_bool          == true);
     
     TEST(alltypes.req_fixed32       == 1008);
-    TEST(alltypes.req_sfixed32      == -1009);
+    TEST(alltypes.req_sfixed32      == 1009);
     TEST(alltypes.req_float         == 1010.0f);
     
     TEST(alltypes.req_fixed64       == 1011);
-    TEST(alltypes.req_sfixed64      == -1012);
+    TEST(alltypes.req_sfixed64      == 1012);
     TEST(alltypes.req_double        == 1013.0f);
     
     TEST(strcmp(alltypes.req_string, "1014") == 0);
@@ -47,146 +43,26 @@ bool check_alltypes(pb_istream_t *stream, int mode)
     TEST(memcmp(alltypes.req_bytes.bytes, "1015", 4) == 0);
     TEST(strcmp(alltypes.req_submsg.substuff1, "1016") == 0);
     TEST(alltypes.req_submsg.substuff2 == 1016);
-    TEST(alltypes.req_submsg.substuff3 == 3);
     TEST(alltypes.req_enum == MyEnum_Truth);
     
-    TEST(alltypes.rep_int32_count == 5 && alltypes.rep_int32[4] == -2001 && alltypes.rep_int32[0] == 0);
-    TEST(alltypes.rep_int64_count == 5 && alltypes.rep_int64[4] == -2002 && alltypes.rep_int64[0] == 0);
-    TEST(alltypes.rep_uint32_count == 5 && alltypes.rep_uint32[4] == 2003 && alltypes.rep_uint32[0] == 0);
-    TEST(alltypes.rep_uint64_count == 5 && alltypes.rep_uint64[4] == 2004 && alltypes.rep_uint64[0] == 0);
-    TEST(alltypes.rep_sint32_count == 5 && alltypes.rep_sint32[4] == -2005 && alltypes.rep_sint32[0] == 0);
-    TEST(alltypes.rep_sint64_count == 5 && alltypes.rep_sint64[4] == -2006 && alltypes.rep_sint64[0] == 0);
-    TEST(alltypes.rep_bool_count == 5 && alltypes.rep_bool[4] == true && alltypes.rep_bool[0] == false);
-    
-    TEST(alltypes.rep_fixed32_count == 5 && alltypes.rep_fixed32[4] == 2008 && alltypes.rep_fixed32[0] == 0);
-    TEST(alltypes.rep_sfixed32_count == 5 && alltypes.rep_sfixed32[4] == -2009 && alltypes.rep_sfixed32[0] == 0);
-    TEST(alltypes.rep_float_count == 5 && alltypes.rep_float[4] == 2010.0f && alltypes.rep_float[0] == 0.0f);
-    
-    TEST(alltypes.rep_fixed64_count == 5 && alltypes.rep_fixed64[4] == 2011 && alltypes.rep_fixed64[0] == 0);
-    TEST(alltypes.rep_sfixed64_count == 5 && alltypes.rep_sfixed64[4] == -2012 && alltypes.rep_sfixed64[0] == 0);
-    TEST(alltypes.rep_double_count == 5 && alltypes.rep_double[4] == 2013.0 && alltypes.rep_double[0] == 0.0);
-    
-    TEST(alltypes.rep_string_count == 5 && strcmp(alltypes.rep_string[4], "2014") == 0 && alltypes.rep_string[0][0] == '\0');
-    TEST(alltypes.rep_bytes_count == 5 && alltypes.rep_bytes[4].size == 4 && alltypes.rep_bytes[0].size == 0);
-    TEST(memcmp(alltypes.rep_bytes[4].bytes, "2015", 4) == 0);
-
-    TEST(alltypes.rep_submsg_count == 5);
-    TEST(strcmp(alltypes.rep_submsg[4].substuff1, "2016") == 0 && alltypes.rep_submsg[0].substuff1[0] == '\0');
-    TEST(alltypes.rep_submsg[4].substuff2 == 2016 && alltypes.rep_submsg[0].substuff2 == 0);
-    TEST(alltypes.rep_submsg[4].substuff3 == 2016 && alltypes.rep_submsg[0].substuff3 == 3);
-    
-    TEST(alltypes.rep_enum_count == 5 && alltypes.rep_enum[4] == MyEnum_Truth && alltypes.rep_enum[0] == MyEnum_Zero);
-    
-    if (mode == 0)
-    {
-        /* Expect default values */
-        TEST(alltypes.has_opt_int32     == false);
-        TEST(alltypes.opt_int32         == 4041);
-        TEST(alltypes.has_opt_int64     == false);
-        TEST(alltypes.opt_int64         == 4042);
-        TEST(alltypes.has_opt_uint32    == false);
-        TEST(alltypes.opt_uint32        == 4043);
-        TEST(alltypes.has_opt_uint64    == false);
-        TEST(alltypes.opt_uint64        == 4044);
-        TEST(alltypes.has_opt_sint32    == false);
-        TEST(alltypes.opt_sint32        == 4045);
-        TEST(alltypes.has_opt_sint64    == false);
-        TEST(alltypes.opt_sint64        == 4046);
-        TEST(alltypes.has_opt_bool      == false);
-        TEST(alltypes.opt_bool          == false);
-        
-        TEST(alltypes.has_opt_fixed32   == false);
-        TEST(alltypes.opt_fixed32       == 4048);
-        TEST(alltypes.has_opt_sfixed32  == false);
-        TEST(alltypes.opt_sfixed32      == 4049);
-        TEST(alltypes.has_opt_float     == false);
-        TEST(alltypes.opt_float         == 4050.0f);
-        
-        TEST(alltypes.has_opt_fixed64   == false);
-        TEST(alltypes.opt_fixed64       == 4051);
-        TEST(alltypes.has_opt_sfixed64  == false);
-        TEST(alltypes.opt_sfixed64      == 4052);
-        TEST(alltypes.has_opt_double    == false);
-        TEST(alltypes.opt_double        == 4053.0);
-        
-        TEST(alltypes.has_opt_string    == false);
-        TEST(strcmp(alltypes.opt_string, "4054") == 0);
-        TEST(alltypes.has_opt_bytes     == false);
-        TEST(alltypes.opt_bytes.size == 4);
-        TEST(memcmp(alltypes.opt_bytes.bytes, "4055", 4) == 0);
-        TEST(alltypes.has_opt_submsg    == false);
-        TEST(strcmp(alltypes.opt_submsg.substuff1, "1") == 0);
-        TEST(alltypes.opt_submsg.substuff2 == 2);
-        TEST(alltypes.opt_submsg.substuff3 == 3);
-        TEST(alltypes.has_opt_enum     == false);
-        TEST(alltypes.opt_enum == MyEnum_Second);
-    }
-    else
-    {
-        /* Expect filled-in values */
-        TEST(alltypes.has_opt_int32     == true);
-        TEST(alltypes.opt_int32         == 3041);
-        TEST(alltypes.has_opt_int64     == true);
-        TEST(alltypes.opt_int64         == 3042);
-        TEST(alltypes.has_opt_uint32    == true);
-        TEST(alltypes.opt_uint32        == 3043);
-        TEST(alltypes.has_opt_uint64    == true);
-        TEST(alltypes.opt_uint64        == 3044);
-        TEST(alltypes.has_opt_sint32    == true);
-        TEST(alltypes.opt_sint32        == 3045);
-        TEST(alltypes.has_opt_sint64    == true);
-        TEST(alltypes.opt_sint64        == 3046);
-        TEST(alltypes.has_opt_bool      == true);
-        TEST(alltypes.opt_bool          == true);
-        
-        TEST(alltypes.has_opt_fixed32   == true);
-        TEST(alltypes.opt_fixed32       == 3048);
-        TEST(alltypes.has_opt_sfixed32  == true);
-        TEST(alltypes.opt_sfixed32      == 3049);
-        TEST(alltypes.has_opt_float     == true);
-        TEST(alltypes.opt_float         == 3050.0f);
-        
-        TEST(alltypes.has_opt_fixed64   == true);
-        TEST(alltypes.opt_fixed64       == 3051);
-        TEST(alltypes.has_opt_sfixed64  == true);
-        TEST(alltypes.opt_sfixed64      == 3052);
-        TEST(alltypes.has_opt_double    == true);
-        TEST(alltypes.opt_double        == 3053.0);
-        
-        TEST(alltypes.has_opt_string    == true);
-        TEST(strcmp(alltypes.opt_string, "3054") == 0);
-        TEST(alltypes.has_opt_bytes     == true);
-        TEST(alltypes.opt_bytes.size == 4);
-        TEST(memcmp(alltypes.opt_bytes.bytes, "3055", 4) == 0);
-        TEST(alltypes.has_opt_submsg    == true);
-        TEST(strcmp(alltypes.opt_submsg.substuff1, "3056") == 0);
-        TEST(alltypes.opt_submsg.substuff2 == 3056);
-        TEST(alltypes.opt_submsg.substuff3 == 3);
-        TEST(alltypes.has_opt_enum      == true);
-        TEST(alltypes.opt_enum == MyEnum_Truth);
-    }
-    
     TEST(alltypes.end == 1099);
     
     return true;
 }
 
-int main(int argc, char **argv)
+int main()
 {
-    /* Whether to expect the optional values or the default values. */
-    int mode = (argc > 1) ? atoi(argv[1]) : 0;
-    
     /* Read the data into buffer */
-    uint8_t buffer[1024];
+    uint8_t buffer[512];
     size_t count = fread(buffer, 1, sizeof(buffer), stdin);
     
     /* Construct a pb_istream_t for reading from the buffer */
     pb_istream_t stream = pb_istream_from_buffer(buffer, count);
     
     /* Decode and print out the stuff */
-    if (!check_alltypes(&stream, mode))
+    if (!check_alltypes(&stream))
     {
-        printf("Parsing failed: %s\n", PB_GET_ERROR(&stream));
+        printf("Parsing failed.\n");
         return 1;
     } else {
         return 0;

tests/test_decode4.c

@@ -0,0 +1,139 @@
+/* Tests the decoding of all types. Currently only in the 'required' variety.
+ * This is the counterpart of test_encode3.
+ * Run e.g. ./test_encode3 | ./test_decode3
+ */
+
+#include <stdio.h>
+#include <string.h>
+#include <pb_decode.h>
+#include "aligntype.pb.h"
+
+#define TEST(x) if (!(x)) { \
+    printf("Test " #x " failed.\n"); \
+    return false; \
+    }
+
+/* This function is called once from main(), it handles
+   the decoding and checks the fields. */
+bool check_aligntypes(pb_istream_t *stream)
+{
+    AlignTypes aligntypes = {};
+    
+    if (!pb_decode(stream, AlignTypes_fields, &aligntypes))
+        return false;
+    
+    TEST(aligntypes.req_bool          == true);
+    TEST(aligntypes.req_int32         == 1001);
+    TEST(strcmp(aligntypes.req_submsg.substuff1, "1002") == 0);
+    TEST(aligntypes.req_submsg.substuff2 == 1002);
+    TEST(aligntypes.req_int64         == 1003);
+    TEST(strcmp(aligntypes.req_string, "1004") == 0);
+    TEST(aligntypes.req_enum == MyEnum_Truth);
+    TEST(aligntypes.req_bytes.size == 4);
+    TEST(memcmp(aligntypes.req_bytes.bytes, "1005", 4) == 0);
+    TEST(aligntypes.req_sint32        == 1006);
+    TEST(aligntypes.req_bool_2        == true);
+    TEST(aligntypes.req_sint64        == 1007);
+    TEST(aligntypes.req_bool_3        == true);
+    TEST(aligntypes.req_fixed32       == 1008);
+    TEST(aligntypes.req_bool_4        == true);
+    TEST(aligntypes.req_fixed64       == 1009);
+    TEST(aligntypes.req_bool_5        == true);
+    TEST(aligntypes.req_float         == 1010.0f);
+    TEST(aligntypes.req_bool_5        == true);
+    TEST(aligntypes.req_double        == 1011.0f);
+   
+    TEST(aligntypes.has_opt_bool      == true);
+    TEST(aligntypes.opt_bool          == true);
+    TEST(aligntypes.has_opt_int32     == true);
+    TEST(aligntypes.opt_int32         == 1001);
+    TEST(aligntypes.has_opt_submsg    == true);
+    TEST(strcmp(aligntypes.opt_submsg.substuff1, "1002") == 0);
+    TEST(aligntypes.opt_submsg.substuff2 == 1002);
+    TEST(aligntypes.has_opt_int64     == true);
+    TEST(aligntypes.opt_int64         == 1003);
+    TEST(aligntypes.has_opt_string    == true);
+    TEST(strcmp(aligntypes.opt_string, "1004") == 0);
+    TEST(aligntypes.has_opt_enum      == true);
+    TEST(aligntypes.opt_enum == MyEnum_Truth);
+    TEST(aligntypes.has_opt_bytes     == true);
+    TEST(aligntypes.opt_bytes.size == 4);
+    TEST(memcmp(aligntypes.opt_bytes.bytes, "1005", 4) == 0);
+    TEST(aligntypes.has_opt_sint32    == true);
+    TEST(aligntypes.opt_sint32        == 1006);
+    TEST(aligntypes.has_opt_bool_2    == true);
+    TEST(aligntypes.opt_bool_2        == true);
+    TEST(aligntypes.has_opt_sint64    == true);
+    TEST(aligntypes.opt_sint64        == 1007);
+    TEST(aligntypes.has_opt_bool_3    == true);
+    TEST(aligntypes.opt_bool_3        == true);
+    TEST(aligntypes.has_opt_fixed32   == true);
+    TEST(aligntypes.opt_fixed32       == 1008);
+    TEST(aligntypes.has_opt_bool_4    == true);
+    TEST(aligntypes.opt_bool_4        == true);
+    TEST(aligntypes.has_opt_fixed64   == true);
+    TEST(aligntypes.opt_fixed64       == 1009);
+    TEST(aligntypes.has_opt_bool_5    == true);
+    TEST(aligntypes.opt_bool_5        == true);
+    TEST(aligntypes.has_opt_float     == true);
+    TEST(aligntypes.opt_float         == 1010.0f);
+    TEST(aligntypes.has_opt_bool_6    == true);
+    TEST(aligntypes.opt_bool_6        == true);
+    TEST(aligntypes.has_opt_double    == true);
+    TEST(aligntypes.opt_double        == 1011.0f);
+
+    TEST(aligntypes.req_bool_aligned   == true);
+    TEST(aligntypes.req_int32_aligned  == 1001);
+    TEST(aligntypes.req_int64_aligned  == 1003);
+    TEST(aligntypes.req_enum_aligned   == MyEnum_Truth);
+    TEST(aligntypes.req_sint32_aligned == 1006);
+    TEST(aligntypes.req_sint64_aligned == 1007);
+    TEST(aligntypes.req_fixed32_aligned == 1008);
+    TEST(aligntypes.req_fixed64_aligned == 1009);
+    TEST(aligntypes.req_float_aligned  == 1010.0f);
+    TEST(aligntypes.req_double_aligned == 1011.0f);
+
+    TEST(aligntypes.has_opt_bool_aligned      == true);
+    TEST(aligntypes.opt_bool_aligned          == true);
+    TEST(aligntypes.has_opt_int32_aligned     == true);
+    TEST(aligntypes.opt_int32_aligned         == 1001);
+    TEST(aligntypes.has_opt_int64_aligned     == true);
+    TEST(aligntypes.opt_int64_aligned         == 1003);
+    TEST(aligntypes.has_opt_enum_aligned      == true);
+    TEST(aligntypes.opt_enum_aligned == MyEnum_Truth);
+    TEST(aligntypes.has_opt_sint32_aligned    == true);
+    TEST(aligntypes.opt_sint32_aligned        == 1006);
+    TEST(aligntypes.has_opt_sint64_aligned    == true);
+    TEST(aligntypes.opt_sint64_aligned        == 1007);
+    TEST(aligntypes.has_opt_fixed32_aligned   == true);
+    TEST(aligntypes.opt_fixed32_aligned       == 1008);
+    TEST(aligntypes.has_opt_fixed64_aligned   == true);
+    TEST(aligntypes.opt_fixed64_aligned       == 1009);
+    TEST(aligntypes.has_opt_float_aligned     == true);
+    TEST(aligntypes.opt_float_aligned         == 1010.0f);
+    TEST(aligntypes.has_opt_double_aligned    == true);
+    TEST(aligntypes.opt_double_aligned        == 1011.0f);
+
+    TEST(aligntypes.end == 1099);
+    
+    return true;
+}
+
+int main()
+{
+    /* Read the data into buffer */
+    uint8_t buffer[512];
+    size_t count = fread(buffer, 1, sizeof(buffer), stdin);
+    
+    /* Construct a pb_istream_t for reading from the buffer */
+    pb_istream_t stream = pb_istream_from_buffer(buffer, count);
+    
+    /* Decode and print out the stuff */
+    if (!check_aligntypes(&stream))
+    {
+        printf("Parsing failed.\n");
+        return 1;
+    } else {
+        return 0;
+    }
+}

tests/test_decode_callbacks.c

@@ -37,7 +37,7 @@ bool print_int32(pb_istream_t *stream, const pb_field_t *field, void *arg)
 bool print_fixed32(pb_istream_t *stream, const pb_field_t *field, void *arg)
 {
     uint32_t value;
-    if (!pb_decode_fixed32(stream, &value))
+    if (!pb_dec_fixed32(stream, NULL, &value))
         return false;
     
     printf((char*)arg, (long)value);
@@ -47,7 +47,7 @@ bool print_fixed32(pb_istream_t *stream, const pb_field_t *field, void *arg)
 bool print_fixed64(pb_istream_t *stream, const pb_field_t *field, void *arg)
 {
     uint64_t value;
-    if (!pb_decode_fixed64(stream, &value))
+    if (!pb_dec_fixed64(stream, NULL, &value))
         return false;
     
     printf((char*)arg, (long long)value);

tests/test_encode3.c

@@ -1,117 +1,40 @@
 /* Attempts to test all the datatypes supported by ProtoBuf.
+ * Currently only tests the 'required' variety.
  */
 
 #include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
 #include <pb_encode.h>
 #include "alltypes.pb.h"
 
-int main(int argc, char **argv)
+int main()
 {
-    int mode = (argc > 1) ? atoi(argv[1]) : 0;
-    
     /* Initialize the structure with constants */
-    AllTypes alltypes = {0};
+    AllTypes alltypes = {
-    
+        1001,
-    alltypes.req_int32         = -1001;
+        1002,
-    alltypes.req_int64         = -1002;
+        1003,
-    alltypes.req_uint32        = 1003;
+        1004,
-    alltypes.req_uint64        = 1004;
+        1005,
-    alltypes.req_sint32        = -1005;
+        1006,
-    alltypes.req_sint64        = -1006;
+        true,
-    alltypes.req_bool          = true;
-    
-    alltypes.req_fixed32       = 1008;
-    alltypes.req_sfixed32      = -1009;
-    alltypes.req_float         = 1010.0f;
-    
-    alltypes.req_fixed64       = 1011;
-    alltypes.req_sfixed64      = -1012;
-    alltypes.req_double        = 1013.0;
-    
-    strcpy(alltypes.req_string, "1014");
-    alltypes.req_bytes.size = 4;
-    memcpy(alltypes.req_bytes.bytes, "1015", 4);
-    strcpy(alltypes.req_submsg.substuff1, "1016");
-    alltypes.req_submsg.substuff2 = 1016;
-    alltypes.req_enum = MyEnum_Truth;
-    
-    alltypes.rep_int32_count = 5; alltypes.rep_int32[4] = -2001;
-    alltypes.rep_int64_count = 5; alltypes.rep_int64[4] = -2002;
-    alltypes.rep_uint32_count = 5; alltypes.rep_uint32[4] = 2003;
-    alltypes.rep_uint64_count = 5; alltypes.rep_uint64[4] = 2004;
-    alltypes.rep_sint32_count = 5; alltypes.rep_sint32[4] = -2005;
-    alltypes.rep_sint64_count = 5; alltypes.rep_sint64[4] = -2006;
-    alltypes.rep_bool_count = 5; alltypes.rep_bool[4] = true;
-    
-    alltypes.rep_fixed32_count = 5; alltypes.rep_fixed32[4] = 2008;
-    alltypes.rep_sfixed32_count = 5; alltypes.rep_sfixed32[4] = -2009;
-    alltypes.rep_float_count = 5; alltypes.rep_float[4] = 2010.0f;
-    
-    alltypes.rep_fixed64_count = 5; alltypes.rep_fixed64[4] = 2011;
-    alltypes.rep_sfixed64_count = 5; alltypes.rep_sfixed64[4] = -2012;
-    alltypes.rep_double_count = 5; alltypes.rep_double[4] = 2013.0;
-    
-    alltypes.rep_string_count = 5; strcpy(alltypes.rep_string[4], "2014");
-    alltypes.rep_bytes_count = 5; alltypes.rep_bytes[4].size = 4;
-    memcpy(alltypes.rep_bytes[4].bytes, "2015", 4);
-
-    alltypes.rep_submsg_count = 5;
-    strcpy(alltypes.rep_submsg[4].substuff1, "2016");
-    alltypes.rep_submsg[4].substuff2 = 2016;
-    alltypes.rep_submsg[4].has_substuff3 = true;
-    alltypes.rep_submsg[4].substuff3 = 2016;
-    
-    alltypes.rep_enum_count = 5; alltypes.rep_enum[4] = MyEnum_Truth;
-    
-    if (mode != 0)
-    {
-        /* Fill in values for optional fields */
-        alltypes.has_opt_int32 = true;
-        alltypes.opt_int32         = 3041;
-        alltypes.has_opt_int64 = true;
-        alltypes.opt_int64         = 3042;
-        alltypes.has_opt_uint32 = true;
-        alltypes.opt_uint32        = 3043;
-        alltypes.has_opt_uint64 = true;
-        alltypes.opt_uint64        = 3044;
-        alltypes.has_opt_sint32 = true;
-        alltypes.opt_sint32        = 3045;
-        alltypes.has_opt_sint64 = true;
-        alltypes.opt_sint64        = 3046;
-        alltypes.has_opt_bool = true;
-        alltypes.opt_bool          = true;
         
-        alltypes.has_opt_fixed32 = true;
+        1008,
-        alltypes.opt_fixed32       = 3048;
+        1009,
-        alltypes.has_opt_sfixed32 = true;
+        1010.0f,
-        alltypes.opt_sfixed32      = 3049;
-        alltypes.has_opt_float = true;
-        alltypes.opt_float         = 3050.0f;
         
-        alltypes.has_opt_fixed64 = true;
+        1011,
-        alltypes.opt_fixed64       = 3051;
+        1012,
-        alltypes.has_opt_sfixed64 = true;
+        1013.0,
-        alltypes.opt_sfixed64      = 3052;
-        alltypes.has_opt_double = true;
-        alltypes.opt_double        = 3053.0;
         
-        alltypes.has_opt_string = true;
+        "1014",
-        strcpy(alltypes.opt_string, "3054");
+        {4, "1015"},
-        alltypes.has_opt_bytes = true;
+        {"1016", 1016},
-        alltypes.opt_bytes.size = 4;
+        MyEnum_Truth,
-        memcpy(alltypes.opt_bytes.bytes, "3055", 4);
+        
-        alltypes.has_opt_submsg = true;
+        1099
-        strcpy(alltypes.opt_submsg.substuff1, "3056");
+    };
-        alltypes.opt_submsg.substuff2 = 3056;
-        alltypes.has_opt_enum = true;
-        alltypes.opt_enum = MyEnum_Truth;
-    }
     
-    alltypes.end = 1099;
+    uint8_t buffer[512];
-    
-    uint8_t buffer[1024];
     pb_ostream_t stream = pb_ostream_from_buffer(buffer, sizeof(buffer));
     
     /* Now encode it and check if we succeeded. */
@@ -122,7 +45,6 @@ int main(int argc, char **argv)
     }
     else
     {
-        fprintf(stderr, "Encoding failed!\n");
         return 1; /* Failure */
     }
 }

tests/test_encode4.c

@@ -0,0 +1,117 @@
+/* Attempts to test all the datatypes supported by ProtoBuf.
+ * Currently only tests the 'required' variety.
+ */
+
+#include <stdio.h>
+#include <pb_encode.h>
+#include "aligntype.pb.h"
+
+int main()
+{
+    /* Initialize the structure with constants */
+    AlignTypes aligntypes = {
+        true,
+        1001,
+        {"1002", 1002},
+        1003,
+        "1004",
+        MyEnum_Truth,
+        {4, "1005"},
+        1006,
+        true,
+        1007,
+        true,
+        1008,
+        true,
+        1009,
+        true,
+        1010.0f,
+        true,
+        1011.0f,
+
+        true,
+        true,
+        true,
+        1001,
+        true,
+        {"1002", 1002},
+        true,
+        1003,
+        true,
+        "1004",
+        true,
+        MyEnum_Truth,
+        true,
+        {4, "1005"},
+        true,
+        1006,
+        true,
+        true,
+        true,
+        1007,
+        true,
+        true,
+        true,
+        1008,
+        true,
+        true,
+        true,
+        1009,
+        true,
+        true,
+        true,
+        1010.0f,
+        true,
+        true,
+        true,
+        1011.0f,
+        
+        true,
+        1001,
+        1003,
+        MyEnum_Truth,
+        1006,
+        1007,
+        1008,
+        1009,
+        1010.0f,
+        1011.0f,
+
+        true,
+        true,
+        true,
+        1001,
+        true,
+        1003,
+        true,
+        MyEnum_Truth,
+        true,
+        1006,
+        true,
+        1007,
+        true,
+        1008,
+        true,
+        1009,
+        true,
+        1010.0f,
+        true,
+        1011.0f,
+
+        1099
+    };
+    
+    uint8_t buffer[512];
+    pb_ostream_t stream = pb_ostream_from_buffer(buffer, sizeof(buffer));
+    
+    /* Now encode it and check if we succeeded. */
+    if (pb_encode(&stream, AlignTypes_fields, &aligntypes))
+    {
+        fwrite(buffer, 1, stream.bytes_written, stdout);
+        return 0; /* Success */
+    }
+    else
+    {
+        return 1; /* Failure */
+    }
+}

tests/test_encode_callbacks.c

@@ -29,7 +29,7 @@ bool encode_fixed32(pb_ostream_t *stream, const pb_field_t *field, const void *a
         return false;
     
     uint32_t value = 42;
-    return pb_encode_fixed32(stream, &value);
+    return pb_enc_fixed32(stream, field, &value);
 }
 
 bool encode_fixed64(pb_ostream_t *stream, const pb_field_t *field, const void *arg)
@@ -38,7 +38,7 @@ bool encode_fixed64(pb_ostream_t *stream, const pb_field_t *field, const void *a
         return false;
     
     uint64_t value = 42;
-    return pb_encode_fixed64(stream, &value);
+    return pb_enc_fixed64(stream, field, &value);
 }
 
 int main()

tests/test_missing_fields.c

@@ -1,49 +0,0 @@
-/* Checks that missing required fields are detected properly */
-
-#include <stdio.h>
-#include <pb_encode.h>
-#include <pb_decode.h>
-#include "missing_fields.pb.h"
-
-int main()
-{
-    uint8_t buffer[512] = {};
-    
-    /* Create a message with one missing field */
-    {
-        MissingField msg = {};
-        pb_ostream_t stream = pb_ostream_from_buffer(buffer, sizeof(buffer));
-        if (!pb_encode(&stream, MissingField_fields, &msg))
-        {
-            printf("Encode failed.\n");
-            return 1;
-        }
-    }
-
-    /* Test that it decodes properly if we don't require that field */
-    {
-        MissingField msg = {};
-        pb_istream_t stream = pb_istream_from_buffer(buffer, sizeof(buffer));
-        
-        if (!pb_decode(&stream, MissingField_fields, &msg))
-        {
-            printf("Decode failed: %s\n", PB_GET_ERROR(&stream));
-            return 2;
-        }
-    }
-    
-    /* Test that it does *not* decode properly if we require the field */
-    {
-        AllFields msg = {};
-        pb_istream_t stream = pb_istream_from_buffer(buffer, sizeof(buffer));
-        
-        if (pb_decode(&stream, AllFields_fields, &msg))
-        {
-            printf("Decode didn't detect missing field.\n");
-            return 3;
-        }
-    }
-    
-    return 0; /* All ok */
-}
-

tests/test_multiple_files.c

@@ -1,13 +0,0 @@
-/*
- * Tests if still compile if typedefs are redfefined in STATIC_ASSERTS when
- * proto file includes another poto file
- */
-
-#include <stdio.h>
-#include <pb_encode.h>
-#include "callbacks2.pb.h"
-
-int main()
-{
-	return 0;
-}

tests/testperson.pb

@@ -1,3 +0,0 @@
-
-Test Person7foobar@foobar.com"
-555-12345678

tools/set_version.sh

@@ -1,10 +0,0 @@
-#!/bin/bash
-
-# Run this from the top directory of nanopb tree.
-# e.g. user@localhost:~/nanopb$ tools/set_version.sh nanopb-0.1.9-dev
-# It sets the version number in pb.h and generator/nanopb_generator.py.
-
-sed -i -e 's/nanopb_version\s*=\s*"[^"]*"/nanopb_version = "'$1'"/' generator/nanopb_generator.py
-sed -i -e 's/#define\s*NANOPB_VERSION\s*.*/#define NANOPB_VERSION '$1'/' pb.h
-
-